511 lines
16 KiB
Plaintext
511 lines
16 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_ca1d1f74",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 46,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "nit: here and many other lines, should be consistently wrapped to make it readable on gerrit with default settings.",
|
|
"range": {
|
|
"startLine": 46,
|
|
"startChar": 79,
|
|
"endLine": 46,
|
|
"endChar": 80
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_2a25dbc2",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 74,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "Are there any specific ideas on implementing this? Should it be a single binary which is being extended during the compilation, or should it be more like a pluggable mechanism in kubectl [1]?\n\n[1] https://kubernetes.io/docs/tasks/extend-kubectl/kubectl-plugins/",
|
|
"range": {
|
|
"startLine": 74,
|
|
"startChar": 0,
|
|
"endLine": 74,
|
|
"endChar": 9
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_65cc64bc",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 183,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "Should we prefix all plugin specific configs to reduce ambiguity? E.g. with set-document-repository, set-document-clone-path, etc.",
|
|
"range": {
|
|
"startLine": 183,
|
|
"startChar": 25,
|
|
"endLine": 183,
|
|
"endChar": 29
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_41556ac5",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 183,
|
|
"author": {
|
|
"id": 27046
|
|
},
|
|
"writtenOn": "2019-06-10T15:28:54Z",
|
|
"side": 1,
|
|
"message": "IS there enough ambiguity that we would need to do that. LErts see how this evolves, maybe ther eis a need for somethign liek that. At teh moment I am not sure I can see it",
|
|
"parentUuid": "bfb3d3c7_65cc64bc",
|
|
"range": {
|
|
"startLine": 183,
|
|
"startChar": 25,
|
|
"endLine": 183,
|
|
"endChar": 29
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_a59b3cc7",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 192,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "nit: pegleg documentation refers to this file as \"site-definition.yaml\"",
|
|
"range": {
|
|
"startLine": 192,
|
|
"startChar": 76,
|
|
"endLine": 192,
|
|
"endChar": 96
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_e5f054cc",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 212,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "Is this one-time command? Or is it idempotent and would allow me to run it as many times as I want? Should we implement erase-bootstrap to be able to bootstrap the cluster from scratch?",
|
|
"range": {
|
|
"startLine": 212,
|
|
"startChar": 14,
|
|
"endLine": 212,
|
|
"endChar": 23
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_ab38ea3c",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 218,
|
|
"author": {
|
|
"id": 7769
|
|
},
|
|
"writtenOn": "2019-05-21T23:39:16Z",
|
|
"side": 1,
|
|
"message": "Clearly this definition will evolve, but:\n\n- optional [phase] to target just one phase in the bootstrap process\n- determine whether bootstrap should try and orchestrate something like k3s itself or expect the user to have done that prior to bootstrap. Cost of embedding k3s (50MB) is really the k8s images (200MB). The installation outside of airship is rather simple: \n-- sudo k3s server \u0026\n-- # Kubeconfig is written to /etc/rancher/k3s/k3s.yaml\n-- sudo k3s kubectl get node\n- if we expect a pre-existing cluster, ephemeral or not, they will need to provide kubeconfig context for the ephemeral cluster cluster which may be separate from what is defined for the site\n- if this is effectively driving what clusterctl would do, presumably the yaml it needs is within the overall document set and we can find them (e.g. provider components, machines)\n- how will we know we need to insert things like baremetalnodes, as that is provider dependant, e.g. required for metal3-io but not for azure.",
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_a16f8690",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 218,
|
|
"author": {
|
|
"id": 27046
|
|
},
|
|
"writtenOn": "2019-06-10T15:28:54Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "bfb3d3c7_ab38ea3c",
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_a5bc9cdc",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 237,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "nit: here and below are many trailing spaces.",
|
|
"range": {
|
|
"startLine": 237,
|
|
"startChar": 70,
|
|
"endLine": 237,
|
|
"endChar": 71
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_0b49f6ce",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 258,
|
|
"author": {
|
|
"id": 7769
|
|
},
|
|
"writtenOn": "2019-05-21T23:39:16Z",
|
|
"side": 1,
|
|
"message": "is this equivalent to pegleg collect?",
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_61ec2ef3",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 258,
|
|
"author": {
|
|
"id": 27046
|
|
},
|
|
"writtenOn": "2019-06-10T15:28:54Z",
|
|
"side": 1,
|
|
"message": "I am thinking this is how you drive some of peglegs site functions like collect and render. I guess they could be explicit as well instead of wrap into this subcommand",
|
|
"parentUuid": "bfb3d3c7_0b49f6ce",
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_eb17c2a2",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 273,
|
|
"author": {
|
|
"id": 7769
|
|
},
|
|
"writtenOn": "2019-05-21T23:39:16Z",
|
|
"side": 1,
|
|
"message": "I think we should consider making Armada documents simply proper CRDs so that there are only CRDs - even if we dont leverage an armada operator. Need to factor in how we can securely store them though like secrets, as they may contain passwords after bundling.",
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_a58a5c18",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 275,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "deployed",
|
|
"range": {
|
|
"startLine": 275,
|
|
"startChar": 48,
|
|
"endLine": 275,
|
|
"endChar": 57
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_6584640d",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 275,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "CRDs",
|
|
"range": {
|
|
"startLine": 275,
|
|
"startChar": 95,
|
|
"endLine": 275,
|
|
"endChar": 98
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_0573284f",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 288,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "bundle?",
|
|
"range": {
|
|
"startLine": 288,
|
|
"startChar": 51,
|
|
"endLine": 288,
|
|
"endChar": 57
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_ab11caae",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 290,
|
|
"author": {
|
|
"id": 7769
|
|
},
|
|
"writtenOn": "2019-05-21T23:39:16Z",
|
|
"side": 1,
|
|
"message": "What is the difference create and apply?",
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_65b224e9",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 317,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "++",
|
|
"range": {
|
|
"startLine": 317,
|
|
"startChar": 111,
|
|
"endLine": 317,
|
|
"endChar": 138
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_05d6c8f2",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 323,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "Should probably run all types of validation by default, if no options specified.",
|
|
"range": {
|
|
"startLine": 323,
|
|
"startChar": 2,
|
|
"endLine": 323,
|
|
"endChar": 18
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_45512062",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 335,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "Looking at site authoring guide in treasuremap, creating a deployable reference document would require a lot of manual work from the user, this makes creating a skeleton of the Airship documents a negligible problem (considering they can be easily copied from an existing repo). Is it worth implementing it as this stage?",
|
|
"range": {
|
|
"startLine": 335,
|
|
"startChar": 28,
|
|
"endLine": 335,
|
|
"endChar": 32
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_cbc75e12",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 341,
|
|
"author": {
|
|
"id": 7769
|
|
},
|
|
"writtenOn": "2019-05-21T23:39:16Z",
|
|
"side": 1,
|
|
"message": "We may want to pay careful attention to the directory layout especially for bootstrapping, because it may be one of the ways we can signal to the bootstrap process what documents should be fed in during a clusterctl like process. In other words, what are the add-ons, what are the provider components, and so on - normally these are fed directly in as yaml snippets to the application where we need to find them in the larger airship document payload",
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_05e00896",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 390,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "I have the same question as for \"bootstrap\" is this command re-runnable, does it participate life cycle management of the site?",
|
|
"range": {
|
|
"startLine": 390,
|
|
"startChar": 2,
|
|
"endLine": 390,
|
|
"endChar": 6
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_25dbcced",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 400,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "++",
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_05f9e84b",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 413,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "Is this a warpper on top of Argo? Or is it only for managing the YAMLs and not for interacting with Argo?",
|
|
"range": {
|
|
"startLine": 413,
|
|
"startChar": 17,
|
|
"endLine": 413,
|
|
"endChar": 25
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_85a2b84a",
|
|
"filename": "specs/approved/airshipctl.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 433,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2019-05-21T18:44:06Z",
|
|
"side": 1,
|
|
"message": "doesn\u0027t",
|
|
"range": {
|
|
"startLine": 433,
|
|
"startChar": 45,
|
|
"endLine": 433,
|
|
"endChar": 51
|
|
},
|
|
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |