airship/specs
Code Issues Proposed changes
6bc4cb94f6
specs/b52bf021d87a1d3fc69fd3f7071b2629ba850348
Gerrit User 28618 1a690e0242 Update patch set 2 
Patch Set 2:

(1 comment)

Patch-set: 2
Label: Verified=0
2019-03-13 21:48:05 +00:00

226 lines
7.4 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "5fc1f717_1bfb2779",
"filename": "specs/approved/airship_multi_linux_distros.rst",
"patchSetId": 2
},
"lineNbr": 69,
"author": {
"id": 26449
},
"writtenOn": "2019-03-13T17:41:51Z",
"side": 1,
"message": "Why is this? Maybe just say that the changes must be backwards compatible.",
"range": {
"startLine": 68,
"startChar": 0,
"endLine": 69,
"endChar": 57
},
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_9bbf1760",
"filename": "specs/approved/airship_multi_linux_distros.rst",
"patchSetId": 2
},
"lineNbr": 69,
"author": {
"id": 28618
},
"writtenOn": "2019-03-13T17:51:07Z",
"side": 1,
"message": "Agreed. The jobs should be renamed to match the pattern of the new ones coming in.",
"parentUuid": "5fc1f717_1bfb2779",
"range": {
"startLine": 68,
"startChar": 0,
"endLine": 69,
"endChar": 57
},
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_db56ff2a",
"filename": "specs/approved/airship_multi_linux_distros.rst",
"patchSetId": 2
},
"lineNbr": 73,
"author": {
"id": 28618
},
"writtenOn": "2019-03-13T17:51:07Z",
"side": 1,
"message": "Should this be optional? Since the FROM variable can be overridden, a Dockerfile.UBUNTU should theoretically be usable for both Ubuntu Bionic and Ubuntu Xenial.",
"range": {
"startLine": 70,
"startChar": 0,
"endLine": 73,
"endChar": 25
},
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_3b3dc32a",
"filename": "specs/approved/airship_multi_linux_distros.rst",
"patchSetId": 2
},
"lineNbr": 80,
"author": {
"id": 26449
},
"writtenOn": "2019-03-13T17:41:51Z",
"side": 1,
"message": "I think this ended up with using tags because otherwise the overhead of supporting a new distribution base or version is high (create a new quay.io docker registry). So it would be \u0027airshipit/drydock:ubuntu-latest\u0027 or \u0027airshipit/drydock:ubuntu-\u003ccommit\u003e\u0027. I think to maintain that backwards compatibility we can say here that if no distribution base is in the tag, it refers to an Ubuntu based image.",
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_fb709b0a",
"filename": "specs/approved/airship_multi_linux_distros.rst",
"patchSetId": 2
},
"lineNbr": 80,
"author": {
"id": 28628
},
"writtenOn": "2019-03-13T17:43:50Z",
"side": 1,
"message": "I agree, although the general naming scheme that I\u0027ve seen in the majority of other docker repositories is:\n\n\u003cproject version #\u003e-\u003cdistribution flavor\u003e-\u003cdistribution flavor specifics\u003e\n\nSo for our case that would end up being\nairshipit/armada:latest-ubuntu-1604\nor\nairshipit/armada:latest-xenial",
"parentUuid": "5fc1f717_3b3dc32a",
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_ed3c5cc9",
"filename": "specs/approved/airship_multi_linux_distros.rst",
"patchSetId": 2
},
"lineNbr": 80,
"author": {
"id": 1091
},
"writtenOn": "2019-03-13T19:34:42Z",
"side": 1,
"message": "Should tag name refer to branch name instead of latest prefix? latest by itself does not provide any useful information.\n\ni.e. airshipit/armada:master-ubuntu-1604 ?",
"parentUuid": "5fc1f717_fb709b0a",
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_9b15d79e",
"filename": "specs/approved/airship_multi_linux_distros.rst",
"patchSetId": 2
},
"lineNbr": 82,
"author": {
"id": 26449
},
"writtenOn": "2019-03-13T17:41:51Z",
"side": 1,
"message": "See above",
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_cd44004a",
"filename": "specs/approved/airship_multi_linux_distros.rst",
"patchSetId": 2
},
"lineNbr": 84,
"author": {
"id": 1091
},
"writtenOn": "2019-03-13T19:34:42Z",
"side": 1,
"message": "Why we need latest if its already indicating branch information. How master and latest differs or signify here?",
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_23b3550c",
"filename": "specs/approved/airship_multi_linux_distros.rst",
"patchSetId": 2
},
"lineNbr": 84,
"author": {
"id": 28618
},
"writtenOn": "2019-03-13T21:48:05Z",
"side": 1,
"message": "\u003e Why we need latest if its already indicating branch information.\n \u003e How master and latest differs or signify here?\n\nTo my knowledge, they do not differ. However, I\u0027m not sure that\u0027s in scope here.",
"parentUuid": "5fc1f717_cd44004a",
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_1b26c7cf",
"filename": "specs/approved/airship_multi_linux_distros.rst",
"patchSetId": 2
},
"lineNbr": 86,
"author": {
"id": 28618
},
"writtenOn": "2019-03-13T17:51:07Z",
"side": 1,
"message": "The playbooks do require an update to pass the DISTRO variable. This is the same pattern from OSH-images.",
"range": {
"startLine": 86,
"startChar": 2,
"endLine": 86,
"endChar": 14
},
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_0aad0ee8",
"filename": "specs/approved/airship_multi_linux_distros.rst",
"patchSetId": 2
},
"lineNbr": 86,
"author": {
"id": 28208
},
"writtenOn": "2019-03-13T18:35:37Z",
"side": 1,
"message": "Covered by lines 87-88 below.",
"parentUuid": "5fc1f717_1b26c7cf",
"range": {
"startLine": 86,
"startChar": 2,
"endLine": 86,
"endChar": 14
},
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink