airship/specs
Code Issues Proposed changes
83205104e0
specs/1964c3d914bb925aec58b723609e8ac0f60f072d
Gerrit User 7185 435c62924b Update patch set 5 
Patch-set: 5
2019-08-21 07:55:43 +00:00

171 lines
7.0 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "7faddb67_c1a4c5a5",
"filename": "specs/approved/airshictl_bootstrap_image.rst",
"patchSetId": 5
},
"lineNbr": 18,
"author": {
"id": 27046
},
"writtenOn": "2019-08-16T15:18:38Z",
"side": 1,
"message": "Let\u0027s call it isogen mainly because its been the name consistently throughout the design discussions, and not because it really matters,",
"range": {
"startLine": 18,
"startChar": 24,
"endLine": 18,
"endChar": 33
},
"revId": "1964c3d914bb925aec58b723609e8ac0f60f072d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_61b711da",
"filename": "specs/approved/airshictl_bootstrap_image.rst",
"patchSetId": 5
},
"lineNbr": 19,
"author": {
"id": 27046
},
"writtenOn": "2019-08-16T15:18:38Z",
"side": 1,
"message": "typo",
"range": {
"startLine": 19,
"startChar": 43,
"endLine": 19,
"endChar": 50
},
"revId": "1964c3d914bb925aec58b723609e8ac0f60f072d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_c1bda5b1",
"filename": "specs/approved/airshictl_bootstrap_image.rst",
"patchSetId": 5
},
"lineNbr": 40,
"author": {
"id": 27046
},
"writtenOn": "2019-08-16T15:18:38Z",
"side": 1,
"message": "I would add that we expect to bootstrap remotely when possible, without the need for physical access or operator manual intervention.",
"revId": "1964c3d914bb925aec58b723609e8ac0f60f072d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_111e72ba",
"filename": "specs/approved/airshictl_bootstrap_image.rst",
"patchSetId": 5
},
"lineNbr": 40,
"author": {
"id": 7185
},
"writtenOn": "2019-08-21T07:55:43Z",
"side": 1,
"message": "\u003e I would add that we expect to bootstrap remotely when possible,\n \u003e without the need for physical access or operator manual\n \u003e intervention.",
"parentUuid": "7faddb67_c1bda5b1",
"revId": "1964c3d914bb925aec58b723609e8ac0f60f072d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_817d6de8",
"filename": "specs/approved/airshictl_bootstrap_image.rst",
"patchSetId": 5
},
"lineNbr": 59,
"author": {
"id": 27046
},
"writtenOn": "2019-08-16T15:18:38Z",
"side": 1,
"message": "We should escribe that these commands need to be able to :\n- Utilize the airshipctl config to identify the location of YAML documents that describe the intention for the site\n- Identify the YAML files that describe the details required for the HOST for which the iso is been generated. \n- Be able to extract from the appropriate YAML(s) the information for the host, such as IP, Name, MAC, etc.\n- Be able to gather the information from teh YAML and generate the appropriate cloud-config.yaml file .\n This includes the ability to be prescriptive with which information is included in the cloud-config file. \nSpecifically we expect to have the ability to \"know\" how t generate i.e. a redfish URL to this host. , or the appropriate k8s endpoint with teh appropriate credentials (certs) to interact with the cluster in this host once teh iso is deployed.\n\nKeep in mind that some of these expectations above should be functions in the airshipctl document pkg/module that airshipctl boostrap isogen should leverage. In essence, what I am saying here is we need to make sure we have the place holder for those expectations to be fulfilled.",
"revId": "1964c3d914bb925aec58b723609e8ac0f60f072d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_61c63119",
"filename": "specs/approved/airshictl_bootstrap_image.rst",
"patchSetId": 5
},
"lineNbr": 70,
"author": {
"id": 27046
},
"writtenOn": "2019-08-16T15:18:38Z",
"side": 1,
"message": "If there is any other information that needs to be passed to the ISO, besides the cloud-config.yaml, perhaps we need a config file that can be the input passing mechanism. Obviously, this is only needed if we have many arguments . I prefer that than docker run ... isogencontainer \u003claundry list of arguments\u003e",
"revId": "1964c3d914bb925aec58b723609e8ac0f60f072d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_71232606",
"filename": "specs/approved/airshictl_bootstrap_image.rst",
"patchSetId": 5
},
"lineNbr": 70,
"author": {
"id": 7185
},
"writtenOn": "2019-08-21T07:55:43Z",
"side": 1,
"message": "\u003e If there is any other information that needs to be passed to the\n \u003e ISO, besides the cloud-config.yaml, perhaps we need a config file\n \u003e that can be the input passing mechanism. Obviously, this is only\n \u003e needed if we have many arguments . I prefer that than docker run\n \u003e ... isogencontainer \u003claundry list of arguments\u003e",
"parentUuid": "7faddb67_61c63119",
"revId": "1964c3d914bb925aec58b723609e8ac0f60f072d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_21e599a4",
"filename": "specs/approved/airshictl_bootstrap_image.rst",
"patchSetId": 5
},
"lineNbr": 76,
"author": {
"id": 27046
},
"writtenOn": "2019-08-16T15:18:38Z",
"side": 1,
"message": "Do we need some YAML output that updates existing YAML? Or we think that is implicitly known during the input for the generation and therefore there is no need to generate output with data for the next steps...\n\nIf we do clearly the definition of the format of this potential output would need to be part of the interface definition for the iso generating containers.",
"revId": "1964c3d914bb925aec58b723609e8ac0f60f072d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_e18781b5",
"filename": "specs/approved/airshictl_bootstrap_image.rst",
"patchSetId": 5
},
"lineNbr": 96,
"author": {
"id": 27046
},
"writtenOn": "2019-08-16T15:18:38Z",
"side": 1,
"message": "Not sure I understand what this means? \nWhat is the purpose of this.",
"revId": "1964c3d914bb925aec58b723609e8ac0f60f072d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink