airship/specs
Code Issues Proposed changes
960b9b9d71
specs/3ddfde39309c724fa01edb99d3c65b8246bd2dcd
Gerrit User 9542 776bfa6aee Update patch set 3 
Patch Set 3: -Code-Review

(3 comments)

Patch-set: 3
Label: Code-Review=0
2019-02-19 18:53:35 +00:00

280 lines
8.0 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "9fdfeff1_e7684bbb",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 3
},
"lineNbr": 66,
"author": {
"id": 12356
},
"writtenOn": "2019-02-08T17:28:10Z",
"side": 1,
"message": "not really :)",
"range": {
"startLine": 66,
"startChar": 56,
"endLine": 66,
"endChar": 60
},
"revId": "3ddfde39309c724fa01edb99d3c65b8246bd2dcd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_f4fc4473",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 3
},
"lineNbr": 66,
"author": {
"id": 9542
},
"writtenOn": "2019-02-19T18:18:44Z",
"side": 1,
"message": "I\u0027m dead sure there will be names in these YAMLs :-)",
"parentUuid": "9fdfeff1_e7684bbb",
"range": {
"startLine": 66,
"startChar": 56,
"endLine": 66,
"endChar": 60
},
"revId": "3ddfde39309c724fa01edb99d3c65b8246bd2dcd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_6f6a32ee",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 3
},
"lineNbr": 66,
"author": {
"id": 9542
},
"writtenOn": "2019-02-19T18:53:35Z",
"side": 1,
"message": "Done",
"parentUuid": "9fdfeff1_e7684bbb",
"range": {
"startLine": 66,
"startChar": 56,
"endLine": 66,
"endChar": 60
},
"revId": "3ddfde39309c724fa01edb99d3c65b8246bd2dcd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_e7960b95",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 3
},
"lineNbr": 84,
"author": {
"id": 12356
},
"writtenOn": "2019-02-08T17:28:10Z",
"side": 1,
"message": "if this spec describes implementing this for more or less new releases of openstack (i.e. queens) we need to also mention resource classes and the fact the usual resources are completely optional and make sense only to hypervisor-stats calls in nova, which is not present in UCP :)",
"range": {
"startLine": 84,
"startChar": 50,
"endLine": 84,
"endChar": 58
},
"revId": "3ddfde39309c724fa01edb99d3c65b8246bd2dcd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_14e9c8b5",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 3
},
"lineNbr": 84,
"author": {
"id": 9542
},
"writtenOn": "2019-02-19T18:18:44Z",
"side": 1,
"message": "nope, you still need RAM size to check that the image fits into RAM when downloading w/o streaming",
"parentUuid": "9fdfeff1_e7960b95",
"range": {
"startLine": 84,
"startChar": 50,
"endLine": 84,
"endChar": 58
},
"revId": "3ddfde39309c724fa01edb99d3c65b8246bd2dcd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_472a772c",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 3
},
"lineNbr": 101,
"author": {
"id": 12356
},
"writtenOn": "2019-02-08T17:28:10Z",
"side": 1,
"message": "I think you can not do this directly. In case of glance it is determined by looking at the image properties. In case of other types of links it is determined by whether kernel and ramdisk are provided separately in instance_info. Not sure we need such detail here but I don\u0027t think there is a way to just say \u0027this is a whole disk image\u0027/\u0027this is a partition image\u0027 via api",
"range": {
"startLine": 101,
"startChar": 3,
"endLine": 101,
"endChar": 20
},
"revId": "3ddfde39309c724fa01edb99d3c65b8246bd2dcd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_0f29269a",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 3
},
"lineNbr": 101,
"author": {
"id": 9542
},
"writtenOn": "2019-02-19T18:53:35Z",
"side": 1,
"message": "Done",
"parentUuid": "9fdfeff1_472a772c",
"range": {
"startLine": 101,
"startChar": 3,
"endLine": 101,
"endChar": 20
},
"revId": "3ddfde39309c724fa01edb99d3c65b8246bd2dcd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_27cbb3a5",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 3
},
"lineNbr": 103,
"author": {
"id": 12356
},
"writtenOn": "2019-02-08T17:28:10Z",
"side": 1,
"message": "which I suppose should be generated by drydock. would be good to understand which of the methods will be pushing the info there",
"range": {
"startLine": 103,
"startChar": 48,
"endLine": 103,
"endChar": 60
},
"revId": "3ddfde39309c724fa01edb99d3c65b8246bd2dcd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_e7492b32",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 3
},
"lineNbr": 145,
"author": {
"id": 12356
},
"writtenOn": "2019-02-08T17:28:10Z",
"side": 1,
"message": "as stated in previous PS, would be good to understand which of these are noop",
"revId": "3ddfde39309c724fa01edb99d3c65b8246bd2dcd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_07e1cffc",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 3
},
"lineNbr": 295,
"author": {
"id": 12356
},
"writtenOn": "2019-02-08T17:28:10Z",
"side": 1,
"message": "..., as this will allow...",
"range": {
"startLine": 295,
"startChar": 13,
"endLine": 295,
"endChar": 19
},
"revId": "3ddfde39309c724fa01edb99d3c65b8246bd2dcd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_572e7292",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 3
},
"lineNbr": 295,
"author": {
"id": 9542
},
"writtenOn": "2019-02-19T18:18:44Z",
"side": 1,
"message": "yep, will extend",
"parentUuid": "9fdfeff1_07e1cffc",
"range": {
"startLine": 295,
"startChar": 13,
"endLine": 295,
"endChar": 19
},
"revId": "3ddfde39309c724fa01edb99d3c65b8246bd2dcd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_2b33bdf8",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 3
},
"lineNbr": 295,
"author": {
"id": 9542
},
"writtenOn": "2019-02-19T18:53:35Z",
"side": 1,
"message": "Done",
"parentUuid": "9fdfeff1_07e1cffc",
"range": {
"startLine": 295,
"startChar": 13,
"endLine": 295,
"endChar": 19
},
"revId": "3ddfde39309c724fa01edb99d3c65b8246bd2dcd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink