specs/3adb97db3002b9743379fbe2a834acf6b612388e
Gerrit User 7185 b446ac6a4b Update patch set 11
Patch-set: 11
2019-09-04 10:52:12 +00:00

179 lines
5.5 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "7faddb67_0842ee3b",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 113,
"author": {
"id": 24580
},
"writtenOn": "2019-09-03T20:23:39Z",
"side": 1,
"message": "Is this the path to the volume mounted in the container? is that useful for the subcommand?",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_38d2915d",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 113,
"author": {
"id": 7185
},
"writtenOn": "2019-09-04T10:52:12Z",
"side": 1,
"message": "Done. Rephrased description",
"parentUuid": "7faddb67_0842ee3b",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_6851220d",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 118,
"author": {
"id": 24580
},
"writtenOn": "2019-09-03T20:23:39Z",
"side": 1,
"message": "If the iso image and k8s client config is always at the root of the mounted volume, is it still necessary to specify in the output-metadata.yaml?",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_b84a0124",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 118,
"author": {
"id": 7185
},
"writtenOn": "2019-09-04T10:52:12Z",
"side": 1,
"message": "Done. Rephrased. Container may even put an image somewhere outside if external build system is used and container acts like client for this system",
"parentUuid": "7faddb67_6851220d",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_085bce21",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 124,
"author": {
"id": 24580
},
"writtenOn": "2019-09-03T20:23:39Z",
"side": 1,
"message": "wondering if possible to take certificates the user already has?",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_5863cdb1",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 124,
"author": {
"id": 7185
},
"writtenOn": "2019-09-04T10:52:12Z",
"side": 1,
"message": "Done. This is not relevant any more since we discussed that certificates pre-generated and they are the same as for target cluster",
"parentUuid": "7faddb67_085bce21",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_6878427d",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 139,
"author": {
"id": 24580
},
"writtenOn": "2019-09-03T20:23:39Z",
"side": 1,
"message": "Do you mean modify the image in golang lib vs container?",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_7869e989",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 139,
"author": {
"id": 7185
},
"writtenOn": "2019-09-04T10:52:12Z",
"side": 1,
"message": "Done",
"parentUuid": "7faddb67_6878427d",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_c8ecd62a",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 148,
"author": {
"id": 24580
},
"writtenOn": "2019-09-03T20:23:39Z",
"side": 1,
"message": "maybe more specifically refer to the container image built form airship-images? e.g., \"based on Debian container from airship-images/...\"",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_9864e5b4",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 148,
"author": {
"id": 7185
},
"writtenOn": "2019-09-04T10:52:12Z",
"side": 1,
"message": "Done",
"parentUuid": "7faddb67_c8ecd62a",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}