specs/2dfc155f487a7b4eb8245ae8cc0a14d3778f001b
Gerrit User 22604 1d172b3b39 Update patch set 5
Patch Set 5:

(1 comment)

Patch-set: 5
Label: Verified=0
2019-06-28 17:22:47 +00:00

873 lines
22 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "9fb8cfa7_5858ae88",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 38,
"author": {
"id": 29624
},
"writtenOn": "2019-06-27T13:46:10Z",
"side": 1,
"message": "be built",
"range": {
"startLine": 38,
"startChar": 24,
"endLine": 38,
"endChar": 36
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_06e2c2d5",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 38,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_5858ae88",
"range": {
"startLine": 38,
"startChar": 24,
"endLine": 38,
"endChar": 36
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_1856b65d",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 42,
"author": {
"id": 29624
},
"writtenOn": "2019-06-27T13:46:10Z",
"side": 1,
"message": "and",
"range": {
"startLine": 42,
"startChar": 65,
"endLine": 42,
"endChar": 66
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_a6e416e1",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 42,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_1856b65d",
"range": {
"startLine": 42,
"startChar": 65,
"endLine": 42,
"endChar": 66
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_01cdf583",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 50,
"author": {
"id": 22259
},
"writtenOn": "2019-06-26T20:54:44Z",
"side": 1,
"message": "logs?",
"range": {
"startLine": 50,
"startChar": 14,
"endLine": 50,
"endChar": 21
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_a1c5095e",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 50,
"author": {
"id": 22259
},
"writtenOn": "2019-06-26T20:54:44Z",
"side": 1,
"message": "chart name?",
"range": {
"startLine": 50,
"startChar": 36,
"endLine": 50,
"endChar": 41
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_86cd525e",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 50,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_a1c5095e",
"range": {
"startLine": 50,
"startChar": 36,
"endLine": 50,
"endChar": 41
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_66d29e02",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 50,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_01cdf583",
"range": {
"startLine": 50,
"startChar": 14,
"endLine": 50,
"endChar": 21
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_c1c27d53",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 51,
"author": {
"id": 22259
},
"writtenOn": "2019-06-26T20:54:44Z",
"side": 1,
"message": "status?",
"range": {
"startLine": 51,
"startChar": 4,
"endLine": 51,
"endChar": 9
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_26d8261c",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 51,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_c1c27d53",
"range": {
"startLine": 51,
"startChar": 4,
"endLine": 51,
"endChar": 9
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_818fa528",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 56,
"author": {
"id": 22259
},
"writtenOn": "2019-06-26T20:54:44Z",
"side": 1,
"message": "extra space",
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_3dcdac84",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 56,
"author": {
"id": 20466
},
"writtenOn": "2019-06-27T12:40:40Z",
"side": 1,
"message": "duration",
"range": {
"startLine": 56,
"startChar": 25,
"endLine": 56,
"endChar": 32
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_b8cc4a35",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 56,
"author": {
"id": 29624
},
"writtenOn": "2019-06-27T13:46:10Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 56,
"startChar": 62,
"endLine": 56,
"endChar": 63
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_a6fdf66e",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 56,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_b8cc4a35",
"range": {
"startLine": 56,
"startChar": 62,
"endLine": 56,
"endChar": 63
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_060ba28d",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 56,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_3dcdac84",
"range": {
"startLine": 56,
"startChar": 25,
"endLine": 56,
"endChar": 32
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_46d3da01",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 56,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_818fa528",
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_18db16ed",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 81,
"author": {
"id": 29624
},
"writtenOn": "2019-06-27T13:46:10Z",
"side": 1,
"message": "# Test",
"range": {
"startLine": 81,
"startChar": 8,
"endLine": 81,
"endChar": 13
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_c6002a69",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 81,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_18db16ed",
"range": {
"startLine": 81,
"startChar": 8,
"endLine": 81,
"endChar": 13
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_f8dde2dc",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 95,
"author": {
"id": 29624
},
"writtenOn": "2019-06-27T13:46:10Z",
"side": 1,
"message": "similar to",
"range": {
"startLine": 95,
"startChar": 25,
"endLine": 95,
"endChar": 44
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_58e66eb2",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 95,
"author": {
"id": 29624
},
"writtenOn": "2019-06-27T13:46:10Z",
"side": 1,
"message": "would not",
"range": {
"startLine": 95,
"startChar": 68,
"endLine": 95,
"endChar": 75
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_66fb7e78",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 95,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_58e66eb2",
"range": {
"startLine": 95,
"startChar": 68,
"endLine": 95,
"endChar": 75
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_86f6b28e",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 95,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_f8dde2dc",
"range": {
"startLine": 95,
"startChar": 25,
"endLine": 95,
"endChar": 44
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_c18b5dbd",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 104,
"author": {
"id": 22259
},
"writtenOn": "2019-06-26T20:54:44Z",
"side": 1,
"message": "I thought the main idea of the spec was to expose an endpoint within armada which could be scraped by prometheus and thus monitoring of these chart deployment etc. could be included in the LMA framework.\n\nI am not clear if we are achieving the same with the proposed solution or how would prometheus be able to scrape the time metrics with the proposed solution? can it be clarified?",
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_466f5a27",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 104,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:22:47Z",
"side": 1,
"message": "Let me double check the details for the spec request. Marking as -1 WF until clarified.",
"parentUuid": "9fb8cfa7_c18b5dbd",
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_b89a0a11",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 106,
"author": {
"id": 29624
},
"writtenOn": "2019-06-27T13:46:10Z",
"side": 1,
"message": "used",
"range": {
"startLine": 106,
"startChar": 41,
"endLine": 106,
"endChar": 44
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_26f10696",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 106,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_b89a0a11",
"range": {
"startLine": 106,
"startChar": 41,
"endLine": 106,
"endChar": 44
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_78a01243",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 109,
"author": {
"id": 29624
},
"writtenOn": "2019-06-27T13:46:10Z",
"side": 1,
"message": "converted to a normal",
"range": {
"startLine": 109,
"startChar": 13,
"endLine": 109,
"endChar": 29
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_a632d65c",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 109,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_78a01243",
"range": {
"startLine": 109,
"startChar": 13,
"endLine": 109,
"endChar": 29
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_1889d6c8",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 110,
"author": {
"id": 29624
},
"writtenOn": "2019-06-27T13:46:10Z",
"side": 1,
"message": "an",
"range": {
"startLine": 110,
"startChar": 0,
"endLine": 110,
"endChar": 1
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_c6358a46",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 110,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_1889d6c8",
"range": {
"startLine": 110,
"startChar": 0,
"endLine": 110,
"endChar": 1
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_d88edecf",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 114,
"author": {
"id": 29624
},
"writtenOn": "2019-06-27T13:46:10Z",
"side": 1,
"message": "Unfortunately",
"range": {
"startLine": 114,
"startChar": 0,
"endLine": 114,
"endChar": 12
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_66405ea6",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 114,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_d88edecf",
"range": {
"startLine": 114,
"startChar": 0,
"endLine": 114,
"endChar": 12
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_9dbcd8dc",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 116,
"author": {
"id": 20466
},
"writtenOn": "2019-06-27T12:40:40Z",
"side": 1,
"message": "nit: `` backtick",
"range": {
"startLine": 116,
"startChar": 0,
"endLine": 116,
"endChar": 30
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_863b1236",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 116,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_9dbcd8dc",
"range": {
"startLine": 116,
"startChar": 0,
"endLine": 116,
"endChar": 30
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_78b9f276",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 117,
"author": {
"id": 29624
},
"writtenOn": "2019-06-27T13:46:10Z",
"side": 1,
"message": "providing",
"range": {
"startLine": 117,
"startChar": 0,
"endLine": 117,
"endChar": 7
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_46419aa5",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 117,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_78b9f276",
"range": {
"startLine": 117,
"startChar": 0,
"endLine": 117,
"endChar": 7
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_1dd0e81e",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 162,
"author": {
"id": 20466
},
"writtenOn": "2019-06-27T12:40:40Z",
"side": 1,
"message": "remove?",
"range": {
"startLine": 162,
"startChar": 0,
"endLine": 162,
"endChar": 4
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_e6152e9d",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 162,
"author": {
"id": 22604
},
"writtenOn": "2019-06-28T17:21:17Z",
"side": 1,
"message": "Done",
"parentUuid": "9fb8cfa7_1dd0e81e",
"range": {
"startLine": 162,
"startChar": 0,
"endLine": 162,
"endChar": 4
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}