111 lines
3.9 KiB
Plaintext
111 lines
3.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_ff72214b",
|
|
"filename": "specs/update_labels_workflow.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 18180
|
|
},
|
|
"writtenOn": "2018-07-25T15:39:59Z",
|
|
"side": 1,
|
|
"message": "Personal opinion, this file isn\u0027t named specifically enough to be able to pick it out among a sea of other specs in the same repo. Should we consider naming conventions?",
|
|
"revId": "8c449495ba6a241c6dae501a90295455afe7fa77",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_9fa68dac",
|
|
"filename": "specs/update_labels_workflow.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 18180
|
|
},
|
|
"writtenOn": "2018-07-25T15:40:18Z",
|
|
"side": 1,
|
|
"message": "Does this file belong in /specs or in /specs/approved ?",
|
|
"parentUuid": "5f7c97a3_ff72214b",
|
|
"revId": "8c449495ba6a241c6dae501a90295455afe7fa77",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_3a06671d",
|
|
"filename": "specs/update_labels_workflow.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 26365
|
|
},
|
|
"writtenOn": "2018-07-25T15:53:57Z",
|
|
"side": 1,
|
|
"message": "do you have any suggestions on a naming convention? I thought maybe the impacted component, if there is only one... but this one impacts 3. Dates don\u0027t really help, There\u0027s not a specific feature roadmap that we\u0027re aligned with to be able to point to a target known name for things... (maybe that\u0027s something we should have???).",
|
|
"parentUuid": "5f7c97a3_ff72214b",
|
|
"revId": "8c449495ba6a241c6dae501a90295455afe7fa77",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_ba111753",
|
|
"filename": "specs/update_labels_workflow.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 26365
|
|
},
|
|
"writtenOn": "2018-07-25T15:53:57Z",
|
|
"side": 1,
|
|
"message": "until it\u0027s approved, it would stay here.",
|
|
"parentUuid": "5f7c97a3_9fa68dac",
|
|
"revId": "8c449495ba6a241c6dae501a90295455afe7fa77",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_1ad7eb24",
|
|
"filename": "specs/update_labels_workflow.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 18180
|
|
},
|
|
"writtenOn": "2018-07-25T16:06:52Z",
|
|
"side": 1,
|
|
"message": "So approved as in you got your +2s and merged? Then once it\u0027s \"approved\" we have to immediately move it to the approved dir, requiring more +2s and merging?\nOr does \"approved\" mean something different?",
|
|
"parentUuid": "5f7c97a3_ba111753",
|
|
"revId": "8c449495ba6a241c6dae501a90295455afe7fa77",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_fa16aff3",
|
|
"filename": "specs/update_labels_workflow.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 18180
|
|
},
|
|
"writtenOn": "2018-07-25T16:06:52Z",
|
|
"side": 1,
|
|
"message": "I would think having the impacted component would be part of it, where \"airship\" is a valid target. Or maybe the filename could just mention kubernetes to be more specific? \u0027airship_kubernetes_labels\u0027 or something?",
|
|
"parentUuid": "5f7c97a3_3a06671d",
|
|
"revId": "8c449495ba6a241c6dae501a90295455afe7fa77",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |