airship
/
treasuremap
Code Issues Proposed changes

Update patch set 11 

Patch Set 11:

(4 comments)

Thanks Roman, see answers.

Patch-set: 11
Label: Verified=0
This commit is contained in:
Gerrit User 26628 2018-09-20 23:13:40 +00:00 committed by Gerrit Code Review
parent 3bc3fdcf60
commit 2b933b0ad9
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
498985f6de043e6b8ec83953acc1f957bcd28dc3
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_b7643b4a",
"filename": "tools/gate/Jenkinsfile",
"patchSetId": 11
},
"lineNbr": 426,
"author": {
"id": 26628
},
"writtenOn": "2018-09-20T23:13:40Z",
"side": 1,
"message": "It\u0027s a clean VM each time.. comes up with no key, should be good.",
"parentUuid": "3f79a3b5_f76dd366",
"revId": "498985f6de043e6b8ec83953acc1f957bcd28dc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_f794f342",
@ -34,6 +52,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_1755ef4f",
"filename": "tools/gate/Jenkinsfile",
"patchSetId": 11
},
"lineNbr": 431,
"author": {
"id": 26628
},
"writtenOn": "2018-09-20T23:13:40Z",
"side": 1,
"message": "Done (inside repo folder though)",
"parentUuid": "3f79a3b5_f794f342",
"revId": "498985f6de043e6b8ec83953acc1f957bcd28dc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_17940f43",
@ -51,6 +87,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_37502b5e",
"filename": "tools/gate/Jenkinsfile",
"patchSetId": 11
},
"lineNbr": 439,
"author": {
"id": 26628
},
"writtenOn": "2018-09-20T23:13:40Z",
"side": 1,
"message": "Done",
"parentUuid": "3f79a3b5_17940f43",
"revId": "498985f6de043e6b8ec83953acc1f957bcd28dc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_77822301",
@ -67,6 +121,24 @@
"revId": "498985f6de043e6b8ec83953acc1f957bcd28dc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_77e8e379",
"filename": "tools/gate/Jenkinsfile",
"patchSetId": 11
},
"lineNbr": 485,
"author": {
"id": 26628
},
"writtenOn": "2018-09-20T23:13:40Z",
"side": 1,
"message": "Yeah - for now - I think we just want it to be up to humans to +2 and merge at a controlled time.\n\nI\u0027m thinking that we would only merge in 2 week intervals.. It might be hard for people to get updates every day.",
"parentUuid": "3f79a3b5_77822301",
"revId": "498985f6de043e6b8ec83953acc1f957bcd28dc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}