Fix up validation errors from LMA functions

I'm splitting these changes from [0] for clarity.

This change fixes various indentation errors/ key placements in LMA
functions.

Also fixes a validation error in the test-site's workload
replacements

[0] https://review.opendev.org/c/airship/treasuremap/+/793106

Change-Id: I9f252cf067e30de6e961edaa412ab87a902918de

manifests/function/elasticsearch/helmrelease.yaml

@@ -10,7 +10,6 @@ spec:
       sourceRef:
         kind: HelmRepository
         name: elasticsearch
-    interval: 1m
+      interval: 1m
-  wait: false
   timeout: 5m
   values: {}

manifests/function/grafana/helmrelease.yaml

@@ -7,12 +7,10 @@ spec:
   interval: 5m
   chart:
     spec:
-      chart: grafana
       sourceRef:
         kind: HelmRepository
         name: grafana
-    version: 6.1.0
+      interval: 1m
-    interval: 1m
   timeout: 5m
   # Reference values at
   # https://github.com/grafana/helm-charts/blob/main/charts/grafana/values.yaml

manifests/function/kibana/helmrelease.yaml

@@ -10,7 +10,6 @@ spec:
       sourceRef:
         kind: HelmRepository
         name: kibana
-    interval: 1m
+      interval: 1m
-  wait: false
   timeout: 5m
   values: {}

manifests/function/kibana/replacements/versions.yaml

@@ -36,7 +36,7 @@ replacements:
     objref:
       kind: HelmRelease
       name: kibana
-    fieldrefs: ["{.spec.chart.version}"]
+    fieldrefs: ["{.spec.chart.spec.version}"]
 - source:
     objref:
       kind: VersionsCatalogue

manifests/function/kube-prometheus-stack/helmrelease.yaml

@@ -10,7 +10,7 @@ spec:
       sourceRef:
         kind: HelmRepository
         name: prometheus-community
-    interval: 1m
+      interval: 1m
   timeout: 5m
   # Reference values at
   # https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/values.yaml

manifests/function/logging-operator/helmrelease-logging.yaml

@@ -10,7 +10,7 @@ spec:
       sourceRef:
         kind: HelmRepository
         name: banzaicloud
-    interval: 1m
+      interval: 1m
   timeout: 5m
   # Reference values at
   # https://github.com/banzaicloud/logging-operator/blob/master/charts/logging-operator-logging/values.yaml

manifests/function/logging-operator/helmrelease-operator.yaml

@@ -10,7 +10,7 @@ spec:
       sourceRef:
         kind: HelmRepository
         name: banzaicloud
-    interval: 1m
+      interval: 1m
   timeout: 5m
   # Reference values at
   # https://github.com/banzaicloud/logging-operator/blob/master/charts/logging-operator/values.yaml

manifests/function/minio/helmrelease.yaml

@@ -10,8 +10,7 @@ spec:
       sourceRef:
         kind: HelmRepository
         name: minio
-    interval: 1m
+      interval: 1m
-  wait: false
   timeout: 5m
   # Reference values at
   # https://github.com/minio/charts/blob/master/minio/values.yaml

manifests/function/prometheus-elasticsearch-exporter/helmrelease.yaml

@@ -10,7 +10,7 @@ spec:
       sourceRef:
         kind: HelmRepository
         name: prometheus-elasticsearch-exporter
-    interval: 1m
+      interval: 1m
   timeout: 5m
   # Reference values at
   # https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus-elasticsearch-exporter/values.yaml

manifests/function/thanos-operator/helmrelease.yaml

@@ -10,8 +10,7 @@ spec:
       sourceRef:
         kind: HelmRepository
         name: thanos
-    interval: 1m
+      interval: 1m
-  wait: false
   timeout: 5m
   # Reference values at
   # https://github.com/banzaicloud/thanos-operator/blob/master/charts/thanos-operator/values.yaml

manifests/site/test-site/target/workload/kustomization.yaml

@@ -2,5 +2,5 @@ resources:
   - ../../../../type/airship-core/target/workload
   - ../catalogues
 transformers:
-  - ../../../../function/ingress/replacements
   - ./replacements
+  - ../../../../type/airship-core/target/workload/replacements