Update patch set 27

Patch Set 27:

> Patch Set 27: Code-Review+2
> 
> This is great! LGTM. Only consideration I have is that we may want to provide a default value for that load balancer, or a future maintainer may think that is there by mistake when they only see have of the nodePort definition within the Deloyment.

On the other hand, I also like that Kubernetes would reject that Deployment if the substitution failed for whatever reason. Maybe a comment is how we can get the best of both worlds

Patch-set: 27
Reviewer: Gerrit User 28618 <28618@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 28618 2021-06-14 19:50:40 +00:00 committed by Gerrit Code Review
parent 44f787aa9f
commit 723c23abc4

Diff Content Not Available