From 2c55c0466d6ea7fee3c5be55259bf81c0e209c54 Mon Sep 17 00:00:00 2001 From: Gerrit User 28618 <28618@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 23 Nov 2018 18:17:06 +0000 Subject: [PATCH] Update patch set 1 Patch Set 1: Code-Review-1 (2 comments) I will give this patch a test. A few nits in the meantime: Patch-set: 1 Reviewer: Gerrit User 28618 <28618@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1 --- 7ef061f60f2ddb06d94eaf741f9526e4cdae31a9 | 44 ++++++++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 7ef061f60f2ddb06d94eaf741f9526e4cdae31a9 diff --git a/7ef061f60f2ddb06d94eaf741f9526e4cdae31a9 b/7ef061f60f2ddb06d94eaf741f9526e4cdae31a9 new file mode 100644 index 0000000..7bda7ee --- /dev/null +++ b/7ef061f60f2ddb06d94eaf741f9526e4cdae31a9 @@ -0,0 +1,44 @@ +{ + "comments": [ + { + "key": { + "uuid": "3f79a3b5_a36c3d6c", + "filename": "/COMMIT_MSG", + "patchSetId": 1 + }, + "lineNbr": 11, + "author": { + "id": 28618 + }, + "writtenOn": "2018-11-23T18:17:06Z", + "side": 1, + "message": "We should not have any AT\u0026T specific URLs in upstream repositories.\n\nPlease swap them with generic replacements if you intend to provide an example.", + "range": { + "startLine": 10, + "startChar": 0, + "endLine": 11, + "endChar": 67 + }, + "revId": "7ef061f60f2ddb06d94eaf741f9526e4cdae31a9", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "3f79a3b5_238eed24", + "filename": "/COMMIT_MSG", + "patchSetId": 1 + }, + "lineNbr": 13, + "author": { + "id": 28618 + }, + "writtenOn": "2018-11-23T18:17:06Z", + "side": 1, + "message": "Why does this change depend on a change to the README file? It seems as though it could be submitted independently.\n\nAdditionally, if this change depends on other changes, it should have a\n\n Depends-On tag.", + "revId": "7ef061f60f2ddb06d94eaf741f9526e4cdae31a9", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file