airship/utils
Code Issues Proposed changes

Update patch set 5

Browse Source 
Patch Set 5: Code-Review-1

(1 comment)

Patch-set: 5
Reviewer: Gerrit User 22477 <22477@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 22477 2018-12-05 19:08:32 +00:00 committed by Gerrit Code Review
parent 6ced26996c
commit ca1a082f36
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
b1b4575eff95c1ad64d2ae1c2b23b5973410a953 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "3f79a3b5_da7dba1d",
"filename": "mini-mirror/assets/startup.sh",
"patchSetId": 5
},
"lineNbr": 49,
"author": {
"id": 22477
},
"writtenOn": "2018-12-05T19:08:32Z",
"side": 1,
"message": "Wouln\u0027t it be more consistent and desirable to bind mount the key in (as above) rather than pulling from a URL at runtime every time nginx starts up? And for enterprise purposes, couldn\u0027t the key be simply be mounted as the ubuntu-archive-keyring.gpg above, so that no code change is needed?",
"revId": "b1b4575eff95c1ad64d2ae1c2b23b5973410a953",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}