jjb/jenkins-job-builder
Code Issues Proposed changes

Use JJBConfig in ModuleRegistry.

Browse Source 
Remove reference to ConfigParser object in ModuleRegistry. Instead:
* make use of JJBConfig.get_module_config to grab settings for Hipchat
  Notifier Plugin
* make use of JJBConfig.yamlparser['allow_empty_variables'] rather
  than repeating ConfigParser logic moved out of the YamlParser into
  JJBConfig in an earlier commit.

Change-Id: Icb7ef514826005545e48af993335ce120f973b0d
This commit is contained in:
Wayne Warren
2015-12-28 22:39:32 -08:00
committed by Darragh Bailey
parent 4f04de1f9a
commit 0da11b51c5
4 changed files with 11 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/moduleregistry/test_moduleregistry.py
View File

@@ -34,7 +34,6 @@ class ModuleRegistryPluginInfoTestsWithScenarios(TestWithScenarios,
jjb_config = JJBConfig()
jjb_config.validate()
config = jjb_config.config_parser
plugin_info = [{'shortName': "HerpDerpPlugin",
'longName': "Blah Blah Blah Plugin"
@@ -45,7 +44,7 @@ class ModuleRegistryPluginInfoTestsWithScenarios(TestWithScenarios,
})
self.addDetail("plugin_info", text_content(str(plugin_info)))
self.registry = ModuleRegistry(config, plugin_info)
self.registry = ModuleRegistry(jjb_config, plugin_info)
def tearDown(self):
super(ModuleRegistryPluginInfoTestsWithScenarios, self).tearDown()