jjb
/
jenkins-job-builder
Code Issues Proposed changes

Update jenkins_manager/test_manager test 

After JJB internals are changed, some of the tests became unuseful.

Change-Id: Ib5583d77bd2c4fc5ef31d5062029f047e8e94fd4
This commit is contained in:
Vsevolod Fedorov 2022-07-11 12:36:37 +03:00
parent f4d64f9f66
commit 28d00a0e28
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/jenkins_manager/test_manager.py
View File

@ -45,17 +45,13 @@ def test_plugins_list_from_jenkins(mocker, jjb_config):
jenkins_jobs.builder.jenkins.Jenkins, "get_plugins", return_value=_plugins_info jenkins_jobs.builder.jenkins.Jenkins, "get_plugins", return_value=_plugins_info
) )
# Trigger fetching the plugins from jenkins when accessing the property # Trigger fetching the plugins from jenkins when accessing the property
jjb_config.builder["plugins_info"] = {} jjb_config.builder["plugins_info"] = None
builder = jenkins_jobs.builder.JenkinsManager(jjb_config) builder = jenkins_jobs.builder.JenkinsManager(jjb_config)
# See https://github.com/formiaczek/multi_key_dict/issues/17 assert list(builder.plugins_list) == list(_plugins_info.values())
# self.assertEqual(self.builder.plugins_list, k)
for key_tuple in builder.plugins_list.keys():
for key in key_tuple:
assert builder.plugins_list[key] == _plugins_info[key]
def test_delete_managed(mocker, jjb_config): def test_delete_managed(mocker, jjb_config):
jjb_config.builder["plugins_info"] = {} jjb_config.builder["plugins_info"] = None
builder = jenkins_jobs.builder.JenkinsManager(jjb_config) builder = jenkins_jobs.builder.JenkinsManager(jjb_config)
patches = mocker.patch.multiple( patches = mocker.patch.multiple(