jjb
/
jenkins-job-builder
Code Issues Proposed changes

Update maven_target to use convert_mapping_to_xml() 

Change-Id: I7defcb0f9ece4c2e11fef1a70653981851a2b45b
This commit is contained in:
Yolande Amate 2017-07-04 23:23:00 +01:00
parent e3e5a8aabe
commit 416bd2449f
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
jenkins_jobs/modules/builders.py
View File

@ -1778,12 +1778,12 @@ def maven_target(registry, xml_parent, data):
XML.SubElement(maven, 'targets').text = data['goals']
prop_string = '\n'.join(data.get('properties', []))
XML.SubElement(maven, 'properties').text = prop_string
if 'maven-version' in data:
XML.SubElement(maven, 'mavenName').text = str(data['maven-version'])
if 'pom' in data:
XML.SubElement(maven, 'pom').text = str(data['pom'])
use_private = str(data.get('private-repository', False)).lower()
XML.SubElement(maven, 'usePrivateRepository').text = use_private
mapping = [
('maven-version', 'mavenName', None),
('pom', 'pom', None),
('private-repository', 'usePrivateRepository', False)]
convert_mapping_to_xml(maven, data, mapping, fail_required=False)
if 'java-opts' in data:
javaoptions = ' '.join(data.get('java-opts', []))
XML.SubElement(maven, 'jvmOptions').text = javaoptions