jjb/jenkins-job-builder
Code Issues Proposed changes

Deprecate running testjobs without config-xml flag

Browse Source 
Creation of nested folders is not possible in
`project-type: folder` in test mode because the
folder name conflicts with the generated XML
filename and an `OSError` is thrown as a result.
This can be resolved by passing the `--config-xml`
flag when running the jobs in test mode. This
commit displays a deprecation message asking the
user to use the `--config-xml` flag.

Change-Id: I6f883040ed3d9b3536ccc2fb305cdddcfde5d765
Story: #2001937
Task: #15050
This commit is contained in:
Alphadose 2018-05-10 09:38:42 +05:30 committed by Darragh Bailey
parent 7696ea37fd
commit 43eb89fc54
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
jenkins_jobs/builder.py
View File

@ -78,6 +78,14 @@ class JenkinsManager(object):
output_dir = os.path.join( output_dir = os.path.join(
output_dir, os.path.basename(item)) output_dir, os.path.basename(item))
output_fn = os.path.join(output_dir, 'config.xml') output_fn = os.path.join(output_dir, 'config.xml')
else:
logger.warn('(Deprecated) The default output behavior of'
' `jenkins-jobs test` when given the --output'
' flag will change in JJB 3.0.'
' Instead of writing jobs to OUTPUT/jobname;'
' they will be written to OUTPUT/jobname/config.xml.'
' The new behavior can be enabled by the passing'
' `--config-xml` parameter.')
if output_dir != output: if output_dir != output:
logger.debug("Creating directory %s" % output_dir) logger.debug("Creating directory %s" % output_dir)