jjb/jenkins-job-builder
Code Issues Proposed changes

Update release to make use of convert_mapping_to_xml()

Browse Source 
Change-Id: I6dd64fe0ca084af283ba980b2a110a5fa920e825
Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
This commit is contained in:
Yolande Amate 2017-07-03 20:53:15 +01:00 committed by Sorin Sbarnea
parent d617fc535a
commit 5a4c87e061
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
jenkins_jobs/modules/wrappers.py
View File

@ -1195,20 +1195,19 @@ def release(registry, xml_parent, data):
'hudson.plugins.release.ReleaseWrapper')
# For 'keep-forever', the sense of the XML flag is the opposite of
# the YAML flag.
no_keep_forever = 'false'
if str(data.get('keep-forever', True)).lower() == 'false':
no_keep_forever = 'true'
XML.SubElement(relwrap, 'doNotKeepLog').text = no_keep_forever
XML.SubElement(relwrap, 'overrideBuildParameters').text = str(
data.get('override-build-parameters', False)).lower()
XML.SubElement(relwrap, 'releaseVersionTemplate').text = data.get(
'version-template', '')
mapping = [
('do-not-keep-log',
'doNotKeepLog',
not data.get('keep-forever', True)),
('override-build-parameters', 'overrideBuildParameters', False),
('version-template', 'releaseVersionTemplate', '')]
convert_mapping_to_xml(relwrap, data, mapping, fail_required=True)
parameters = data.get('parameters', [])
if parameters:
pdef = XML.SubElement(relwrap, 'parameterDefinitions')
for param in parameters:
registry.dispatch('parameter', pdef, param)
builder_steps = {
'pre-build': 'preBuildSteps',
'post-build': 'postBuildSteps',