Use a more consistent style for booleans values.
For an optional boolean option, a common idiom was to write:
data.get('option-name', 'false')
Using a keyword False instead of the string 'false' (resp. True
instead of 'true') is deemed clearer, since it conveys that the
option is a flag.
Such calls are modified to using False/True. The change has been
creating using `git grep '.\(false\|true\).)'` to find what needed
to change.
Change-Id: I54087b5487c7186fcc4ee70ea9b28c1a1002a547
This commit is contained in:
@@ -97,7 +97,7 @@ class HipChat(jenkins_jobs.modules.base.Base):
|
||||
'HipChatNotifier_-HipChatJobProperty')
|
||||
XML.SubElement(pdefhip, 'room').text = hipchat['room']
|
||||
XML.SubElement(pdefhip, 'startNotification').text = str(
|
||||
hipchat.get('start-notify', 'false')).lower()
|
||||
hipchat.get('start-notify', False)).lower()
|
||||
|
||||
publishers = xml_parent.find('publishers')
|
||||
if publishers is None:
|
||||
|
||||
Reference in New Issue
Block a user