Update patch set 1
Patch Set 1: I would prefer that you didn't merge this (1 inline comment) Overall looks good. One inline comment for a doc fix and it would be great if you could have a blank line between your comment message and the Commit-Id at the end. I think git-review *should* handle this for you. Patch-set: 1 Label: Code-Review=-1 Label: Workflow=0
This commit is contained in:
parent
922bd8febe
commit
6b2b52a066
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAALn//7VU\u003d",
|
||||
"filename": "jenkins_jobs/modules/parameters.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 182,
|
||||
"author": {
|
||||
"id": 4146
|
||||
},
|
||||
"writtenOn": "2012-10-26T17:41:40Z",
|
||||
"side": 1,
|
||||
"message": "The format for rst links is `Text \u003clink\u003e`_. Need to use backticks.",
|
||||
"revId": "270ecb04961339e7680d9f570908cb89659f5404",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue