jjb
/
jenkins-job-builder
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: I would prefer that you didn't merge this

(1 inline comment)

See inline comment (would like one small documentation change).

Patch-set: 1
Label: Code-Review=-1
Label: Workflow=0
This commit is contained in:
Gerrit User 4146 2012-10-09 23:26:02 +00:00 committed by Gerrit Code Review
parent 49a1abaacc
commit 7495b9f81a
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
e661a7fb0d94ae83c9a6945c44433f88e1c1a66b Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "AAAALH//LwE\u003d",
"filename": "jenkins_jobs/modules/builders.py",
"patchSetId": 1
},
"lineNbr": 61,
"author": {
"id": 4146
},
"writtenOn": "2012-10-08T16:47:44Z",
"side": 1,
"message": "I believe this functionality requires the Jenkins Ant plugin https://wiki.jenkins-ci.org/display/JENKINS/Ant+Plugin. Can you document this requirement like the Parameterized Trigger Plugin requirement is documented below (on lines 97-99).",
"revId": "e661a7fb0d94ae83c9a6945c44433f88e1c1a66b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}