From 9746bddc482e432a52b71813caaa8a7a2868570a Mon Sep 17 00:00:00 2001
From: Kien Ha <kienha9922@gmail.com>
Date: Fri, 22 Jul 2016 12:37:29 -0400
Subject: [PATCH] Update xvnc to use convert xml

- Update doc to use 4 space indent syntax
- Update test file to be more descriptive
- Add minimal test
- Add plugin="xvnc" attribute

Change-Id: I6b669d3b18fd6efadcbaf1b801242a46d9c2db21
Signed-off-by: Kien Ha <kienha9922@gmail.com>
---
 jenkins_jobs/modules/wrappers.py              | 27 ++++++++++++-------
 .../fixtures/{xvnc001.xml => xvnc-full.xml}   |  2 +-
 .../fixtures/{xvnc001.yaml => xvnc-full.yaml} |  0
 tests/wrappers/fixtures/xvnc-minimal.xml      |  9 +++++++
 tests/wrappers/fixtures/xvnc-minimal.yaml     |  2 ++
 5 files changed, 29 insertions(+), 11 deletions(-)
 rename tests/wrappers/fixtures/{xvnc001.xml => xvnc-full.xml} (82%)
 rename tests/wrappers/fixtures/{xvnc001.yaml => xvnc-full.yaml} (100%)
 create mode 100644 tests/wrappers/fixtures/xvnc-minimal.xml
 create mode 100644 tests/wrappers/fixtures/xvnc-minimal.yaml

diff --git a/jenkins_jobs/modules/wrappers.py b/jenkins_jobs/modules/wrappers.py
index 53e475053..3e5e5999b 100644
--- a/jenkins_jobs/modules/wrappers.py
+++ b/jenkins_jobs/modules/wrappers.py
@@ -1819,22 +1819,29 @@ def xvnc(parser, xml_parent, data):
     Enable xvnc during the build.
     Requires the Jenkins :jenkins-wiki:`xvnc plugin <Xvnc+Plugin>`.
 
-    :arg bool screenshot: Take screenshot upon build completion
-                          (default false)
-    :arg bool xauthority: Create a dedicated Xauthority file per build
-                          (default true)
+    :arg bool screenshot: Take screenshot upon build completion (default false)
+    :arg bool xauthority: Create a dedicated Xauthority file per build (default
+        true)
 
-    Example:
+    Full Example:
 
-    .. literalinclude:: /../../tests/wrappers/fixtures/xvnc001.yaml
+    .. literalinclude:: /../../tests/wrappers/fixtures/xvnc-full.yaml
+       :language: yaml
 
+    Minimal Example:
+
+    .. literalinclude:: /../../tests/wrappers/fixtures/xvnc-minimal.yaml
+       :language: yaml
     """
     xwrapper = XML.SubElement(xml_parent,
                               'hudson.plugins.xvnc.Xvnc')
-    XML.SubElement(xwrapper, 'takeScreenshot').text = str(
-        data.get('screenshot', False)).lower()
-    XML.SubElement(xwrapper, 'useXauthority').text = str(
-        data.get('xauthority', True)).lower()
+    xwrapper.set('plugin', 'xvnc')
+
+    mapping = [
+        ('screenshot', 'takeScreenshot', False),
+        ('xauthority', 'useXauthority', True),
+    ]
+    convert_mapping_to_xml(xwrapper, data, mapping, fail_required=True)
 
 
 def job_log_logger(parser, xml_parent, data):
diff --git a/tests/wrappers/fixtures/xvnc001.xml b/tests/wrappers/fixtures/xvnc-full.xml
similarity index 82%
rename from tests/wrappers/fixtures/xvnc001.xml
rename to tests/wrappers/fixtures/xvnc-full.xml
index 42095a035..82bb61f41 100644
--- a/tests/wrappers/fixtures/xvnc001.xml
+++ b/tests/wrappers/fixtures/xvnc-full.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <project>
   <buildWrappers>
-    <hudson.plugins.xvnc.Xvnc>
+    <hudson.plugins.xvnc.Xvnc plugin="xvnc">
       <takeScreenshot>true</takeScreenshot>
       <useXauthority>false</useXauthority>
     </hudson.plugins.xvnc.Xvnc>
diff --git a/tests/wrappers/fixtures/xvnc001.yaml b/tests/wrappers/fixtures/xvnc-full.yaml
similarity index 100%
rename from tests/wrappers/fixtures/xvnc001.yaml
rename to tests/wrappers/fixtures/xvnc-full.yaml
diff --git a/tests/wrappers/fixtures/xvnc-minimal.xml b/tests/wrappers/fixtures/xvnc-minimal.xml
new file mode 100644
index 000000000..5c8d89e07
--- /dev/null
+++ b/tests/wrappers/fixtures/xvnc-minimal.xml
@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8"?>
+<project>
+  <buildWrappers>
+    <hudson.plugins.xvnc.Xvnc plugin="xvnc">
+      <takeScreenshot>false</takeScreenshot>
+      <useXauthority>true</useXauthority>
+    </hudson.plugins.xvnc.Xvnc>
+  </buildWrappers>
+</project>
diff --git a/tests/wrappers/fixtures/xvnc-minimal.yaml b/tests/wrappers/fixtures/xvnc-minimal.yaml
new file mode 100644
index 000000000..7fc304bfe
--- /dev/null
+++ b/tests/wrappers/fixtures/xvnc-minimal.yaml
@@ -0,0 +1,2 @@
+wrappers:
+  - xvnc