From 9e595369ecaa05ed52304beb6bd222d285b8d636 Mon Sep 17 00:00:00 2001 From: Gerrit User 1 <1@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Wed, 12 Sep 2012 17:18:26 +0000 Subject: [PATCH] Update patch set 1 Patch Set 1: I would prefer that you didn't merge this (5 inline comments) I love this, but just have a couple suggestions about the log levels for some of the messages. Patch-set: 1 Label: Verified=0 Label: Code-Review=-1 Label: Workflow=0 --- 43ef14a241c4db5bdac71575dfe3fb2c46d3055e | 89 ++++++++++++++++++++++++ 1 file changed, 89 insertions(+) create mode 100644 43ef14a241c4db5bdac71575dfe3fb2c46d3055e diff --git a/43ef14a241c4db5bdac71575dfe3fb2c46d3055e b/43ef14a241c4db5bdac71575dfe3fb2c46d3055e new file mode 100644 index 000000000..ec595ed2f --- /dev/null +++ b/43ef14a241c4db5bdac71575dfe3fb2c46d3055e @@ -0,0 +1,89 @@ +{ + "comments": [ + { + "key": { + "uuid": "AAAALH//b4k\u003d", + "filename": "jenkins-jobs", + "patchSetId": 1 + }, + "lineNbr": 30, + "author": { + "id": 1 + }, + "writtenOn": "2012-09-11T16:55:21Z", + "side": 1, + "message": "I expect we\u0027ll have a pep8 job for this eventually; it\u0027s not a requirement to clean up the trailing whitespace (adding logging is _way_ more important than whitespace), but you might think about that for the future.", + "revId": "43ef14a241c4db5bdac71575dfe3fb2c46d3055e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "AAAALH//b4g\u003d", + "filename": "jenkins-jobs", + "patchSetId": 1 + }, + "lineNbr": 49, + "author": { + "id": 1 + }, + "writtenOn": "2012-09-11T16:55:21Z", + "side": 1, + "message": "This seems like it would be good as an .info.", + "revId": "43ef14a241c4db5bdac71575dfe3fb2c46d3055e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "AAAALH//b4c\u003d", + "filename": "jenkins-jobs", + "patchSetId": 1 + }, + "lineNbr": 52, + "author": { + "id": 1 + }, + "writtenOn": "2012-09-11T16:55:21Z", + "side": 1, + "message": ".info for this one too?", + "revId": "43ef14a241c4db5bdac71575dfe3fb2c46d3055e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "AAAALH//b4w\u003d", + "filename": "jenkins_jobs/builder.py", + "patchSetId": 1 + }, + "lineNbr": 78, + "author": { + "id": 1 + }, + "writtenOn": "2012-09-11T16:55:21Z", + "side": 1, + "message": "I think these two should be debug, and ...", + "revId": "43ef14a241c4db5bdac71575dfe3fb2c46d3055e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "AAAALH//b44\u003d", + "filename": "jenkins_jobs/builder.py", + "patchSetId": 1 + }, + "lineNbr": 225, + "author": { + "id": 1 + }, + "writtenOn": "2012-09-11T16:55:21Z", + "side": 1, + "message": "I think these two should be .info, what do you think?", + "revId": "43ef14a241c4db5bdac71575dfe3fb2c46d3055e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file