jjb/jenkins-job-builder
Code Issues Proposed changes

ModuleError exception: Fix unresolved module name case

Browse Source 
When unable to resolve module_name due to frame=None, instead of
exiting loop, frame.f_code.co_name fails with AttributeError
because of frame=None.

Change-Id: Iaea32952ecb7ad6de212bfc0bb518e438fc8177a
This commit is contained in:
Vsevolod Fedorov 2022-07-11 12:49:03 +03:00
parent 2bff1024fa
commit b84edf5878
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
jenkins_jobs/errors.py
View File

@ -16,10 +16,12 @@ class JenkinsJobsException(Exception):
class ModuleError(JenkinsJobsException):
def get_module_name(self):
frame = inspect.currentframe()
co_name = frame.f_code.co_name
module_name = "<unresolved>"
while frame and co_name != "run":
while frame:
# XML generation called via dispatch
co_name = frame.f_code.co_name
if co_name == "run":
break
if co_name == "dispatch":
data = frame.f_locals
module_name = "%s.%s" % (data["component_type"], data["name"])
@ -30,7 +32,6 @@ class ModuleError(JenkinsJobsException):
module_name = next(iter(data.keys()))
break
frame = frame.f_back
co_name = frame.f_code.co_name
return module_name