jjb
/
jenkins-job-builder
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 35706 \u003c35706@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35706\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34567 \u003c34567@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35706\u003e replied on the change"}
This commit is contained in:
Gerrit User 35706 2023-02-16 21:09:59 +00:00 committed by Gerrit Code Review
parent 9b301b902f
commit bc042cca25
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
aa9897dff3b17981bf9fc100b220bdb382396d45
View File

@ -70,6 +70,24 @@
"parentUuid": "99894a33_0b5e7139",
"revId": "aa9897dff3b17981bf9fc100b220bdb382396d45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3b7b5453_5fe2fdc1",
"filename": "tests/multibranch/fixtures/scm_github_full.yaml",
"patchSetId": 1
},
"lineNbr": 56,
"author": {
"id": 35706
},
"writtenOn": "2023-02-16T21:09:59Z",
"side": 1,
"message": "Thanks for the pointer.\nI\u0027ve added more positive test cases, however it seems that the exception case will take some time. I\u0027ve added also `test_errors` (same mechanism as in `yamlparser`), but `check_generator` has some deep fixture magic that causes that XML generation happens on test setup instead of in the test body... This causes `pytest.raises` to miss the exception (well, it\u0027s not even executed).\n\nThis is my current `test_errors`:\n\n def test_error(check_generator, expected_error):\n with pytest.raises(Exception) as excinfo:\n check_generator(project_multibranch.WorkflowMultiBranch)\n assert str(excinfo.value) \u003d\u003d expected_error",
"parentUuid": "4622bf43_9125420d",
"revId": "aa9897dff3b17981bf9fc100b220bdb382396d45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}