Merge "Tests: Add tests for duplicate views"

tests/duplicates/test_job_duplicates.py

@@ -22,7 +22,7 @@ from jenkins_jobs.errors import JenkinsJobsException
 from tests.enum_scenarios import scenario_list
 
 
-fixtures_dir = Path(__file__).parent / "fixtures"
+fixtures_dir = Path(__file__).parent / "job_fixtures"
 
 
 @pytest.fixture(

tests/duplicates/test_view_duplicates.py

@@ -0,0 +1,27 @@
+from operator import attrgetter
+from pathlib import Path
+
+import pytest
+
+from jenkins_jobs.errors import JenkinsJobsException
+from tests.enum_scenarios import scenario_list
+
+
+fixtures_dir = Path(__file__).parent / "view_fixtures"
+
+
+@pytest.fixture(
+    params=scenario_list(fixtures_dir),
+    ids=attrgetter("name"),
+)
+def scenario(request):
+    return request.param
+
+
+def test_yaml_snippet(scenario, check_view):
+    if scenario.in_path.name.startswith("exception_"):
+        with pytest.raises(JenkinsJobsException) as excinfo:
+            check_view()
+        assert str(excinfo.value).startswith("Duplicate ")
+    else:
+        check_view()

tests/duplicates/view_fixtures/duplicate_views_in_project.xml

@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<hudson.model.AllView>
+  <name>sample-template-1.1</name>
+  <description>Views for version 1.1&lt;!-- Managed by Jenkins Job Builder --&gt;</description>
+  <filterExecutors>false</filterExecutors>
+  <filterQueue>false</filterQueue>
+  <properties class="hudson.model.View$PropertyList"/>
+</hudson.model.AllView>
+<?xml version="1.0" encoding="utf-8"?>
+<hudson.model.AllView>
+  <name>sample-template-2.0</name>
+  <description>Views for version 2.0&lt;!-- Managed by Jenkins Job Builder --&gt;</description>
+  <filterExecutors>false</filterExecutors>
+  <filterQueue>false</filterQueue>
+  <properties class="hudson.model.View$PropertyList"/>
+</hudson.model.AllView>

tests/duplicates/view_fixtures/duplicate_views_in_project.yaml

@@ -0,0 +1,12 @@
+- view-template:
+    name: sample-template-{version}
+    view-type: all
+    description: 'Views for version {version}'
+
+- project:
+    name: sample-project
+    version: 1.1
+    views:
+      - sample-template-{version}
+      - sample-template-{version}:
+          version: 2.0

tests/duplicates/view_fixtures/exception_duplicate_view.yaml

@@ -0,0 +1,7 @@
+- view:
+    name: duplicate-view
+    view-type: all
+
+- view:
+    name: duplicate-view
+    view-type: all

tests/duplicates/view_fixtures/exception_duplicate_view_template.yaml

@@ -0,0 +1,12 @@
+- view-template:
+    name: duplicate-view-template
+    view-type: all
+
+- view-template:
+    name: duplicate-view-template
+    view-type: all
+
+- project:
+    name: sample-project
+    views:
+      - duplicate-view-template

tests/duplicates/view_fixtures/exception_duplicate_views_in_project.yaml

@@ -0,0 +1,9 @@
+- view-template:
+    name: sample-template
+    view-type: all
+
+- project:
+    name: sample-project
+    views:
+      - sample-template
+      - sample-template