6e237c4369
When a jjb run is thrown when another jjb is already running, it can cause corruption of cache. Start using a fasteners to ensure this won't be happening and run securely on automated systems. Ensure unlock is called from only the destructor, so that it is only called when the JJB process is guaranteed to be finished using it. Make it obvious that _lock is intended to be internal to the cache storage implementation. Potentially we may not need to call it at all, as python might unlock it for us on exit by closing the file when no longer needed. However better to make it explicit. Change-Id: I53a1f92cf2bfbbe87c9ea205c377f93869353620
49 lines
1.7 KiB
Python
49 lines
1.7 KiB
Python
#
|
|
# - Copyright (c) 2014 Hewlett-Packard Development Company, L.P.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import os
|
|
|
|
import jenkins_jobs
|
|
from tests import base
|
|
from tests.base import mock
|
|
|
|
|
|
class TestCaseJobCache(base.BaseTestCase):
|
|
|
|
@mock.patch('jenkins_jobs.builder.JobCache.get_cache_dir',
|
|
lambda x: '/bad/file')
|
|
def test_save_on_exit(self):
|
|
"""
|
|
Test that the cache is saved on normal object deletion
|
|
"""
|
|
|
|
with mock.patch('jenkins_jobs.builder.JobCache.save') as save_mock:
|
|
with mock.patch('os.path.isfile', return_value=False):
|
|
with mock.patch('jenkins_jobs.builder.JobCache._lock'):
|
|
jenkins_jobs.builder.JobCache("dummy")
|
|
save_mock.assert_called_with()
|
|
|
|
@mock.patch('jenkins_jobs.builder.JobCache.get_cache_dir',
|
|
lambda x: '/bad/file')
|
|
def test_cache_file(self):
|
|
"""
|
|
Test providing a cachefile.
|
|
"""
|
|
test_file = os.path.abspath(__file__)
|
|
with mock.patch('os.path.join', return_value=test_file):
|
|
with mock.patch('yaml.load'):
|
|
with mock.patch('jenkins_jobs.builder.JobCache._lock'):
|
|
jenkins_jobs.builder.JobCache("dummy").data = None
|