jjb
/
jenkins-job-builder
Code Issues Proposed changes
jenkins-job-builder/tests/wrappers/fixtures
History
Ken Dreyer 787164e09a wrappers: omit blank settings for ssh-user-private-key credential 
For the ssh-user-private-key credential-wrapper, the "key-file-variable"
setting is mandatory, but the "username-variable" and
"passphrase-variable" settings are optional.

Prior to this commit, if a user omitted "username-variable" or
"passphrase-variable" settings, JJB would write empty
<usernameVariable/> or <passphraseVariable/> entries. When both were
empty, the credentials-binding plugin would crash with an error:

  IllegalArgumentException("Cannot use the same key in both secretValues and publicValues")

To resolve this, do not write XML entries for these optional parameters
when the user does not specify them.

Add a minimal test case reproducer.

Change-Id: I94a4437eee6a8fdaf655c1a3bf69d46844b225bc
 		2022-06-09 16:37:50 -04:00
..
timeout Updated BuildTimeoutWrapper plugin 2020-10-02 13:34:16 +02:00
android001.xml adding support for android emulator 2015-08-20 16:39:17 -07:00
android001.yaml adding support for android emulator 2015-08-20 16:39:17 -07:00
android002.xml adding support for android emulator 2015-08-20 16:39:17 -07:00
android002.yaml adding support for android emulator 2015-08-20 16:39:17 -07:00
android003.xml adding support for android emulator 2015-08-20 16:39:17 -07:00
android003.yaml adding support for android emulator 2015-08-20 16:39:17 -07:00
ansicolor-full.xml ansicolor: Enforce valid types 2018-08-16 22:03:42 +08:00
ansicolor-full.yaml ansicolor: Enforce valid types 2018-08-16 22:03:42 +08:00
ansicolor-minimal.xml ansicolor: Enforce valid types 2018-08-16 22:03:42 +08:00
ansicolor-minimal.yaml ansicolor: Enforce valid types 2018-08-16 22:03:42 +08:00
artifactory001.xml Add support for Artifactory plugin 2015-09-17 13:47:05 -04:00
artifactory001.yaml Add support for Artifactory plugin 2015-09-17 13:47:05 -04:00
artifactory002.plugins_info.yaml Default artifactory-generic to newest plugin config format 2017-07-26 15:58:26 -04:00
artifactory002.xml Add `Specs support` for `artifactory_generic` 2019-04-10 13:58:31 +03:00
artifactory002.yaml Add support for Artifactory plugin 2015-09-17 13:47:05 -04:00
artifactory003.xml Add support for Artifactory plugin 2015-09-17 13:47:05 -04:00
artifactory003.yaml Normalize newlines at end of file 2018-06-29 16:07:06 -04:00
artifactory004.plugins_info.yaml Fix Generic Artifactory repository key selection options. 2016-04-24 16:29:43 +01:00
artifactory004.xml Add `Specs support` for `artifactory_generic` 2019-04-10 13:58:31 +03:00
artifactory004.yaml Fix Generic Artifactory repository key selection options. 2016-04-24 16:29:43 +01:00
artifactory005.xml Add `Specs support` for `artifactory_generic` 2019-04-10 13:58:31 +03:00
artifactory005.yaml Add `Specs support` for `artifactory_generic` 2019-04-10 13:58:31 +03:00
artifactory006.xml Add `Specs support` for `artifactory_generic` 2019-04-10 13:58:31 +03:00
artifactory006.yaml Add `Specs support` for `artifactory_generic` 2019-04-10 13:58:31 +03:00
build-keeper0001.xml Adding Build Keeper plugin. 2015-12-23 07:08:02 -05:00
build-keeper0001.yaml Adding Build Keeper plugin. 2015-12-23 07:08:02 -05:00
build-keeper0002.xml Adding Build Keeper plugin. 2015-12-23 07:08:02 -05:00
build-keeper0002.yaml Adding Build Keeper plugin. 2015-12-23 07:08:02 -05:00
build-keeper0003.xml Adding Build Keeper plugin. 2015-12-23 07:08:02 -05:00
build-keeper0003.yaml Adding Build Keeper plugin. 2015-12-23 07:08:02 -05:00
build-keeper0004.xml Adding Build Keeper plugin. 2015-12-23 07:08:02 -05:00
build-keeper0004.yaml Adding Build Keeper plugin. 2015-12-23 07:08:02 -05:00
build-keeper0005.xml build-keeper: Add support for RunCondition 2018-08-27 22:26:40 +08:00
build-keeper0005.yaml build-keeper: Add support for RunCondition 2018-08-27 22:26:40 +08:00
build-name001.xml Update Build Name support 2020-10-02 13:35:45 +02:00
build-name001.yaml Update Build Name support 2020-10-02 13:35:45 +02:00
ci-skip001.xml Added support for Ci Skip Plugin 2014-02-03 16:51:56 +09:00
ci-skip001.yaml Added support for Ci Skip Plugin 2014-02-03 16:51:56 +09:00
config-file-provider-full.xml config-file-provider: Add tests 2018-09-07 22:50:46 +08:00
config-file-provider-full.yaml config-file-provider: Add tests 2018-09-07 22:50:46 +08:00
config-file-provider-minimal.xml config-file-provider: Add tests 2018-09-07 22:50:46 +08:00
config-file-provider-minimal.yaml config-file-provider: Add tests 2018-09-07 22:50:46 +08:00
copy-to-slave001.xml Normalize newlines at end of file 2018-06-29 16:07:06 -04:00
copy-to-slave001.yaml Normalize newlines at end of file 2018-06-29 16:07:06 -04:00
copy-to-slave002.xml Normalize newlines at end of file 2018-06-29 16:07:06 -04:00
copy-to-slave002.yaml Add support of 'somewhereElse' value to Copy to slave plugin 2015-12-07 00:35:06 -05:00
credentials-binding-full.xml wrappers: rename credentials-binding examples 2022-06-09 16:04:33 -04:00
credentials-binding-full.yaml wrappers: rename credentials-binding examples 2022-06-09 16:04:33 -04:00
credentials-binding-ssh-minimal.xml wrappers: omit blank settings for ssh-user-private-key credential 2022-06-09 16:37:50 -04:00
credentials-binding-ssh-minimal.yaml wrappers: omit blank settings for ssh-user-private-key credential 2022-06-09 16:37:50 -04:00
custom-tools001.xml Update custom_tools to use convert_to_xml() 2017-07-21 15:25:19 +01:00
custom-tools001.yaml Normalize newlines at end of file 2018-06-29 16:07:06 -04:00
delivery-pipeline-full.xml Update Delivery Pipeline plugin to use convert xml 2016-07-27 22:01:34 -04:00
delivery-pipeline-full.yaml Update Delivery Pipeline plugin to use convert xml 2016-07-27 22:01:34 -04:00
delivery-pipeline-minimal.xml Update Delivery Pipeline plugin to use convert xml 2016-07-27 22:01:34 -04:00
delivery-pipeline-minimal.yaml Update Delivery Pipeline plugin to use convert xml 2016-07-27 22:01:34 -04:00
docker-custom-build-env001.xml docker-custom-build-env: Add support for new options 2018-09-21 18:38:31 +05:30
docker-custom-build-env001.yaml docker-custom-build-env: Add support for new options 2018-09-21 18:38:31 +05:30
docker-custom-build-env002.xml docker-custom-build-env: Add support for new options 2018-09-21 18:38:31 +05:30
docker-custom-build-env002.yaml Add Docker Custom Build Environment Plugin support 2016-01-21 23:27:51 +00:00
env-file001.xml Fix multibyte character problem 2014-01-21 22:34:30 +09:00
env-file001.yaml update doc and add new JJB unit tests 2013-11-22 17:51:17 +00:00
env-script001.xml wrappers: fix XML node name for scrip-env's only-run-on-parent 2018-04-12 19:11:32 -04:00
env-script001.yaml Normalize newlines at end of file 2018-06-29 16:07:06 -04:00
env-script002.xml wrappers: fix XML node name for scrip-env's only-run-on-parent 2018-04-12 19:11:32 -04:00
env-script002.yaml Add script-type to env-script wrapper 2016-01-25 17:12:48 -05:00
exclusion001.xml Normalize newlines at end of file 2018-06-29 16:07:06 -04:00
exclusion001.yaml Added support for Exclusion plugin 2014-04-21 13:14:47 -04:00
exclusion002.xml Normalize newlines at end of file 2018-06-29 16:07:06 -04:00
exclusion002.yaml Added support for Exclusion plugin 2014-04-21 13:14:47 -04:00
exclusion003.xml Normalize newlines at end of file 2018-06-29 16:07:06 -04:00
exclusion003.yaml Added support for Exclusion plugin 2014-04-21 13:14:47 -04:00
github-pull-request-full.xml Add support for ghprb wrappers 2017-11-08 09:12:45 -05:00
github-pull-request-full.yaml Add support for ghprb wrappers 2017-11-08 09:12:45 -05:00
github-pull-request-minimal.xml Add support for ghprb wrappers 2017-11-08 09:12:45 -05:00
github-pull-request-minimal.yaml Add support for ghprb wrappers 2017-11-08 09:12:45 -05:00
inject-full.xml Normalize newlines at end of file 2018-06-29 16:07:06 -04:00
inject-full.yaml Normalize newlines at end of file 2018-06-29 16:07:06 -04:00
inject-minimal.xml Normalize newlines at end of file 2018-06-29 16:07:06 -04:00
inject-minimal.yaml Normalize newlines at end of file 2018-06-29 16:07:06 -04:00
jclouds001.xml Convert jclouds example to unit test 2016-04-22 19:52:22 +01:00
jclouds001.yaml Convert jclouds example to unit test 2016-04-22 19:52:22 +01:00
job-log-logger001.xml Add 'Job Log Logger' wrapper 2015-03-17 19:09:52 -07:00
job-log-logger001.yaml Add 'Job Log Logger' wrapper 2015-03-17 19:09:52 -07:00
live-screenshot-full.xml Update live-screenshot plugin to use convert xml 2016-07-14 18:07:20 -04:00
live-screenshot-full.yaml Update live-screenshot plugin to use convert xml 2016-07-14 18:07:20 -04:00
live-screenshot-minimal.xml Update live-screenshot plugin to use convert xml 2016-07-14 18:07:20 -04:00
live-screenshot-minimal.yaml Update live-screenshot plugin to use convert xml 2016-07-14 18:07:20 -04:00
locks001.xml wrappers: fixed locks for empty collection 2014-09-15 14:49:49 +02:00
locks001.yaml wrappers: fixed locks for empty collection 2014-09-15 14:49:49 +02:00
locks002.xml wrappers: fixed locks for empty collection 2014-09-15 14:49:49 +02:00
locks002.yaml wrappers: fixed locks for empty collection 2014-09-15 14:49:49 +02:00
logfilesize-full.xml Update Logfilesizechecker to use convert xml 2016-07-14 18:25:28 -04:00
logfilesize-full.yaml Update Logfilesizechecker to use convert xml 2016-07-14 18:25:28 -04:00
logfilesize-minimal.xml Update Logfilesizechecker to use convert xml 2016-07-14 18:25:28 -04:00
logfilesize-minimal.yaml Update Logfilesizechecker to use convert xml 2016-07-14 18:25:28 -04:00
logfilesize001.xml Update Logfilesizechecker to use convert xml 2016-07-14 18:25:28 -04:00
logfilesize001.yaml Update Logfilesizechecker to use convert xml 2016-07-14 18:25:28 -04:00
logstash001.xml added logstash plugin support and fixed test typo 2014-02-06 21:26:32 -07:00
logstash001.yaml added logstash plugin support and fixed test typo 2014-02-06 21:26:32 -07:00
logstash002.xml added logstash plugin support and fixed test typo 2014-02-06 21:26:32 -07:00
logstash002.yaml added logstash plugin support and fixed test typo 2014-02-06 21:26:32 -07:00
logstash003.xml added logstash plugin support and fixed test typo 2014-02-06 21:26:32 -07:00
logstash003.yaml added logstash plugin support and fixed test typo 2014-02-06 21:26:32 -07:00
m2-repository-cleanup001.xml Add support for M2 repository cleanup plugin 2015-01-20 14:56:56 -05:00
m2-repository-cleanup001.yaml Add support for M2 repository cleanup plugin 2015-01-20 14:56:56 -05:00
m2-repository-cleanup002.xml Add support for M2 repository cleanup plugin 2015-01-20 14:56:56 -05:00
m2-repository-cleanup002.yaml Add support for M2 repository cleanup plugin 2015-01-20 14:56:56 -05:00
matrix-tie-parent.xml Removed the unnecessary empty combinationFilter Tag 2020-07-07 11:32:51 +02:00
matrix-tie-parent.yaml Support Matrix Tie Parent Plugin in wrappers 2014-04-08 10:57:24 +09:00
maven-release001.xml Add partial support for maven-release-plugin 2016-07-05 18:27:50 -07:00
maven-release001.yaml Add partial support for maven-release-plugin 2016-07-05 18:27:50 -07:00
maven-release002.xml Add partial support for maven-release-plugin 2016-07-05 18:27:50 -07:00
maven-release002.yaml Add partial support for maven-release-plugin 2016-07-05 18:27:50 -07:00
mongo-db-full.xml Update MongoDB plugin 2016-07-14 18:51:10 -04:00
mongo-db-full.yaml Update MongoDB plugin 2016-07-14 18:51:10 -04:00
mongo-db-minimal.xml Update MongoDB plugin 2016-07-14 18:51:10 -04:00
mongo-db-minimal.yaml Update MongoDB plugin 2016-07-14 18:51:10 -04:00
nodejs-installator001.xml fixed config format for nodejs plugin 2018-04-28 10:15:07 +01:00
nodejs-installator001.yaml add support for NodeJS Plugin 2015-11-10 21:46:00 +00:00
openstack001.xml Update openstack to use convert_mapping_to_xml() 2017-08-21 19:27:09 +01:00
openstack001.yaml Add support for Jenkins OpenStack Cloud Plugin 2016-05-17 13:32:49 +09:00
openstack002.xml Update openstack to use convert_mapping_to_xml() 2017-08-21 19:27:09 +01:00
openstack002.yaml Add support for Jenkins OpenStack Cloud Plugin 2016-05-17 13:32:49 +09:00
openstack003.xml Add support for Jenkins OpenStack Cloud Plugin 2016-05-17 13:32:49 +09:00
openstack003.yaml Add support for Jenkins OpenStack Cloud Plugin 2016-05-17 13:32:49 +09:00
ownership001.xml Implements wrapper for ownership plugin. 2014-09-01 14:11:16 +03:00
ownership001.yaml Implements wrapper for ownership plugin. 2014-09-01 14:11:16 +03:00
passwords001.xml add support for EnvInject mask password params option 2015-01-20 15:12:56 -06:00
passwords001.yaml Normalize newlines at end of file 2018-06-29 16:07:06 -04:00
port-allocator001.xml Add support for multiple port allocations 2014-10-30 10:02:57 -06:00
port-allocator001.yaml Add support for multiple port allocations 2014-10-30 10:02:57 -06:00
port-allocator002.xml Add support for multiple port allocations 2014-10-30 10:02:57 -06:00
port-allocator002.yaml Add support for multiple port allocations 2014-10-30 10:02:57 -06:00
pre-scm-buildstep001.plugins_info.yaml Wrapper pre-scm-buildstep: added support for failOnError parameter 2017-03-28 17:10:29 +00:00
pre-scm-buildstep001.xml Wrapper pre-scm-buildstep: added support for failOnError parameter 2017-03-28 17:10:29 +00:00
pre-scm-buildstep001.yaml Wrapper pre-scm-buildstep: added support for failOnError parameter 2017-03-28 17:10:29 +00:00
pre-scm-buildstep002.plugins_info.yaml Wrapper pre-scm-buildstep: added support for failOnError parameter 2017-03-28 17:10:29 +00:00
pre-scm-buildstep002.xml Wrapper pre-scm-buildstep: added support for failOnError parameter 2017-03-28 17:10:29 +00:00
pre-scm-buildstep002.yaml Wrapper pre-scm-buildstep: added support for failOnError parameter 2017-03-28 17:10:29 +00:00
raw001.xml Add support for 'raw' to inject direct xml to job configs. 2015-05-02 15:42:32 -07:00
raw001.yaml Add support for 'raw' to inject direct xml to job configs. 2015-05-02 15:42:32 -07:00
rbenv001.xml Update Urls for redirects and broken 2016-04-22 15:11:47 +01:00
rbenv001.yaml Added rbenv wrapper 2014-01-23 16:47:11 -07:00
rbenv002.xml Update Urls for redirects and broken 2016-04-22 15:11:47 +01:00
rbenv002.yaml Added rbenv wrapper 2014-01-23 16:47:11 -07:00
rbenv003.xml Added rbenv wrapper 2014-01-23 16:47:11 -07:00
rbenv003.yaml Added rbenv wrapper 2014-01-23 16:47:11 -07:00
release001.xml Added trim option for String parameter. 2020-05-22 17:04:49 +03:00
release001.yaml Create one parameters wrapper tag for all release params 2014-08-25 16:12:11 +01:00
sonar-full.xml Add support for Sonar wrapper 2016-09-12 21:35:44 -04:00
sonar-full.yaml Add support for Sonar wrapper 2016-09-12 21:35:44 -04:00
sonar-minimal.xml Add support for Sonar wrapper 2016-09-12 21:35:44 -04:00
sonar-minimal.yaml Add support for Sonar wrapper 2016-09-12 21:35:44 -04:00
ssh-agent-credentials001.xml ssh-agent-credentials: Support ignore-missing-credentials param 2018-07-29 17:10:14 +08:00
ssh-agent-credentials001.yaml Adding feature to specify the user id for jenkins user credentials 2014-08-22 19:13:29 -05:00
ssh-agent-credentials002.xml Fix SSH Agent plugin markup for empty list of users 2022-02-13 17:47:39 +01:00
ssh-agent-credentials002.yaml Add support of multiple credentials for ssh-agent-credentials wrapper 2015-03-17 11:45:37 +00:00
ssh-agent-credentials003.xml Fix SSH Agent plugin markup for empty list of users 2022-02-13 17:47:39 +01:00
ssh-agent-credentials003.yaml Add support of multiple credentials for ssh-agent-credentials wrapper 2015-03-17 11:45:37 +00:00
ssh-agent-credentials004-post-v1.5.xml Fix SSH Agent plugin markup for empty list of users 2022-02-13 17:47:39 +01:00
ssh-agent-credentials004-post-v1.5.yaml Fix SSH Agent plugin markup for empty list of users 2022-02-13 17:47:39 +01:00
ssh-agent-credentials004.plugins_info.yaml Fix SSH Agent plugin markup for empty list of users 2022-02-13 17:47:39 +01:00
ssh-agent-credentials004.xml ssh-agent-credentials: Support ignore-missing-credentials param 2018-07-29 17:10:14 +08:00
ssh-agent-credentials004.yaml Add support of multiple credentials for ssh-agent-credentials wrapper 2015-03-17 11:45:37 +00:00
ssh-agent-credentials005.xml Fix SSH Agent plugin markup for empty list of users 2022-02-13 17:47:39 +01:00
ssh-agent-credentials005.yaml Fix SSH Agent plugin markup for empty list of users 2022-02-13 17:47:39 +01:00
vault-full.xml Add missing vault-secrets options 2020-10-13 07:51:16 -05:00
vault-full.yaml Add missing vault-secrets options 2020-10-13 07:51:16 -05:00
vault-minimal.xml Add missing vault-secrets options 2020-10-13 07:51:16 -05:00
vault-minimal.yaml Adds wrapper for vault plugin 2018-06-28 13:29:34 +00:00
version-number001.xml Adds support for prefix-variable in version-number wrapper 2017-08-14 13:42:24 -07:00
version-number001.yaml Adds support for prefix-variable in version-number wrapper 2017-08-14 13:42:24 -07:00
workspace-cleanup-full.xml Add support of "disableDeferredWipeout" option to workspace cleanup plugin 2019-08-14 20:50:06 +02:00
workspace-cleanup-full.yaml Add support of "disableDeferredWipeout" option to workspace cleanup plugin 2019-08-14 20:50:06 +02:00
workspace-cleanup-min.xml Add support of "disableDeferredWipeout" option to workspace cleanup plugin 2019-08-14 20:50:06 +02:00
workspace-cleanup-min.yaml Fix workspace cleanup code 2017-07-07 17:58:16 +01:00
xvfb-full.xml Update xvfb to use convert xml 2016-08-20 02:43:21 -04:00
xvfb-full.yaml Update xvfb to use convert xml 2016-08-20 02:43:21 -04:00
xvfb-minimal.xml Update xvfb to use convert xml 2016-08-20 02:43:21 -04:00
xvfb-minimal.yaml Update xvfb to use convert xml 2016-08-20 02:43:21 -04:00
xvnc-full.xml Update xvnc to use convert xml 2016-07-22 12:37:29 -04:00
xvnc-full.yaml Update xvnc to use convert xml 2016-07-22 12:37:29 -04:00
xvnc-minimal.xml Update xvnc to use convert xml 2016-07-22 12:37:29 -04:00
xvnc-minimal.yaml Update xvnc to use convert xml 2016-07-22 12:37:29 -04:00