![Christoffer Skeppstedt](/assets/img/avatar_default.png)
When configuring the trigger_builds Builder in the Jenkins web interface, you can add the parameter "Pass-through Git Commit that was built". You could not configure this in a jobs.yml. This commit adds that functionality (both to the builder "trigger_builds " and the publisher "trigger_parameterized_builds"). I still want to be backwards compatible with the old version (true/false) and maintain the similarity with the svn-revision param. Which means that you can either configure it as git-revision: true/false or git-revision: combine-queued-commits: true/false There were no prior case of shared code between builders and publishers, so (by recommendation) I put the common logic in builders.py, and then imported it in publishers.py. I added thorough tests for the feature in the builders fixtures, and only a basic test in the publishers fixtures, as suggested. Change-Id: I72cdcae3fac1094ffcc9367369556b8bcbe2d5d7
40 lines
1.9 KiB
XML
40 lines
1.9 KiB
XML
<?xml version="1.0" encoding="utf-8"?>
|
|
<project>
|
|
<publishers>
|
|
<hudson.plugins.parameterizedtrigger.BuildTrigger>
|
|
<configs>
|
|
<hudson.plugins.parameterizedtrigger.BuildTriggerConfig>
|
|
<configs>
|
|
<hudson.plugins.git.GitRevisionBuildParameters>
|
|
<combineQueuedCommits>true</combineQueuedCommits>
|
|
</hudson.plugins.git.GitRevisionBuildParameters>
|
|
<hudson.plugins.parameterizedtrigger.FileBuildParameters>
|
|
<propertiesFile>version.prop</propertiesFile>
|
|
<failTriggerOnMissing>false</failTriggerOnMissing>
|
|
<encoding>UTF-8</encoding>
|
|
</hudson.plugins.parameterizedtrigger.FileBuildParameters>
|
|
<hudson.plugins.parameterizedtrigger.SubversionRevisionBuildParameters>
|
|
<includeUpstreamParameters>true</includeUpstreamParameters>
|
|
</hudson.plugins.parameterizedtrigger.SubversionRevisionBuildParameters>
|
|
<hudson.plugins.parameterizedtrigger.BooleanParameters>
|
|
<configs>
|
|
<hudson.plugins.parameterizedtrigger.BooleanParameterConfig>
|
|
<name>p1</name>
|
|
<value>true</value>
|
|
</hudson.plugins.parameterizedtrigger.BooleanParameterConfig>
|
|
<hudson.plugins.parameterizedtrigger.BooleanParameterConfig>
|
|
<name>p2</name>
|
|
<value>false</value>
|
|
</hudson.plugins.parameterizedtrigger.BooleanParameterConfig>
|
|
</configs>
|
|
</hudson.plugins.parameterizedtrigger.BooleanParameters>
|
|
</configs>
|
|
<projects>other_job,foo,bar</projects>
|
|
<condition>ALWAYS</condition>
|
|
<triggerWithNoParameters>false</triggerWithNoParameters>
|
|
</hudson.plugins.parameterizedtrigger.BuildTriggerConfig>
|
|
</configs>
|
|
</hudson.plugins.parameterizedtrigger.BuildTrigger>
|
|
</publishers>
|
|
</project>
|