57 lines
3.1 KiB
Plaintext
57 lines
3.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "94ece74b_77bbcd5e",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 10,
|
|
"author": {
|
|
"id": 13807
|
|
},
|
|
"writtenOn": "2023-01-30T16:45:28Z",
|
|
"side": 1,
|
|
"message": "Does this mean we will be dropping support for single non-parsed entries like \"job\", \"view\", etc.... if we merge the feature later in this change chain?\n\nIf so, I guess I\u0027m not against that since I think job-template is much more useful than \"job\" and can be used statically if you really want but with extra steps. I\u0027m not sure how many users use single job definitions but I guess we\u0027ll have to do a major version bump once the final change is merged to signal breaking changes.\n\n(Apologies if this is obvious further down the change chain since I don\u0027t have time to go through and fully understand everything in this chain of changes just yet but am trying to slowly look at them.)",
|
|
"revId": "f7c6e4f43d590e52f6b91a0b2e76c60a77c74287",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "76c34ff5_b76612d7",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 10,
|
|
"author": {
|
|
"id": 34567
|
|
},
|
|
"writtenOn": "2023-01-30T17:45:10Z",
|
|
"side": 1,
|
|
"message": "No. Change in review up the chain does not remove standalone job and view support. It only changes parser logic which affects duplicate checks. In that change, jobs listed in a projects are just ignored. Because that\u0027s actually is no-op in current implementation - listing jobs in a project does not affect jobs instantiation.\n\nBut I have plans to remove standalone jobs and views in favor of templates. Also I have plans to always expand macros, have they parameters passed to them or not. But these will go in separate reviews, after I create tasks with detailed explanation why that should be done. And after I raise this issue in mail list, with same explanation. And only after that I want to assign new major version.\n\nBy the way, I am glad you are back! It really helps knowing someone with better knowledge reviews my changes.",
|
|
"parentUuid": "94ece74b_77bbcd5e",
|
|
"revId": "f7c6e4f43d590e52f6b91a0b2e76c60a77c74287",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "98857d93_01bc9091",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 10,
|
|
"author": {
|
|
"id": 13807
|
|
},
|
|
"writtenOn": "2023-02-01T10:25:43Z",
|
|
"side": 1,
|
|
"message": "Thanks for explaining. That sounds reasonable. I don\u0027t have much time so don\u0027t expect quick reviews but I\u0027m trying to get through my review queue one at a time when I have a moment to spare. 😊",
|
|
"parentUuid": "76c34ff5_b76612d7",
|
|
"revId": "f7c6e4f43d590e52f6b91a0b2e76c60a77c74287",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |