jjb/python-jenkins
Code Issues Proposed changes

Use str as base class for PluginVersion

Browse Source 
To allow PluginVersion class to be passed to builtin functions expecting
a string type, need to use 'str' as the base class. This ensures
the change to support version comparison is completely transparent to
the calling code, but permits changes to benefit from the new behaviour
without breaking existing usage.

Change-Id: I7d434294fa45171e47ea4876d01398cb75f5d962
This commit is contained in:
Darragh Bailey 2015-09-29 18:03:27 +01:00
parent 344b5f3ffa
commit 87a892a232
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jenkins/plugins.py
View File

@ -67,7 +67,7 @@ class Plugin(dict):
super(Plugin, self).__setitem__(key, value) super(Plugin, self).__setitem__(key, value)
class PluginVersion(object): class PluginVersion(str):
'''Class providing comparison capabilities for plugin versions.''' '''Class providing comparison capabilities for plugin versions.'''
_VERSION_RE = re.compile(r'(.*)-(?:SNAPSHOT|BETA)') _VERSION_RE = re.compile(r'(.*)-(?:SNAPSHOT|BETA)')