opendev/ansible-role-puppet
Code Issues Proposed changes

Set facts type to dict

Browse Source 
With newer versions of ansible, module arguments are assumed to
be strings unless otherwise specified.  Our 'facts' argument is
expected to be a dictionary, so tell ansible that.

Without this, the argument will arrive as a string and be written
to the facter file inside string quotes.  Facter will produce the
following error:

  undefined method `each' for #<String:0x000000016ee640>

Change-Id: Iea626466d0920349f434f678fe2f71cbee259383
This commit is contained in:
James E. Blair 2017-01-12 09:55:37 -08:00
parent 3fe078c070
commit 8d0f0bfd0a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
library/puppet
View File

@ -163,7 +163,7 @@ def main():
show_diff=dict( show_diff=dict(
# internal code to work with --diff, do not use # internal code to work with --diff, do not use
default=False, aliases=['show-diff'], type='bool'), default=False, aliases=['show-diff'], type='bool'),
facts=dict(default=None), facts=dict(default=None, type='dict'),
facter_basename=dict(default='ansible'), facter_basename=dict(default='ansible'),
environment=dict(required=False, default=None), environment=dict(required=False, default=None),
certname=dict(required=False, default=None), certname=dict(required=False, default=None),