92 lines
3.0 KiB
Plaintext
92 lines
3.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "dfbec78f_7ba26bb0",
|
|
"filename": "tasks/config.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 4146
|
|
},
|
|
"writtenOn": "2019-05-13T16:24:51Z",
|
|
"side": 1,
|
|
"message": "This checks that puppet_environmentpath is a truthy value but the old check was specifically that the value was empty string.\n\nIs this an equivalent (or otherwise correct) update?",
|
|
"revId": "44cb40aafa64b1c26889a6de9c92bf993466eae1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dfbec78f_dba6f7ab",
|
|
"filename": "tasks/config.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 6547
|
|
},
|
|
"writtenOn": "2019-05-13T16:27:17Z",
|
|
"side": 1,
|
|
"message": "https://docs.ansible.com/ansible-lint/rules/default_rules.html E602 has \"Use when: var rather than when: var !\u003d \"\" (or conversely when: not var rather than when: var \u003d\u003d \"\")\"",
|
|
"parentUuid": "dfbec78f_7ba26bb0",
|
|
"revId": "44cb40aafa64b1c26889a6de9c92bf993466eae1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dfbec78f_5be9a7b4",
|
|
"filename": "tasks/config.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 4146
|
|
},
|
|
"writtenOn": "2019-05-13T16:29:07Z",
|
|
"side": 1,
|
|
"message": "I think this should be:\n\n when:\n - puppet_version \u003d\u003d \u00273\u0027\n - not puppet_environmentpath\n\nGiven those docs (old code was \u003d\u003d \u0027\u0027 not !\u003d \u0027\u0027)",
|
|
"parentUuid": "dfbec78f_dba6f7ab",
|
|
"revId": "44cb40aafa64b1c26889a6de9c92bf993466eae1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dfbec78f_fb95fb40",
|
|
"filename": "tasks/main.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 98,
|
|
"author": {
|
|
"id": 4146
|
|
},
|
|
"writtenOn": "2019-05-13T16:24:51Z",
|
|
"side": 1,
|
|
"message": "This comparison and the one below imply the check on the earlier file was not updated properly. I think we may need a not as below?",
|
|
"revId": "44cb40aafa64b1c26889a6de9c92bf993466eae1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dfbec78f_9be39fd9",
|
|
"filename": "tasks/main.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 98,
|
|
"author": {
|
|
"id": 6547
|
|
},
|
|
"writtenOn": "2019-05-13T16:28:17Z",
|
|
"side": 1,
|
|
"message": "This should be fine, see https://docs.ansible.com/ansible-lint/rules/default_rules.html E602",
|
|
"parentUuid": "dfbec78f_fb95fb40",
|
|
"revId": "44cb40aafa64b1c26889a6de9c92bf993466eae1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |