opendev/elastic-recheck
Code Issues Proposed changes

Unbreak elastic-recheck

Browse Source 
A few bugs have crept into elastic-recheck causing it to fail. This
patch fixes them.

* an update to gerritlib broke FailedEvent.rev and change, since both of
  these should always be numbers cast to ints
* We appear to be missing files occasionally, add better logging for
  (also simplify Exception classes)
* Remove last usage of skip_resolved (removed in a previous patch)

Change-Id: Ifc180989832be152e08a4873e62857a899835484
This commit is contained in:
Joe Gordon
2014-03-06 11:43:21 -08:00
parent 7f32f8815b
commit 6c47bad772
2 changed files with 25 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
elastic_recheck/tests/unit/test_stream.py
View File

@@ -40,8 +40,8 @@ class TestStream(tests.TestCase):
# there are currently 10 events in the stream, 3 are
# failures
event = stream.get_failed_tempest()
self.assertEqual(event.change, "64749")
self.assertEqual(event.rev, "6")
self.assertEqual(event.change, 64749)
self.assertEqual(event.rev, 6)
self.assertEqual(event.project, "openstack/keystone")
self.assertEqual(event.name(), "64749,6")
self.assertEqual(event.url, "https://review.openstack.org/64749")
@@ -58,16 +58,16 @@ class TestStream(tests.TestCase):
self.assertTrue(event.is_fully_classified())
event = stream.get_failed_tempest()
self.assertEqual(event.change, "63078")
self.assertEqual(event.rev, "19")
self.assertEqual(event.change, 63078)
self.assertEqual(event.rev, 19)
self.assertEqual(event.project, "openstack/horizon")
self.assertEqual(event.name(), "63078,19")
self.assertEqual(event.url, "https://review.openstack.org/63078")
self.assertEqual(event.short_build_uuids(), ["ab07162"])
event = stream.get_failed_tempest()
self.assertEqual(event.change, "65361")
self.assertEqual(event.rev, "2")
self.assertEqual(event.change, 65361)
self.assertEqual(event.rev, 2)
self.assertEqual(event.project, "openstack/requirements")
self.assertEqual(event.name(), "65361,2")
self.assertEqual(event.url, "https://review.openstack.org/65361")
@@ -122,8 +122,8 @@ class TestStream(tests.TestCase):
for job in event.failed_jobs:
if job.name == 'gate-keystone-python26':
job.bugs = ['123456']
self.assertEqual(event.change, "64749")
self.assertEqual(event.rev, "6")
self.assertEqual(event.change, 64749)
self.assertEqual(event.rev, 6)
self.assertEqual(event.project, "openstack/keystone")
self.assertEqual(event.name(), "64749,6")
self.assertEqual(event.url, "https://review.openstack.org/64749")