opendev/elastic-recheck
Code Issues Proposed changes

only display events in irc on gate issues

Browse Source 
check fails all the time, on totally crappy patches, we really
don't want to get spam on terrible patches failing for terrible
reasons. Only for things which should never fail, which is the
gate.

Change-Id: I4e8c5b338c4a1d042acc0e274ac4e78497372a83
This commit is contained in:
Sean Dague
2014-03-14 12:41:32 -04:00
parent 1909703bca
commit 9e16ccc052
1 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
elastic_recheck/bot.py
View File

@@ -120,16 +120,14 @@ class RecheckWatch(threading.Thread):
LPCACHEDIR)
def new_error(self, channel, event):
# only on gate fails
queue = event.queue()
if queue == "gate":
msg = ('%s change: %s failed %s in the %s queue with'
' an unrecognized error' %
(event.project,
event.url,
', '.join(event.failed_job_names()),
queue))
self.print_msg(channel, msg)
msg = ('%s change: %s failed %s in the %s queue with'
' an unrecognized error' %
(event.project,
event.url,
', '.join(event.failed_job_names()),
queue))
self.print_msg(channel, msg)
def error_found(self, channel, event):
msg = ('%s change: %s failed %s because of: %s' % (
@@ -173,12 +171,14 @@ class RecheckWatch(threading.Thread):
if channel in self.channel_config.events['negative']:
self.print_msg(channel, msg)
elif event:
if event.get_all_bugs():
if channel in self.channel_config.events['positive']:
self.error_found(channel, event)
else:
if channel in self.channel_config.events['negative']:
self.new_error(channel, event)
# only display events on gate queue, others are just spam
if event.queue() == "gate":
if event.get_all_bugs():
if channel in self.channel_config.events['positive']:
self.error_found(channel, event)
else:
if channel in self.channel_config.events['negative']:
self.new_error(channel, event)
else:
raise Exception('No event or msg specified')