opendev/gerrit
Code Issues Proposed changes
5d6741adf4
gerrit/.gitignore

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

35 lines
537 B
Plaintext
Raw Normal View History

Sort .gitignore Change-Id: I251a150323056aa414fdfa989dbab7a04d2219f3
2017-02-07 09:00:23 -05:00
# Keep following lines sorted according to `LC_COLLATE=C sort`
*.eml
*.iml
*.pyc
*.sublime-*
*.swp
*~
.DS_Store
.gwt_work_dir
Support AutoValue AutoValue[1] is a lightweight annotation-processor-based library for implementing classes with simple, obvious value semantics. Add support for AutoValue to build rules and Eclipse project generation. Buck does not currently have an officially-supported interface for specifying annotation processor dependencies[2], so we have to take the slightly ugly approach of monkey-patching java_library and java_test to add annotation processor arguments to each rule that requires annotation processing; hopefully this ugliness can be reduced in the future. [1] https://github.com/google/auto/tree/master/value [2] https://github.com/facebook/buck/issues/85 Change-Id: I8b49d6f9f25d61688b667d964848c6ce106ae4ec
2014-11-06 15:39:34 -08:00
/.apt_generated
Add .apt_generated_tests to .gitignore Change-Id: I1975da67be6268189c3875acfbb5dd6e33e6eee6
2018-10-12 21:32:06 +09:00
/.apt_generated_tests
Fix launching daemon in Eclipse on MacOS Change I5fc96bf1f removed the generation of the .primary_build_tool file and change I3d6b90320 removed the build system abstraction with the motivation that we now only have one build tool. However this broke launching the daemon from Eclipse on MacOS, which now fails because bazel is not on the path and can't be found. Restore the removed functionality, but rename the file to .bazel_path Change-Id: Ibd0ec09d3bf47f383ca68a37cca4e81640960416
2017-03-17 11:57:39 +09:00
/.bazel_path
Add .buckd/ back to .gitignore Change-Id: I8e435f4ec965966ebfe3e15141d203d8c4e689df
2017-01-28 21:37:14 +09:00
/.buckd
Add standard eclipse generated files to .gitignore These files keep showing up when I run git add . and it's throwing off the release script, so I am telling git to forget about them. Change-Id: I4c12e9c4d72acf8e8dc1345b6903cfa224e621ed
2010-01-29 16:53:05 -08:00
/.classpath
Support AutoValue AutoValue[1] is a lightweight annotation-processor-based library for implementing classes with simple, obvious value semantics. Add support for AutoValue to build rules and Eclipse project generation. Buck does not currently have an officially-supported interface for specifying annotation processor dependencies[2], so we have to take the slightly ugly approach of monkey-patching java_library and java_test to add annotation processor arguments to each rule that requires annotation processing; hopefully this ugliness can be reduced in the future. [1] https://github.com/google/auto/tree/master/value [2] https://github.com/facebook/buck/issues/85 Change-Id: I8b49d6f9f25d61688b667d964848c6ce106ae4ec
2014-11-06 15:39:34 -08:00
/.factorypath
Sort .gitignore Change-Id: I251a150323056aa414fdfa989dbab7a04d2219f3
2017-02-07 09:00:23 -05:00
/.idea
/.metadata
Switch build system to use Maven 2 This way we can easily depend upon other projects which also use Maven, without needing to embed all of their dependencies directly within our repository. Signed-off-by: Shawn O. Pearce <sop@google.com>
2008-12-20 17:48:48 -08:00
/.project
Add org.eclipse.ltk.core.refactoring.prefs to .gitignore Change-Id: I4c8c2f76cefd7fbcb3f208cc39e33fc5b67e28bd
2013-07-11 18:01:42 +09:00
/.settings/org.eclipse.ltk.core.refactoring.prefs
Sort .gitignore Change-Id: I251a150323056aa414fdfa989dbab7a04d2219f3
2017-02-07 09:00:23 -05:00
/.settings/org.eclipse.m2e.core.prefs
/.settings/org.maven.ide.eclipse.prefs
GitIgnore all bazel directories bazel-gerrit depends on the repo's directory name. It is in fact: bazel-$(basename $PWD). Just ignore everything that starts with bazel- in the root directory. Change-Id: I223bd684bff2ab3c25d8131a2cf0a3ccb14ce54f
2017-07-16 12:33:55 +03:00
/bazel-*
Sort .gitignore Change-Id: I251a150323056aa414fdfa989dbab7a04d2219f3
2017-02-07 09:00:23 -05:00
/bin/
Update Buck to newest version The new Buck version fixed annoying stdout spamming bug on unit test failures: [1]. Now we can revert our monkey patching hack to prevent that. Since [2] Buck interferes with files in buck-out directory: [3]. Switch to using eclipse-out directory as Eclipse output directory instead. For this change it's necessary to clean up buck-out directory, otherwise `buck test` would fail. This version also fixed "Python client lost connection" bug: [4]. This reverts commit 94e93aaad22e67b5956627cff1a9cb84d03a29ec. [1] https://github.com/facebook/buck/issues/505 [2] https://github.com/facebook/buck/commit/35cb495b57f0b804253fbe25937a0000db131a9d [3] https://github.com/facebook/buck/issues/527 [4] https://github.com/facebook/buck/issues/534 Change-Id: I4cd1a99ce9d0615713c235d873e6cdd61b1854bb
2015-11-22 11:13:59 +01:00
/eclipse-out
Add buck build soyc to output GWT split point report The GWT compiler can output a report (or "story of your compile"), describing the size of the JavaScript and which source classes contributed to the overall download size. This is useful for optimizing code splits in Dispatcher, and generally understanding the impact of linking code together. Only the "Split Point Report" is created. The "Compiler Metrics" are not output. The report is very slow to create, so it is not done by default. Change-Id: I6ce86d65ee5f3e4bdba573d1f777ccc59767341d
2015-01-14 16:27:42 -08:00
/extras
Sort .gitignore Change-Id: I251a150323056aa414fdfa989dbab7a04d2219f3
2017-02-07 09:00:23 -05:00
/gerrit-package-plugins
/gwt-unitCache
Ignore infer output folder Infer [1] is a static code checker. [1] http://fbinfer.com Bug: Issue 5198 Change-Id: I51ac941b85b18c63ead61a2a3f00c5d58a9c2212
2016-12-24 16:11:42 +01:00
/infer-out
Build with Buck Implement a new build system using Buck[1], Facebook's open source clone of Google's internal build system. Pros: - Concise build language - Test and build output is concise - Test failures and stack traces show on terminal - Reliable incrementals; clean is unnecessary - Extensible with simple blocks of Python - Fast buck: clean: 0.452s, full 1m21.083s [*], no-op: 7.145s, mvn: clean: 4.596s, full 2m53.776s, no-op: 59.108s, [*] full build includes downloading all dependencies, time can vary due to remote server performance. Cons: - No Windows support - No native Maven Central support (added by macros) - No native GWT, Prolog, or WAR support (added by macros) - Bootstrap of buck requires Ant Getting started: git clone https://gerrit.googlesource.com/buck cd buck ant Mac OS X: PATH="`pwd`/bin:/System/Library/Frameworks/JavaVM.framework/Versions/Current/Commands:$PATH" Linux: PATH="`pwd`/bin:$PATH" Importing into Eclipse: $ time buck build :eclipse 0m48.949s Import existing project from `pwd` Import 'gerrit' (do not import other Maven based projects) Expand 'gerrit' Right click 'buck-out' > Properties Under Attributes check 'Derived' If the code doesn't currently compile but an updated classpath is needed, refresh the configs and obtain missing JARs: $ buck build :eclipse_project :download Running JUnit tests: $ time buck test --all -e slow # skip slow tests 0m19.320s $ time buck test --all # includes acceptance tests 5m17.517s Building WAR: $ buck build :gerrit $ java -jar buck-out/gen/gerrit.war Building release: $ buck test --all && buck build :api :release $ java -jar buck-out/gen/release.war $ ls -lh buck-out/gen/{extension,plugin}-api.jar Downloading dependencies: Dependencies are normally downloaded automatically, but Buck can inspect its graph and download missing dependencies so future compiles can run without the network: $ buck build :download [1] http://facebook.github.io/buck/ Change-Id: I40853b108bd8e153cefa0896a5280a9a5ff81655
2013-05-08 14:14:24 -07:00
/local.properties
Add /plugins/cookbook-plugin/ to .gitignore This folder pops up when switching between master/stable-2.15/stable-2.14 and older stable branches. Change-Id: I4c3c6e8835de8498a8a35b75eecd607de067eb55 Signed-off-by: Edwin Kempin <ekempin@google.com>
2017-11-06 11:39:13 +01:00
/plugins/cookbook-plugin/
Sort .gitignore Change-Id: I251a150323056aa414fdfa989dbab7a04d2219f3
2017-02-07 09:00:23 -05:00
/test_site
Document gjf and add a script to standardize/streamline setup google-java-format is not uniformly available in package management systems across OSes. More importantly, we want to make sure that all contributors are using a standardized version, to avoid unnecessary changes due to slight differences between versions. While we're in the dev documentation, link to the Google Java Style Guide, and remove some wording that is clearly redundant with the style guide. Change-Id: Ib14dab2e692339f836083fad08a7a435a2f24470
2017-02-07 09:22:33 -05:00
/tools/format
Remove outstanding references to buck Most references are in documentation and comments. The main developer-visible behavior change is moving the downloaded artifact cache from ~/.gerritcodereview/buck-cache to bazel-cache, which will result in re-downloading dependencies on the next build; this had to happen sooner or later. Alternatives, which are not worth the effort, include teaching the scripts to accept both locations, or having it rearrange and/or symlink directories behind the scenes. There are just a few references remaining, all of which are intentional: $ git grep -Pi '\bbuck(lets?)?\b' HEAD HEAD:java/com/google/gerrit/httpd/raw/StaticModule.java: // https://gerrit-review.googlesource.com/#/c/57570/57/gerrit-httpd/BUCK@32 HEAD:resources/com/google/gerrit/server/mime/mime-types.properties:bucklet = text/x-python HEAD:resources/com/google/gerrit/server/mime/mime-types.properties:BUCK = text/x-python Change-Id: Idb93a483451ccf86ba96c379d38008a7894c3f95
2017-11-14 08:40:55 -05:00
/.vscode
Ignore intellij bazel plugin's data directory .ijwb is used by bazel intellij plugin to store build status. Plugin info at: https://github.com/bazelbuild/intellij Change-Id: Idf4e80f55eb405833068ed8ae6c0cdc4d12d782c
2018-11-09 10:05:00 +00:00
/.ijwb
Copy Permalink