opendev/gerrit
Code Issues Proposed changes
b364901445
gerrit/lib/gwt/BUCK

63 lines
1.4 KiB
Python
Raw Normal View History

Build with Buck Implement a new build system using Buck[1], Facebook's open source clone of Google's internal build system. Pros: - Concise build language - Test and build output is concise - Test failures and stack traces show on terminal - Reliable incrementals; clean is unnecessary - Extensible with simple blocks of Python - Fast buck: clean: 0.452s, full 1m21.083s [*], no-op: 7.145s, mvn: clean: 4.596s, full 2m53.776s, no-op: 59.108s, [*] full build includes downloading all dependencies, time can vary due to remote server performance. Cons: - No Windows support - No native Maven Central support (added by macros) - No native GWT, Prolog, or WAR support (added by macros) - Bootstrap of buck requires Ant Getting started: git clone https://gerrit.googlesource.com/buck cd buck ant Mac OS X: PATH="`pwd`/bin:/System/Library/Frameworks/JavaVM.framework/Versions/Current/Commands:$PATH" Linux: PATH="`pwd`/bin:$PATH" Importing into Eclipse: $ time buck build :eclipse 0m48.949s Import existing project from `pwd` Import 'gerrit' (do not import other Maven based projects) Expand 'gerrit' Right click 'buck-out' > Properties Under Attributes check 'Derived' If the code doesn't currently compile but an updated classpath is needed, refresh the configs and obtain missing JARs: $ buck build :eclipse_project :download Running JUnit tests: $ time buck test --all -e slow # skip slow tests 0m19.320s $ time buck test --all # includes acceptance tests 5m17.517s Building WAR: $ buck build :gerrit $ java -jar buck-out/gen/gerrit.war Building release: $ buck test --all && buck build :api :release $ java -jar buck-out/gen/release.war $ ls -lh buck-out/gen/{extension,plugin}-api.jar Downloading dependencies: Dependencies are normally downloaded automatically, but Buck can inspect its graph and download missing dependencies so future compiles can run without the network: $ buck build :download [1] http://facebook.github.io/buck/ Change-Id: I40853b108bd8e153cefa0896a5280a9a5ff81655
2013-05-08 14:14:24 -07:00
include_defs('//lib/maven.defs')
Update GWT to 2.7 As pointed out in this thread on GWT-discuss development group [1], gwt-dev is going to be unbundled in 2.7 release. That means that we would have to supply its dependencies explicitly. To start with we need to pass in ASM library. It's unclear though, if we need asm-commons and asm-xml as it compiles without it, but corresponding parent-pom contains it [2]. GWT unit tests were disabled as gwt-test-utils doesn't seem to work yet against upcoming GWT 2.7 release. Issue was filed upstream [3]. As was pointed out in this thread [4], codeserver is now shipped in gwt-dev.jar as well. Stop fetching codeserver.jar in addition and use the bits from gwt-dev.jar. [1] https://groups.google.com/d/topic/google-web-toolkit/LwXXQCG_I_k/discussion [2] http://repo1.maven.org/maven2/org/ow2/asm/asm-parent/5.0.3/asm-parent-5.0.3.pom [3] https://github.com/gwt-test-utils/gwt-test-utils/issues/68 [4] https://groups.google.com/d/topic/google-web-toolkit-contributors/pFYPE7Uoub8/discussion Bug: issue 3008 Bug: issue 3027 Change-Id: Ib8f9ed0c767e9f41f104253fdc8b74a8cbbe38ab
2014-08-17 15:04:52 +02:00
VERSION = '2.7.0'
Build with Buck Implement a new build system using Buck[1], Facebook's open source clone of Google's internal build system. Pros: - Concise build language - Test and build output is concise - Test failures and stack traces show on terminal - Reliable incrementals; clean is unnecessary - Extensible with simple blocks of Python - Fast buck: clean: 0.452s, full 1m21.083s [*], no-op: 7.145s, mvn: clean: 4.596s, full 2m53.776s, no-op: 59.108s, [*] full build includes downloading all dependencies, time can vary due to remote server performance. Cons: - No Windows support - No native Maven Central support (added by macros) - No native GWT, Prolog, or WAR support (added by macros) - Bootstrap of buck requires Ant Getting started: git clone https://gerrit.googlesource.com/buck cd buck ant Mac OS X: PATH="`pwd`/bin:/System/Library/Frameworks/JavaVM.framework/Versions/Current/Commands:$PATH" Linux: PATH="`pwd`/bin:$PATH" Importing into Eclipse: $ time buck build :eclipse 0m48.949s Import existing project from `pwd` Import 'gerrit' (do not import other Maven based projects) Expand 'gerrit' Right click 'buck-out' > Properties Under Attributes check 'Derived' If the code doesn't currently compile but an updated classpath is needed, refresh the configs and obtain missing JARs: $ buck build :eclipse_project :download Running JUnit tests: $ time buck test --all -e slow # skip slow tests 0m19.320s $ time buck test --all # includes acceptance tests 5m17.517s Building WAR: $ buck build :gerrit $ java -jar buck-out/gen/gerrit.war Building release: $ buck test --all && buck build :api :release $ java -jar buck-out/gen/release.war $ ls -lh buck-out/gen/{extension,plugin}-api.jar Downloading dependencies: Dependencies are normally downloaded automatically, but Buck can inspect its graph and download missing dependencies so future compiles can run without the network: $ buck build :download [1] http://facebook.github.io/buck/ Change-Id: I40853b108bd8e153cefa0896a5280a9a5ff81655
2013-05-08 14:14:24 -07:00
maven_jar(
name = 'user',
id = 'com.google.gwt:gwt-user:' + VERSION,
Update GWT to 2.7 As pointed out in this thread on GWT-discuss development group [1], gwt-dev is going to be unbundled in 2.7 release. That means that we would have to supply its dependencies explicitly. To start with we need to pass in ASM library. It's unclear though, if we need asm-commons and asm-xml as it compiles without it, but corresponding parent-pom contains it [2]. GWT unit tests were disabled as gwt-test-utils doesn't seem to work yet against upcoming GWT 2.7 release. Issue was filed upstream [3]. As was pointed out in this thread [4], codeserver is now shipped in gwt-dev.jar as well. Stop fetching codeserver.jar in addition and use the bits from gwt-dev.jar. [1] https://groups.google.com/d/topic/google-web-toolkit/LwXXQCG_I_k/discussion [2] http://repo1.maven.org/maven2/org/ow2/asm/asm-parent/5.0.3/asm-parent-5.0.3.pom [3] https://github.com/gwt-test-utils/gwt-test-utils/issues/68 [4] https://groups.google.com/d/topic/google-web-toolkit-contributors/pFYPE7Uoub8/discussion Bug: issue 3008 Bug: issue 3027 Change-Id: Ib8f9ed0c767e9f41f104253fdc8b74a8cbbe38ab
2014-08-17 15:04:52 +02:00
sha1 = 'bdc7af42581745d3d79c2efe0b514f432b998a5b',
Build with Buck Implement a new build system using Buck[1], Facebook's open source clone of Google's internal build system. Pros: - Concise build language - Test and build output is concise - Test failures and stack traces show on terminal - Reliable incrementals; clean is unnecessary - Extensible with simple blocks of Python - Fast buck: clean: 0.452s, full 1m21.083s [*], no-op: 7.145s, mvn: clean: 4.596s, full 2m53.776s, no-op: 59.108s, [*] full build includes downloading all dependencies, time can vary due to remote server performance. Cons: - No Windows support - No native Maven Central support (added by macros) - No native GWT, Prolog, or WAR support (added by macros) - Bootstrap of buck requires Ant Getting started: git clone https://gerrit.googlesource.com/buck cd buck ant Mac OS X: PATH="`pwd`/bin:/System/Library/Frameworks/JavaVM.framework/Versions/Current/Commands:$PATH" Linux: PATH="`pwd`/bin:$PATH" Importing into Eclipse: $ time buck build :eclipse 0m48.949s Import existing project from `pwd` Import 'gerrit' (do not import other Maven based projects) Expand 'gerrit' Right click 'buck-out' > Properties Under Attributes check 'Derived' If the code doesn't currently compile but an updated classpath is needed, refresh the configs and obtain missing JARs: $ buck build :eclipse_project :download Running JUnit tests: $ time buck test --all -e slow # skip slow tests 0m19.320s $ time buck test --all # includes acceptance tests 5m17.517s Building WAR: $ buck build :gerrit $ java -jar buck-out/gen/gerrit.war Building release: $ buck test --all && buck build :api :release $ java -jar buck-out/gen/release.war $ ls -lh buck-out/gen/{extension,plugin}-api.jar Downloading dependencies: Dependencies are normally downloaded automatically, but Buck can inspect its graph and download missing dependencies so future compiles can run without the network: $ buck build :download [1] http://facebook.github.io/buck/ Change-Id: I40853b108bd8e153cefa0896a5280a9a5ff81655
2013-05-08 14:14:24 -07:00
license = 'Apache2.0',
attach_source = False,
)
maven_jar(
name = 'dev',
id = 'com.google.gwt:gwt-dev:' + VERSION,
Update GWT to 2.7 As pointed out in this thread on GWT-discuss development group [1], gwt-dev is going to be unbundled in 2.7 release. That means that we would have to supply its dependencies explicitly. To start with we need to pass in ASM library. It's unclear though, if we need asm-commons and asm-xml as it compiles without it, but corresponding parent-pom contains it [2]. GWT unit tests were disabled as gwt-test-utils doesn't seem to work yet against upcoming GWT 2.7 release. Issue was filed upstream [3]. As was pointed out in this thread [4], codeserver is now shipped in gwt-dev.jar as well. Stop fetching codeserver.jar in addition and use the bits from gwt-dev.jar. [1] https://groups.google.com/d/topic/google-web-toolkit/LwXXQCG_I_k/discussion [2] http://repo1.maven.org/maven2/org/ow2/asm/asm-parent/5.0.3/asm-parent-5.0.3.pom [3] https://github.com/gwt-test-utils/gwt-test-utils/issues/68 [4] https://groups.google.com/d/topic/google-web-toolkit-contributors/pFYPE7Uoub8/discussion Bug: issue 3008 Bug: issue 3027 Change-Id: Ib8f9ed0c767e9f41f104253fdc8b74a8cbbe38ab
2014-08-17 15:04:52 +02:00
sha1 = 'c2c3dd5baf648a0bb199047a818be5e560f48982',
Build with Buck Implement a new build system using Buck[1], Facebook's open source clone of Google's internal build system. Pros: - Concise build language - Test and build output is concise - Test failures and stack traces show on terminal - Reliable incrementals; clean is unnecessary - Extensible with simple blocks of Python - Fast buck: clean: 0.452s, full 1m21.083s [*], no-op: 7.145s, mvn: clean: 4.596s, full 2m53.776s, no-op: 59.108s, [*] full build includes downloading all dependencies, time can vary due to remote server performance. Cons: - No Windows support - No native Maven Central support (added by macros) - No native GWT, Prolog, or WAR support (added by macros) - Bootstrap of buck requires Ant Getting started: git clone https://gerrit.googlesource.com/buck cd buck ant Mac OS X: PATH="`pwd`/bin:/System/Library/Frameworks/JavaVM.framework/Versions/Current/Commands:$PATH" Linux: PATH="`pwd`/bin:$PATH" Importing into Eclipse: $ time buck build :eclipse 0m48.949s Import existing project from `pwd` Import 'gerrit' (do not import other Maven based projects) Expand 'gerrit' Right click 'buck-out' > Properties Under Attributes check 'Derived' If the code doesn't currently compile but an updated classpath is needed, refresh the configs and obtain missing JARs: $ buck build :eclipse_project :download Running JUnit tests: $ time buck test --all -e slow # skip slow tests 0m19.320s $ time buck test --all # includes acceptance tests 5m17.517s Building WAR: $ buck build :gerrit $ java -jar buck-out/gen/gerrit.war Building release: $ buck test --all && buck build :api :release $ java -jar buck-out/gen/release.war $ ls -lh buck-out/gen/{extension,plugin}-api.jar Downloading dependencies: Dependencies are normally downloaded automatically, but Buck can inspect its graph and download missing dependencies so future compiles can run without the network: $ buck build :download [1] http://facebook.github.io/buck/ Change-Id: I40853b108bd8e153cefa0896a5280a9a5ff81655
2013-05-08 14:14:24 -07:00
license = 'Apache2.0',
deps = [
':javax-validation',
':javax-validation_src',
GWT DevMode is dead; set up SuperDevMode The codeserver runs separately and cannot easily be embedded in Gerrit because it depends on an outdated version of Jetty. We may change this behavior when GWT is updated. Prerequisite is to download gwt-codeserver.jar and dependencies: buck build codeserver Start CodeServer with new launch configuration: tools/eclipse/gerrit_gwt_codeserver.launch And follow the instructions: [1]. [1] http://stackoverflow.com/a/18333050/116472 Inspired-By: Thomas Broyer <t.broyer@gmail.com> Change-Id: Ieff7190db6bc151eae1274105ccf828eaa652027
2014-06-03 11:14:57 +02:00
':json',
Build with Buck Implement a new build system using Buck[1], Facebook's open source clone of Google's internal build system. Pros: - Concise build language - Test and build output is concise - Test failures and stack traces show on terminal - Reliable incrementals; clean is unnecessary - Extensible with simple blocks of Python - Fast buck: clean: 0.452s, full 1m21.083s [*], no-op: 7.145s, mvn: clean: 4.596s, full 2m53.776s, no-op: 59.108s, [*] full build includes downloading all dependencies, time can vary due to remote server performance. Cons: - No Windows support - No native Maven Central support (added by macros) - No native GWT, Prolog, or WAR support (added by macros) - Bootstrap of buck requires Ant Getting started: git clone https://gerrit.googlesource.com/buck cd buck ant Mac OS X: PATH="`pwd`/bin:/System/Library/Frameworks/JavaVM.framework/Versions/Current/Commands:$PATH" Linux: PATH="`pwd`/bin:$PATH" Importing into Eclipse: $ time buck build :eclipse 0m48.949s Import existing project from `pwd` Import 'gerrit' (do not import other Maven based projects) Expand 'gerrit' Right click 'buck-out' > Properties Under Attributes check 'Derived' If the code doesn't currently compile but an updated classpath is needed, refresh the configs and obtain missing JARs: $ buck build :eclipse_project :download Running JUnit tests: $ time buck test --all -e slow # skip slow tests 0m19.320s $ time buck test --all # includes acceptance tests 5m17.517s Building WAR: $ buck build :gerrit $ java -jar buck-out/gen/gerrit.war Building release: $ buck test --all && buck build :api :release $ java -jar buck-out/gen/release.war $ ls -lh buck-out/gen/{extension,plugin}-api.jar Downloading dependencies: Dependencies are normally downloaded automatically, but Buck can inspect its graph and download missing dependencies so future compiles can run without the network: $ buck build :download [1] http://facebook.github.io/buck/ Change-Id: I40853b108bd8e153cefa0896a5280a9a5ff81655
2013-05-08 14:14:24 -07:00
],
attach_source = False,
Update GWT version to 2.6.0-rc3 GWT 2.6.0 has Java 7 support and other new features [1]. Internal Jetty version, shipped with GWT was updated to 8.1. This version collides with the version that is used internally by Gerrit (9.1). To resolve the conflict, GWT's own Jetty version is stripped from the gwt-dev.jar with maven_jar() method and Gerrit's own Jetty used instead. Missing Jetty artifacts, needed for the GWT to run in dev mode: * jetty-webapp * jetty-xml are included now as dependency of gerrit-gwtdebug project. New GWT version updates a number of dependencies that are used in Gerrit [3]. Update them too. EditIteratorTest test is failing with NSME Exception in gwt-test-utils framework, so deactivate it for now [2]. [1] http://www.gwtproject.org/release-notes.html#Release_Notes_2_6_0_RC1 [2] https://code.google.com/p/gwt-test-utils/issues/detail?id=179 [3] * Guava 15.0 * Protobuf 2.5.0 * ASM 4.1 Change-Id: I0fa96da6465d52febeae65168b0bd1c2913f6c7e
2014-01-19 14:13:37 +01:00
exclude = ['org/eclipse/jetty/*'],
Build with Buck Implement a new build system using Buck[1], Facebook's open source clone of Google's internal build system. Pros: - Concise build language - Test and build output is concise - Test failures and stack traces show on terminal - Reliable incrementals; clean is unnecessary - Extensible with simple blocks of Python - Fast buck: clean: 0.452s, full 1m21.083s [*], no-op: 7.145s, mvn: clean: 4.596s, full 2m53.776s, no-op: 59.108s, [*] full build includes downloading all dependencies, time can vary due to remote server performance. Cons: - No Windows support - No native Maven Central support (added by macros) - No native GWT, Prolog, or WAR support (added by macros) - Bootstrap of buck requires Ant Getting started: git clone https://gerrit.googlesource.com/buck cd buck ant Mac OS X: PATH="`pwd`/bin:/System/Library/Frameworks/JavaVM.framework/Versions/Current/Commands:$PATH" Linux: PATH="`pwd`/bin:$PATH" Importing into Eclipse: $ time buck build :eclipse 0m48.949s Import existing project from `pwd` Import 'gerrit' (do not import other Maven based projects) Expand 'gerrit' Right click 'buck-out' > Properties Under Attributes check 'Derived' If the code doesn't currently compile but an updated classpath is needed, refresh the configs and obtain missing JARs: $ buck build :eclipse_project :download Running JUnit tests: $ time buck test --all -e slow # skip slow tests 0m19.320s $ time buck test --all # includes acceptance tests 5m17.517s Building WAR: $ buck build :gerrit $ java -jar buck-out/gen/gerrit.war Building release: $ buck test --all && buck build :api :release $ java -jar buck-out/gen/release.war $ ls -lh buck-out/gen/{extension,plugin}-api.jar Downloading dependencies: Dependencies are normally downloaded automatically, but Buck can inspect its graph and download missing dependencies so future compiles can run without the network: $ buck build :download [1] http://facebook.github.io/buck/ Change-Id: I40853b108bd8e153cefa0896a5280a9a5ff81655
2013-05-08 14:14:24 -07:00
)
GWT DevMode is dead; set up SuperDevMode The codeserver runs separately and cannot easily be embedded in Gerrit because it depends on an outdated version of Jetty. We may change this behavior when GWT is updated. Prerequisite is to download gwt-codeserver.jar and dependencies: buck build codeserver Start CodeServer with new launch configuration: tools/eclipse/gerrit_gwt_codeserver.launch And follow the instructions: [1]. [1] http://stackoverflow.com/a/18333050/116472 Inspired-By: Thomas Broyer <t.broyer@gmail.com> Change-Id: Ieff7190db6bc151eae1274105ccf828eaa652027
2014-06-03 11:14:57 +02:00
maven_jar(
name = 'json',
id = 'org.json:json:20140107',
sha1 = 'd1ffca6e2482b002702c6a576166fd685e3370e3',
license = 'DO_NOT_DISTRIBUTE',
attach_source = False,
)
Build with Buck Implement a new build system using Buck[1], Facebook's open source clone of Google's internal build system. Pros: - Concise build language - Test and build output is concise - Test failures and stack traces show on terminal - Reliable incrementals; clean is unnecessary - Extensible with simple blocks of Python - Fast buck: clean: 0.452s, full 1m21.083s [*], no-op: 7.145s, mvn: clean: 4.596s, full 2m53.776s, no-op: 59.108s, [*] full build includes downloading all dependencies, time can vary due to remote server performance. Cons: - No Windows support - No native Maven Central support (added by macros) - No native GWT, Prolog, or WAR support (added by macros) - Bootstrap of buck requires Ant Getting started: git clone https://gerrit.googlesource.com/buck cd buck ant Mac OS X: PATH="`pwd`/bin:/System/Library/Frameworks/JavaVM.framework/Versions/Current/Commands:$PATH" Linux: PATH="`pwd`/bin:$PATH" Importing into Eclipse: $ time buck build :eclipse 0m48.949s Import existing project from `pwd` Import 'gerrit' (do not import other Maven based projects) Expand 'gerrit' Right click 'buck-out' > Properties Under Attributes check 'Derived' If the code doesn't currently compile but an updated classpath is needed, refresh the configs and obtain missing JARs: $ buck build :eclipse_project :download Running JUnit tests: $ time buck test --all -e slow # skip slow tests 0m19.320s $ time buck test --all # includes acceptance tests 5m17.517s Building WAR: $ buck build :gerrit $ java -jar buck-out/gen/gerrit.war Building release: $ buck test --all && buck build :api :release $ java -jar buck-out/gen/release.war $ ls -lh buck-out/gen/{extension,plugin}-api.jar Downloading dependencies: Dependencies are normally downloaded automatically, but Buck can inspect its graph and download missing dependencies so future compiles can run without the network: $ buck build :download [1] http://facebook.github.io/buck/ Change-Id: I40853b108bd8e153cefa0896a5280a9a5ff81655
2013-05-08 14:14:24 -07:00
maven_jar(
name = 'javax-validation',
id = 'javax.validation:validation-api:1.0.0.GA',
bin_sha1 = 'b6bd7f9d78f6fdaa3c37dae18a4bd298915f328e',
src_sha1 = '7a561191db2203550fbfa40d534d4997624cd369',
license = 'Apache2.0',
visibility = [],
)
Added gwt-test-utils to test EditIterator. Modfied lib/maven.defs so that maven_jar() is able to handle snapshot builds. Simplified the implementation of the advance() method in EditIterator. Previously, the method was calling substring() on the lines, which was unnecessary. Change-Id: I3b00caa140539ae77605721d741afae75ae1448e
2013-06-11 20:35:12 -07:00
maven_jar(
name = 'gwt-test-utils',
Enable disabled gwtui tests a283507bccbd408540ae1baf75eb80eb59dce031 disabled EditIteratorTest due to gwt-test-utils uncompatibility with new GWT 2.6 release. After fixing the compatibility problem in [1] the tests can be enabled again. [1] https://github.com/gwt-test-utils/gwt-test-utils/issues/62 Change-Id: I1f93e6422a1ae60d66f4d8b4abac23b6a1acb4f9
2014-02-24 23:26:26 +01:00
id = 'com.googlecode.gwt-test-utils:gwt-test-utils:0.47',
sha1 = '284749ed37d8034bac05e374070c09cce88db540',
Added gwt-test-utils to test EditIterator. Modfied lib/maven.defs so that maven_jar() is able to handle snapshot builds. Simplified the implementation of the advance() method in EditIterator. Previously, the method was calling substring() on the lines, which was unnecessary. Change-Id: I3b00caa140539ae77605721d741afae75ae1448e
2013-06-11 20:35:12 -07:00
license = 'Apache2.0',
deps = [
':javassist',
'//lib/log:api',
],
visibility = ['PUBLIC'],
)
maven_jar(
name = 'javassist',
Enable disabled gwtui tests a283507bccbd408540ae1baf75eb80eb59dce031 disabled EditIteratorTest due to gwt-test-utils uncompatibility with new GWT 2.6 release. After fixing the compatibility problem in [1] the tests can be enabled again. [1] https://github.com/gwt-test-utils/gwt-test-utils/issues/62 Change-Id: I1f93e6422a1ae60d66f4d8b4abac23b6a1acb4f9
2014-02-24 23:26:26 +01:00
id = 'org.javassist:javassist:3.18.1-GA',
sha1 = 'd9a09f7732226af26bf99f19e2cffe0ae219db5b',
Added gwt-test-utils to test EditIterator. Modfied lib/maven.defs so that maven_jar() is able to handle snapshot builds. Simplified the implementation of the advance() method in EditIterator. Previously, the method was calling substring() on the lines, which was unnecessary. Change-Id: I3b00caa140539ae77605721d741afae75ae1448e
2013-06-11 20:35:12 -07:00
license = 'Apache2.0',
visibility = [],
)
Copy Permalink