gerrit/polygerrit-ui/app/elements/diff/gr-diff-comment/gr-diff-comment_test.html

<!DOCTYPE html>
<!--
Copyright (C) 2015 The Android Open Source Project

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->

<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
<title>gr-diff-comment</title>

<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
<script src="../../../bower_components/web-component-tester/browser.js"></script>
<script src="../../../bower_components/page/page.js"></script>
<script src="../../../scripts/util.js"></script>

<link rel="import" href="../../../bower_components/iron-test-helpers/iron-test-helpers.html">
<link rel="import" href="gr-diff-comment.html">

<test-fixture id="basic">
  <template>
    <gr-diff-comment></gr-diff-comment>
  </template>
</test-fixture>

<test-fixture id="draft">
  <template>
    <gr-diff-comment draft="true"></gr-diff-comment>
  </template>
</test-fixture>

<script>
  suite('gr-diff-comment tests', function() {
    var element;
    setup(function() {
      stub('gr-rest-api-interface', {
        getAccount: function() { return Promise.resolve(null); },
      });
      element = fixture('basic');
      element.comment = {
        author: {
          name: 'Mr. Peanutbutter',
          email: 'tenn1sballchaser@aol.com',
        },
        id: 'baf0414d_60047215',
        line: 5,
        message: 'is this a crossover episode!?',
        updated: '2015-12-08 19:48:33.843000000',
      };
    });

    test('proper event fires on reply', function(done) {
      element.addEventListener('reply', function(e) {
        assert.ok(e.detail.comment);
        done();
      });
      MockInteractions.tap(element.$$('.reply'));
    });

    test('proper event fires on quote', function(done) {
      element.addEventListener('reply', function(e) {
        assert.ok(e.detail.comment);
        assert.isTrue(e.detail.quote);
        done();
      });
      MockInteractions.tap(element.$$('.quote'));
    });

    test('proper event fires on done', function(done) {
      element.addEventListener('done', function(e) {
        done();
      });
      MockInteractions.tap(element.$$('.done'));
    });

    test('clicking on date link does not trigger nav', function() {
      var showStub = sinon.stub(page, 'show');
      var dateEl = element.$$('.date');
      assert.ok(dateEl);
      MockInteractions.tap(dateEl);
      var dest = window.location.pathname + '#5';
      assert(showStub.lastCall.calledWithExactly(dest, null, false),
          'Should navigate to ' + dest + ' without triggering nav');
      showStub.restore();
    });
  });

  suite('gr-diff-comment draft tests', function() {
    var element;

    setup(function() {
      stub('gr-rest-api-interface', {
        getAccount: function() { return Promise.resolve(null); },
        saveDiffDraft: function() {
          return Promise.resolve({
            ok: true,
            text: function() {
              return Promise.resolve(
                ')]}\'\n{' +
                  '"id": "baf0414d_40572e03",' +
                  '"path": "/path/to/file",' +
                  '"line": 5,' +
                  '"updated": "2015-12-08 21:52:36.177000000",' +
                  '"message": "saved!"' +
                '}'
              );
            },
          });
        },
        removeChangeReviewer: function() {
          return Promise.resolve({ok: true});
        },
      });
      stub('gr-storage', {
        getDraftComment: function() { return null; },
      });
      element = fixture('draft');
      element.changeNum = 42;
      element.patchNum = 1;
      element.editing = false;
      element.comment = {
        __draft: true,
        __draftID: 'temp_draft_id',
        path: '/path/to/file',
        line: 5,
      };
    });

    function isVisible(el) {
      assert.ok(el);
      return getComputedStyle(el).getPropertyValue('display') != 'none';
    }

    test('button visibility states', function() {
      element.showActions = false;
      assert.isTrue(element.$$('.actions').hasAttribute('hidden'));
      element.showActions = true;
      assert.isFalse(element.$$('.actions').hasAttribute('hidden'));

      element.draft = true;
      assert.isTrue(isVisible(element.$$('.edit')), 'edit is visible');
      assert.isTrue(isVisible(element.$$('.discard')), 'discard is visible');
      assert.isFalse(isVisible(element.$$('.save')), 'save is not visible');
      assert.isFalse(isVisible(element.$$('.cancel')), 'cancel is not visible');
      assert.isFalse(isVisible(element.$$('.reply')), 'reply is not visible');
      assert.isFalse(isVisible(element.$$('.quote')), 'quote is not visible');
      assert.isFalse(isVisible(element.$$('.done')), 'done is not visible');

      element.editing = true;
      assert.isFalse(isVisible(element.$$('.edit')), 'edit is not visible');
      assert.isTrue(isVisible(element.$$('.discard')), 'discard is visible');
      assert.isTrue(isVisible(element.$$('.save')), 'save is visible');
      assert.isFalse(isVisible(element.$$('.cancel')), 'cancel is visible');
      assert.isFalse(isVisible(element.$$('.reply')), 'reply is not visible');
      assert.isFalse(isVisible(element.$$('.quote')), 'quote is not visible');
      assert.isFalse(isVisible(element.$$('.done')), 'done is not visible');

      element.draft = false;
      element.editing = false;
      assert.isFalse(isVisible(element.$$('.edit')), 'edit is not visible');
      assert.isFalse(isVisible(element.$$('.discard')),
          'discard is not visible');
      assert.isFalse(isVisible(element.$$('.save')), 'save is not visible');
      assert.isFalse(isVisible(element.$$('.cancel')), 'cancel is not visible');
      assert.isTrue(isVisible(element.$$('.reply')), 'reply is visible');
      assert.isTrue(isVisible(element.$$('.quote')), 'quote is visible');
      assert.isTrue(isVisible(element.$$('.done')), 'done is visible');

      element.comment.id = 'foo';
      element.draft = true;
      element.editing = true;
      assert.isTrue(isVisible(element.$$('.cancel')), 'cancel is visible');
    });

    test('draft creation/cancelation', function(done) {
      assert.isFalse(element.editing);
      MockInteractions.tap(element.$$('.edit'));
      assert.isTrue(element.editing);

      element._messageText = '';
      // Save should be disabled on an empty message.
      var disabled = element.$$('.save').hasAttribute('disabled');
      assert.isTrue(disabled, 'save button should be disabled.');
      element._messageText = '     ';
      disabled = element.$$('.save').hasAttribute('disabled');
      assert.isTrue(disabled, 'save button should be disabled.');

      var updateStub = sinon.stub();
      element.addEventListener('comment-update', updateStub);

      var numDiscardEvents = 0;
      element.addEventListener('comment-discard', function(e) {
        numDiscardEvents++;
        if (numDiscardEvents == 3) {
          assert.isFalse(updateStub.called);
          done();
        }
      });
      MockInteractions.tap(element.$$('.cancel'));
      MockInteractions.tap(element.$$('.discard'));
      element.flushDebouncer('fire-update');
      MockInteractions.pressAndReleaseKeyOn(element.$.editTextarea, 27); // esc
    });

    test('ctrl+s saves comment', function(done) {
      var stub = sinon.stub(element, 'save', function() {
        assert.isTrue(stub.called);
        stub.restore();
        done();
      });
      element._messageText = 'is that the horse from horsing around??';
      MockInteractions.pressAndReleaseKeyOn(
        element.$.editTextarea.textarea,
        83, 'ctrl');  // 'ctrl + s'
    });

    test('draft saving/editing', function(done) {
      var fireStub = sinon.stub(element, 'fire');

      element.draft = true;
      MockInteractions.tap(element.$$('.edit'));
      element._messageText = 'good news, everyone!';
      element.flushDebouncer('fire-update');
      element.flushDebouncer('store');
      assert(fireStub.calledWith('comment-update'),
             'comment-update should be sent');
      assert.deepEqual(fireStub.lastCall.args, [
        'comment-update', {
          comment: {
            __draft: true,
            __draftID: 'temp_draft_id',
            __editing: true,
            line: 5,
            path: '/path/to/file',
          },
          patchNum: 1,
        },
      ]);
      MockInteractions.tap(element.$$('.save'));

      assert.isTrue(element.disabled,
          'Element should be disabled when creating draft.');

      element._xhrPromise.then(function(draft) {
        assert(fireStub.calledWith('comment-save'),
               'comment-save should be sent');
        assert.deepEqual(fireStub.lastCall.args[1], {
          comment: {
            __draft: true,
            __draftID: 'temp_draft_id',
            __editing: false,
            id: 'baf0414d_40572e03',
            line: 5,
            message: 'saved!',
            path: '/path/to/file',
            updated: '2015-12-08 21:52:36.177000000',
          },
          patchNum: 1,
        });
        assert.isFalse(element.disabled,
                       'Element should be enabled when done creating draft.');
        assert.equal(draft.message, 'saved!');
        assert.isFalse(element.editing);
      }).then(function() {
        MockInteractions.tap(element.$$('.edit'));
        element._messageText = 'You’ll be delivering a package to Chapek 9, ' +
            'a world where humans are killed on sight.';
        MockInteractions.tap(element.$$('.save'));
        assert.isTrue(element.disabled,
            'Element should be disabled when updating draft.');

        element._xhrPromise.then(function(draft) {
          assert.isFalse(element.disabled,
              'Element should be enabled when done updating draft.');
          assert.equal(draft.message, 'saved!');
          assert.isFalse(element.editing);
          fireStub.restore();
          done();
        });
      });
    });

    test('clicking on date link does not trigger nav', function() {
      var showStub = sinon.stub(page, 'show');
      var dateEl = element.$$('.date');
      assert.ok(dateEl);
      MockInteractions.tap(dateEl);
      var dest = window.location.pathname + '#5';
      assert(showStub.lastCall.calledWithExactly(dest, null, false),
          'Should navigate to ' + dest + ' without triggering nav');
      showStub.restore();
    });
  });
</script>
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								<!DOCTYPE html>
 								<!--
 								Copyright (C) 2015 The Android Open Source Project
 								Licensed under the Apache License, Version 2.0 (the "License");
 								you may not use this file except in compliance with the License.
 								You may obtain a copy of the License at
 								http://www.apache.org/licenses/LICENSE-2.0
 								Unless required by applicable law or agreed to in writing, software
 								distributed under the License is distributed on an "AS IS" BASIS,
 								WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 								See the License for the specific language governing permissions and
 								limitations under the License.
 								-->
 								<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
 								<title>gr-diff-comment</title>
-												Refactor directory structure of components

There is no change in functionality. Only moving things around.

+ Separate html from the js.
+ Place the unit test for a component within the same folder.
+ Organize the components in subfolders.

Change-Id: I51fdc510db75fc1b33f040ca63decbbdfd4d5513

											
										
										
											2016-03-04 17:48:22 -05:00
+								<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
 								<script src="../../../bower_components/web-component-tester/browser.js"></script>
 								<script src="../../../bower_components/page/page.js"></script>
 								<script src="../../../scripts/util.js"></script>
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
-												Refactor directory structure of components

There is no change in functionality. Only moving things around.

+ Separate html from the js.
+ Place the unit test for a component within the same folder.
+ Organize the components in subfolders.

Change-Id: I51fdc510db75fc1b33f040ca63decbbdfd4d5513

											
										
										
											2016-03-04 17:48:22 -05:00
+								<link rel="import" href="../../../bower_components/iron-test-helpers/iron-test-helpers.html">
 								<link rel="import" href="gr-diff-comment.html">
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
 								<test-fixture id="basic">
 								  <template>
 								    <gr-diff-comment></gr-diff-comment>
 								  </template>
 								</test-fixture>
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								<test-fixture id="draft">
 								  <template>
 								    <gr-diff-comment draft="true"></gr-diff-comment>
 								  </template>
 								</test-fixture>
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								<script>
 								  suite('gr-diff-comment tests', function() {
 								    var element;
 								    setup(function() {
-												gr-request/gr-ajax cleanup (gr-diff-comment)

Bug: Issue 3988
Change-Id: I0c100a0b77a256c1eb34f94e8fff0515add5dea1

											
										
										
											2016-05-03 15:14:57 -04:00
+								      stub('gr-rest-api-interface', {
 								        getAccount: function() { return Promise.resolve(null); },
 								      });
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								      element = fixture('basic');
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      element.comment = {
 								        author: {
 								          name: 'Mr. Peanutbutter',
 								          email: 'tenn1sballchaser@aol.com',
 								        },
 								        id: 'baf0414d_60047215',
 								        line: 5,
 								        message: 'is this a crossover episode!?',
 								        updated: '2015-12-08 19:48:33.843000000',
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								      };
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								    });
 								    test('proper event fires on reply', function(done) {
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								      element.addEventListener('reply', function(e) {
-												Implement 'Quote' button on diff comments

Also
+ Cleans up a TODO for a bug that isn’t existent anymore.
+ Doesn’t show cancel button unless editing a draft that has already
  been saved once.

Bug: Issue 3783
Change-Id: I102d598f64e4f37eca41ff428b574e8230e298cf

											
										
										
											2016-01-28 18:07:26 -05:00
+								        assert.ok(e.detail.comment);
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								        done();
 								      });
 								      MockInteractions.tap(element.$$('.reply'));
 								    });
-												Implement 'Quote' button on diff comments

Also
+ Cleans up a TODO for a bug that isn’t existent anymore.
+ Doesn’t show cancel button unless editing a draft that has already
  been saved once.

Bug: Issue 3783
Change-Id: I102d598f64e4f37eca41ff428b574e8230e298cf

											
										
										
											2016-01-28 18:07:26 -05:00
+								    test('proper event fires on quote', function(done) {
 								      element.addEventListener('reply', function(e) {
 								        assert.ok(e.detail.comment);
 								        assert.isTrue(e.detail.quote);
 								        done();
 								      });
 								      MockInteractions.tap(element.$$('.quote'));
 								    });
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								    test('proper event fires on done', function(done) {
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								      element.addEventListener('done', function(e) {
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								        done();
 								      });
 								      MockInteractions.tap(element.$$('.done'));
 								    });
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								    test('clicking on date link does not trigger nav', function() {
 								      var showStub = sinon.stub(page, 'show');
 								      var dateEl = element.$$('.date');
 								      assert.ok(dateEl);
 								      MockInteractions.tap(dateEl);
 								      var dest = window.location.pathname + '#5';
 								      assert(showStub.lastCall.calledWithExactly(dest, null, false),
 								          'Should navigate to ' + dest + ' without triggering nav');
 								      showStub.restore();
 								    });
 								  });
 								  suite('gr-diff-comment draft tests', function() {
 								    var element;
 								    setup(function() {
-												gr-request/gr-ajax cleanup (gr-diff-comment)

Bug: Issue 3988
Change-Id: I0c100a0b77a256c1eb34f94e8fff0515add5dea1

											
										
										
											2016-05-03 15:14:57 -04:00
+								      stub('gr-rest-api-interface', {
 								        getAccount: function() { return Promise.resolve(null); },
 								        saveDiffDraft: function() {
 								          return Promise.resolve({
 								            ok: true,
 								            text: function() {
 								              return Promise.resolve(
 								                ')]}\'\n{' +
 								                  '"id": "baf0414d_40572e03",' +
 								                  '"path": "/path/to/file",' +
 								                  '"line": 5,' +
 								                  '"updated": "2015-12-08 21:52:36.177000000",' +
 								                  '"message": "saved!"' +
 								                '}'
 								              );
 								            },
 								          });
 								        },
 								        removeChangeReviewer: function() {
 								          return Promise.resolve({ok: true});
 								        },
 								      });
-												Fix 'gr-diff-comment' test when run multiple times

The test worked fine on CI since they are run with a clean profile.
When tests were run in a normal browser profile manually, tests
'draft creation/cancelation' and 'draft saving/editing' failed
alternately because of local storage use for saving draft comments.

Since these tests do not test local storage (yet), we can just create
a stub for 'gr-storage#getDraftComment' which simulates a clean state.

Change-Id: Ibb63be4f1c395d47e0022f63d0d2ba0a7c87b137

											
										
										
											2016-06-05 12:20:11 +02:00
+								      stub('gr-storage', {
 								        getDraftComment: function() { return null; },
 								      });
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      element = fixture('draft');
 								      element.changeNum = 42;
 								      element.patchNum = 1;
-												Fix PolyGerrit tests

Change-Id: Iaac3880d6a3cfc8ae14f27ecef6b296e80dd80ed

											
										
										
											2016-02-05 18:22:05 -08:00
+								      element.editing = false;
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      element.comment = {
 								        __draft: true,
 								        __draftID: 'temp_draft_id',
 								        path: '/path/to/file',
 								        line: 5,
 								      };
 								    });
 								    function isVisible(el) {
 								      assert.ok(el);
 								      return getComputedStyle(el).getPropertyValue('display') != 'none';
 								    }
 								    test('button visibility states', function() {
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								      element.showActions = false;
 								      assert.isTrue(element.$$('.actions').hasAttribute('hidden'));
 								      element.showActions = true;
 								      assert.isFalse(element.$$('.actions').hasAttribute('hidden'));
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      element.draft = true;
 								      assert.isTrue(isVisible(element.$$('.edit')), 'edit is visible');
 								      assert.isTrue(isVisible(element.$$('.discard')), 'discard is visible');
 								      assert.isFalse(isVisible(element.$$('.save')), 'save is not visible');
 								      assert.isFalse(isVisible(element.$$('.cancel')), 'cancel is not visible');
 								      assert.isFalse(isVisible(element.$$('.reply')), 'reply is not visible');
-												Implement 'Quote' button on diff comments

Also
+ Cleans up a TODO for a bug that isn’t existent anymore.
+ Doesn’t show cancel button unless editing a draft that has already
  been saved once.

Bug: Issue 3783
Change-Id: I102d598f64e4f37eca41ff428b574e8230e298cf

											
										
										
											2016-01-28 18:07:26 -05:00
+								      assert.isFalse(isVisible(element.$$('.quote')), 'quote is not visible');
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      assert.isFalse(isVisible(element.$$('.done')), 'done is not visible');
 								      element.editing = true;
-												Fix issues detected by 'JSHint' and 'JSCS'

Change-Id: Ia535be02d19f09e716f00ec8819ba785010798f7

											
										
										
											2016-02-02 21:02:42 +01:00
+								      assert.isFalse(isVisible(element.$$('.edit')), 'edit is not visible');
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      assert.isTrue(isVisible(element.$$('.discard')), 'discard is visible');
 								      assert.isTrue(isVisible(element.$$('.save')), 'save is visible');
-												Implement 'Quote' button on diff comments

Also
+ Cleans up a TODO for a bug that isn’t existent anymore.
+ Doesn’t show cancel button unless editing a draft that has already
  been saved once.

Bug: Issue 3783
Change-Id: I102d598f64e4f37eca41ff428b574e8230e298cf

											
										
										
											2016-01-28 18:07:26 -05:00
+								      assert.isFalse(isVisible(element.$$('.cancel')), 'cancel is visible');
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      assert.isFalse(isVisible(element.$$('.reply')), 'reply is not visible');
-												Implement 'Quote' button on diff comments

Also
+ Cleans up a TODO for a bug that isn’t existent anymore.
+ Doesn’t show cancel button unless editing a draft that has already
  been saved once.

Bug: Issue 3783
Change-Id: I102d598f64e4f37eca41ff428b574e8230e298cf

											
										
										
											2016-01-28 18:07:26 -05:00
+								      assert.isFalse(isVisible(element.$$('.quote')), 'quote is not visible');
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      assert.isFalse(isVisible(element.$$('.done')), 'done is not visible');
-												Fix issues detected by 'JSHint' and 'JSCS'

Change-Id: Ia535be02d19f09e716f00ec8819ba785010798f7

											
										
										
											2016-02-02 21:02:42 +01:00
+								      element.draft = false;
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      element.editing = false;
-												Fix issues detected by 'JSHint' and 'JSCS'

Change-Id: Ia535be02d19f09e716f00ec8819ba785010798f7

											
										
										
											2016-02-02 21:02:42 +01:00
+								      assert.isFalse(isVisible(element.$$('.edit')), 'edit is not visible');
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      assert.isFalse(isVisible(element.$$('.discard')),
 								          'discard is not visible');
 								      assert.isFalse(isVisible(element.$$('.save')), 'save is not visible');
 								      assert.isFalse(isVisible(element.$$('.cancel')), 'cancel is not visible');
-												Implement 'Quote' button on diff comments

Also
+ Cleans up a TODO for a bug that isn’t existent anymore.
+ Doesn’t show cancel button unless editing a draft that has already
  been saved once.

Bug: Issue 3783
Change-Id: I102d598f64e4f37eca41ff428b574e8230e298cf

											
										
										
											2016-01-28 18:07:26 -05:00
+								      assert.isTrue(isVisible(element.$$('.reply')), 'reply is visible');
 								      assert.isTrue(isVisible(element.$$('.quote')), 'quote is visible');
 								      assert.isTrue(isVisible(element.$$('.done')), 'done is visible');
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
-												Implement 'Quote' button on diff comments

Also
+ Cleans up a TODO for a bug that isn’t existent anymore.
+ Doesn’t show cancel button unless editing a draft that has already
  been saved once.

Bug: Issue 3783
Change-Id: I102d598f64e4f37eca41ff428b574e8230e298cf

											
										
										
											2016-01-28 18:07:26 -05:00
+								      element.comment.id = 'foo';
-												Fix PolyGerrit tests

Change-Id: Iaac3880d6a3cfc8ae14f27ecef6b296e80dd80ed

											
										
										
											2016-02-05 18:22:05 -08:00
+								      element.draft = true;
-												Implement 'Quote' button on diff comments

Also
+ Cleans up a TODO for a bug that isn’t existent anymore.
+ Doesn’t show cancel button unless editing a draft that has already
  been saved once.

Bug: Issue 3783
Change-Id: I102d598f64e4f37eca41ff428b574e8230e298cf

											
										
										
											2016-01-28 18:07:26 -05:00
+								      element.editing = true;
 								      assert.isTrue(isVisible(element.$$('.cancel')), 'cancel is visible');
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								    });
 								    test('draft creation/cancelation', function(done) {
 								      assert.isFalse(element.editing);
 								      MockInteractions.tap(element.$$('.edit'));
 								      assert.isTrue(element.editing);
-												Cleanup of diff comment draft saving work

- Refactors the _editDraft property of gr-diff-comment to _messageText.
- Renames the gr-storage element as instantiated in gr-diff-comment from
  "localStorage" to "storage".
- The gr-storage diff comment functions are refactored to include
  "comment" in their names and to accept a location object rather than 4
  separate arguments.
- Added a comment describing the use of a promise in the _loadLocalDraft
  method of gr-diff-comment.
- Throttled the invocation of the _cleanupDrafts method of gr-storage to
  avoid potentially expensive crawls over all localStorage entries.
- Various other smaller fixes.

Bug: Issue 3787
Change-Id: Idf96051c0d56d6ce8b15f55ca2680363bd1ca805

											
										
										
											2016-05-23 13:53:10 -07:00
+								      element._messageText = '';
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      // Save should be disabled on an empty message.
 								      var disabled = element.$$('.save').hasAttribute('disabled');
 								      assert.isTrue(disabled, 'save button should be disabled.');
-												Cleanup of diff comment draft saving work

- Refactors the _editDraft property of gr-diff-comment to _messageText.
- Renames the gr-storage element as instantiated in gr-diff-comment from
  "localStorage" to "storage".
- The gr-storage diff comment functions are refactored to include
  "comment" in their names and to accept a location object rather than 4
  separate arguments.
- Added a comment describing the use of a promise in the _loadLocalDraft
  method of gr-diff-comment.
- Throttled the invocation of the _cleanupDrafts method of gr-storage to
  avoid potentially expensive crawls over all localStorage entries.
- Various other smaller fixes.

Bug: Issue 3787
Change-Id: Idf96051c0d56d6ce8b15f55ca2680363bd1ca805

											
										
										
											2016-05-23 13:53:10 -07:00
+								      element._messageText = '     ';
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      disabled = element.$$('.save').hasAttribute('disabled');
 								      assert.isTrue(disabled, 'save button should be disabled.');
-												Cancel comment updates on discard

Fixes race condition triggering re-rendering of a deleted comment by
canceling debounced updates for `comment.editing` changes.

Bug: Issue 4319
Change-Id: I2a7578443783360088d6f65decd7dcb8be5e636b

											
										
										
											2016-08-05 15:05:50 -07:00
+								      var updateStub = sinon.stub();
 								      element.addEventListener('comment-update', updateStub);
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      var numDiscardEvents = 0;
-												Properly remove discarded comments from model in gr-new-diff

Change-Id: Icb5d3ba1edd2cd3a75aa6568a152bacc5e0babda

											
										
										
											2016-03-25 11:29:36 -04:00
+								      element.addEventListener('comment-discard', function(e) {
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								        numDiscardEvents++;
-												PolyGerrit diff comment tweaks

+ Use buttons instead of links so that the space bar can be used
  to activate them as well as enter.
+ Allow 'esc' as a shortcut to cancel.
+ Add 2px padding to the textarea so that it matches the mirror
  it uses internally and resizes correctly.

Bug: Issue 3780
Change-Id: Iad9dc96274af6946f3632be53b106ef80f7ba6ca

											
										
										
											2016-01-16 13:35:57 -05:00
+								        if (numDiscardEvents == 3) {
-												Cancel comment updates on discard

Fixes race condition triggering re-rendering of a deleted comment by
canceling debounced updates for `comment.editing` changes.

Bug: Issue 4319
Change-Id: I2a7578443783360088d6f65decd7dcb8be5e636b

											
										
										
											2016-08-05 15:05:50 -07:00
+								          assert.isFalse(updateStub.called);
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								          done();
 								        }
 								      });
 								      MockInteractions.tap(element.$$('.cancel'));
 								      MockInteractions.tap(element.$$('.discard'));
-												Cancel comment updates on discard

Fixes race condition triggering re-rendering of a deleted comment by
canceling debounced updates for `comment.editing` changes.

Bug: Issue 4319
Change-Id: I2a7578443783360088d6f65decd7dcb8be5e636b

											
										
										
											2016-08-05 15:05:50 -07:00
+								      element.flushDebouncer('fire-update');
-												Fix gr-diff-comment-test on Firefox

The keydown event doesn’t fire when when the target of the
mock interaction is the inner textarea instead of the custom
element on firefox.

Change-Id: I630babca72ff2e28bab03540b34f2d66be912c66

											
										
										
											2016-01-18 14:24:33 -05:00
+								      MockInteractions.pressAndReleaseKeyOn(element.$.editTextarea, 27); // esc
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								    });
-												Add ctrl+s as keyboard shortcut to save comment draft

Shortcut only functions while editing the actual text area of the
comment. This makes sense, as one should have to save each individual
comment as a draft. This also mimics the current behavior of GWT UI.

Bug: Issue 3848
Change-Id: I7037d3dbdc5dae3048fcae580ed09c41e54f0669

											
										
										
											2016-08-23 12:07:04 -07:00
+								    test('ctrl+s saves comment', function(done) {
 								      var stub = sinon.stub(element, 'save', function() {
 								        assert.isTrue(stub.called);
 								        stub.restore();
 								        done();
 								      });
 								      element._messageText = 'is that the horse from horsing around??';
 								      MockInteractions.pressAndReleaseKeyOn(
 								        element.$.editTextarea.textarea,
 , 'ctrl');  // 'ctrl + s'
 								    });
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								    test('draft saving/editing', function(done) {
-												Gr-diff retrofit: store comment state

Fixing UI data pipe line, re-rendering:
 - side, draft text and editing status in UI comment objects
 - update gr-diff UI model on comment save/update

Feature: Issue 3910
Change-Id: I96f714c7de9add6e316dcf64bb7d566690b9d3ae

											
										
										
											2016-05-23 15:24:05 -07:00
+								      var fireStub = sinon.stub(element, 'fire');
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      element.draft = true;
 								      MockInteractions.tap(element.$$('.edit'));
-												Cleanup of diff comment draft saving work

- Refactors the _editDraft property of gr-diff-comment to _messageText.
- Renames the gr-storage element as instantiated in gr-diff-comment from
  "localStorage" to "storage".
- The gr-storage diff comment functions are refactored to include
  "comment" in their names and to accept a location object rather than 4
  separate arguments.
- Added a comment describing the use of a promise in the _loadLocalDraft
  method of gr-diff-comment.
- Throttled the invocation of the _cleanupDrafts method of gr-storage to
  avoid potentially expensive crawls over all localStorage entries.
- Various other smaller fixes.

Bug: Issue 3787
Change-Id: Idf96051c0d56d6ce8b15f55ca2680363bd1ca805

											
										
										
											2016-05-23 13:53:10 -07:00
+								      element._messageText = 'good news, everyone!';
-												Gr-diff retrofit: store comment state

Fixing UI data pipe line, re-rendering:
 - side, draft text and editing status in UI comment objects
 - update gr-diff UI model on comment save/update

Feature: Issue 3910
Change-Id: I96f714c7de9add6e316dcf64bb7d566690b9d3ae

											
										
										
											2016-05-23 15:24:05 -07:00
+								      element.flushDebouncer('fire-update');
 								      element.flushDebouncer('store');
 								      assert(fireStub.calledWith('comment-update'),
 								             'comment-update should be sent');
 								      assert.deepEqual(fireStub.lastCall.args, [
 								        'comment-update', {
 								          comment: {
 								            __draft: true,
 								            __draftID: 'temp_draft_id',
 								            __editing: true,
 								            line: 5,
 								            path: '/path/to/file',
 								          },
-												Ranged comments integration

- gr-file-list recognizes local preferences (for hasRangedComments flag)
- gr-file-list reacts to cursor hotkey only if there is no range
  selected (currently always false).
- Remove dead code from GrDiffBuilderSideBySide, GrDiffBuilder,
  gr-diff-builder.html
- Bugfix: GrDiffBuilder.prototype.getGroupsByLineRange handles one-line
  BOTH code sections correctly. Test updated as well.
- Added utitily methods added to gr-diff-builder.html to reduce
  dependency on DOM structure and reduce amount of code copy-pasting:
  - renderLineRange, getContentByLine, etc
- For gr-diff.js and gr-diff-comment-thread.js addDraft renamed to
  addOrEditDraft because that's what it does.
- For both, addDraft method always creates a draft comment.
- Added support for ranged comments in gr-diff, gr-diff-comment-thread.
- Added mouseenter and mouseout events to gr-comment.js
- Refactored gr-comment.js to reduce code copy-paste, unify event
  payload, and to eliminate need of accessing component instance for
  patchNum. Tests updated as well.
- Refactored gr-diff.js UI data model update using gr-diff-builder.html
  utility methods to make code more readable.
- Added support for creating ranged comments to gr-diff.js.
- gr-selection-action-box now reacts to click and tap to create a 
  comment.

Change-Id: I01480a4c6f460774a8b2826915702800b3f81d25

											
										
										
											2016-06-09 16:08:04 -07:00
+								          patchNum: 1,
-												Gr-diff retrofit: store comment state

Fixing UI data pipe line, re-rendering:
 - side, draft text and editing status in UI comment objects
 - update gr-diff UI model on comment save/update

Feature: Issue 3910
Change-Id: I96f714c7de9add6e316dcf64bb7d566690b9d3ae

											
										
										
											2016-05-23 15:24:05 -07:00
+								        },
 								      ]);
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      MockInteractions.tap(element.$$('.save'));
-												Gr-diff retrofit: store comment state

Fixing UI data pipe line, re-rendering:
 - side, draft text and editing status in UI comment objects
 - update gr-diff UI model on comment save/update

Feature: Issue 3910
Change-Id: I96f714c7de9add6e316dcf64bb7d566690b9d3ae

											
										
										
											2016-05-23 15:24:05 -07:00
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								      assert.isTrue(element.disabled,
 								          'Element should be disabled when creating draft.');
-												gr-request/gr-ajax cleanup (gr-diff-comment)

Bug: Issue 3988
Change-Id: I0c100a0b77a256c1eb34f94e8fff0515add5dea1

											
										
										
											2016-05-03 15:14:57 -04:00
+								      element._xhrPromise.then(function(draft) {
-												Gr-diff retrofit: store comment state

Fixing UI data pipe line, re-rendering:
 - side, draft text and editing status in UI comment objects
 - update gr-diff UI model on comment save/update

Feature: Issue 3910
Change-Id: I96f714c7de9add6e316dcf64bb7d566690b9d3ae

											
										
										
											2016-05-23 15:24:05 -07:00
+								        assert(fireStub.calledWith('comment-save'),
 								               'comment-save should be sent');
-												Establish annotation pipeline

Apply diff annotations (intraline differences and comment ranges) by
executing the annotation layers in order to each line. The diff builder
maintains an ordered array of annotation layers which are communicated
to GrDiffBuilder subclass instances. The builder also listens to each
layer for notifications that annotations have changed for some line
range and re-renders (i.e. re-applies the pipeline on DIV.contentText
elements) accordingly.

Change-Id: Iea0599d4869cafaadc0974158153a91d927913e8

											
										
										
											2016-07-14 12:31:09 -07:00
+								        assert.deepEqual(fireStub.lastCall.args[1], {
 								          comment: {
 								            __draft: true,
 								            __draftID: 'temp_draft_id',
 								            __editing: false,
 								            id: 'baf0414d_40572e03',
 								            line: 5,
 								            message: 'saved!',
 								            path: '/path/to/file',
 								            updated: '2015-12-08 21:52:36.177000000',
-												Gr-diff retrofit: store comment state

Fixing UI data pipe line, re-rendering:
 - side, draft text and editing status in UI comment objects
 - update gr-diff UI model on comment save/update

Feature: Issue 3910
Change-Id: I96f714c7de9add6e316dcf64bb7d566690b9d3ae

											
										
										
											2016-05-23 15:24:05 -07:00
+								          },
-												Establish annotation pipeline

Apply diff annotations (intraline differences and comment ranges) by
executing the annotation layers in order to each line. The diff builder
maintains an ordered array of annotation layers which are communicated
to GrDiffBuilder subclass instances. The builder also listens to each
layer for notifications that annotations have changed for some line
range and re-renders (i.e. re-applies the pipeline on DIV.contentText
elements) accordingly.

Change-Id: Iea0599d4869cafaadc0974158153a91d927913e8

											
										
										
											2016-07-14 12:31:09 -07:00
+								          patchNum: 1,
 								        });
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								        assert.isFalse(element.disabled,
-												Gr-diff retrofit: store comment state

Fixing UI data pipe line, re-rendering:
 - side, draft text and editing status in UI comment objects
 - update gr-diff UI model on comment save/update

Feature: Issue 3910
Change-Id: I96f714c7de9add6e316dcf64bb7d566690b9d3ae

											
										
										
											2016-05-23 15:24:05 -07:00
+								                       'Element should be enabled when done creating draft.');
-												gr-request/gr-ajax cleanup (gr-diff-comment)

Bug: Issue 3988
Change-Id: I0c100a0b77a256c1eb34f94e8fff0515add5dea1

											
										
										
											2016-05-03 15:14:57 -04:00
+								        assert.equal(draft.message, 'saved!');
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								        assert.isFalse(element.editing);
 								      }).then(function() {
 								        MockInteractions.tap(element.$$('.edit'));
-												Ranged comments integration

- gr-file-list recognizes local preferences (for hasRangedComments flag)
- gr-file-list reacts to cursor hotkey only if there is no range
  selected (currently always false).
- Remove dead code from GrDiffBuilderSideBySide, GrDiffBuilder,
  gr-diff-builder.html
- Bugfix: GrDiffBuilder.prototype.getGroupsByLineRange handles one-line
  BOTH code sections correctly. Test updated as well.
- Added utitily methods added to gr-diff-builder.html to reduce
  dependency on DOM structure and reduce amount of code copy-pasting:
  - renderLineRange, getContentByLine, etc
- For gr-diff.js and gr-diff-comment-thread.js addDraft renamed to
  addOrEditDraft because that's what it does.
- For both, addDraft method always creates a draft comment.
- Added support for ranged comments in gr-diff, gr-diff-comment-thread.
- Added mouseenter and mouseout events to gr-comment.js
- Refactored gr-comment.js to reduce code copy-paste, unify event
  payload, and to eliminate need of accessing component instance for
  patchNum. Tests updated as well.
- Refactored gr-diff.js UI data model update using gr-diff-builder.html
  utility methods to make code more readable.
- Added support for creating ranged comments to gr-diff.js.
- gr-selection-action-box now reacts to click and tap to create a 
  comment.

Change-Id: I01480a4c6f460774a8b2826915702800b3f81d25

											
										
										
											2016-06-09 16:08:04 -07:00
+								        element._messageText = 'You’ll be delivering a package to Chapek 9, ' +
 								            'a world where humans are killed on sight.';
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								        MockInteractions.tap(element.$$('.save'));
 								        assert.isTrue(element.disabled,
 								            'Element should be disabled when updating draft.');
-												gr-request/gr-ajax cleanup (gr-diff-comment)

Bug: Issue 3988
Change-Id: I0c100a0b77a256c1eb34f94e8fff0515add5dea1

											
										
										
											2016-05-03 15:14:57 -04:00
+								        element._xhrPromise.then(function(draft) {
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								          assert.isFalse(element.disabled,
 								              'Element should be enabled when done updating draft.');
-												gr-request/gr-ajax cleanup (gr-diff-comment)

Bug: Issue 3988
Change-Id: I0c100a0b77a256c1eb34f94e8fff0515add5dea1

											
										
										
											2016-05-03 15:14:57 -04:00
+								          assert.equal(draft.message, 'saved!');
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								          assert.isFalse(element.editing);
-												Fix 'gr-diff-comment' test when run multiple times

The test worked fine on CI since they are run with a clean profile.
When tests were run in a normal browser profile manually, tests
'draft creation/cancelation' and 'draft saving/editing' failed
alternately because of local storage use for saving draft comments.

Since these tests do not test local storage (yet), we can just create
a stub for 'gr-storage#getDraftComment' which simulates a clean state.

Change-Id: Ibb63be4f1c395d47e0022f63d0d2ba0a7c87b137

											
										
										
											2016-06-05 12:20:11 +02:00
+								          fireStub.restore();
-												Draft comments initial implementation

This implements basic functionality for draft CRUD operations.

There are a few things that are TBD:
+ Layout edge cases within the diff view.
+ Reply/Done actions in threads.
+ Not allowing the user to add drafts if logged out.
+ I’m sure a few more things...

Feature: Issue 3649
Change-Id: Ia7419eecee5d5b20e73e17241990d7a7ffede0e8

											
										
										
											2015-12-02 11:40:14 -05:00
+								          done();
 								        });
 								      });
 								    });
 								    test('clicking on date link does not trigger nav', function() {
 								      var showStub = sinon.stub(page, 'show');
 								      var dateEl = element.$$('.date');
 								      assert.ok(dateEl);
 								      MockInteractions.tap(dateEl);
 								      var dest = window.location.pathname + '#5';
 								      assert(showStub.lastCall.calledWithExactly(dest, null, false),
 								          'Should navigate to ' + dest + ' without triggering nav');
 								      showStub.restore();
 								    });
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								  });
 								</script>