opendev/gerrit
Code Issues Proposed changes
f9937b173b
gerrit/polygerrit-ui/app/elements/diff/gr-diff-comment-thread/gr-diff-comment-thread_test.html

309 lines
10 KiB
HTML
Raw Normal View History

[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
<!DOCTYPE html>
<!--
Copyright (C) 2015 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
<title>gr-diff-comment-thread</title>
Refactor directory structure of components There is no change in functionality. Only moving things around. + Separate html from the js. + Place the unit test for a component within the same folder. + Organize the components in subfolders. Change-Id: I51fdc510db75fc1b33f040ca63decbbdfd4d5513
2016-03-04 17:48:22 -05:00
<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
<script src="../../../bower_components/web-component-tester/browser.js"></script>
<script src="../../../scripts/util.js"></script>
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
Refactor directory structure of components There is no change in functionality. Only moving things around. + Separate html from the js. + Place the unit test for a component within the same folder. + Organize the components in subfolders. Change-Id: I51fdc510db75fc1b33f040ca63decbbdfd4d5513
2016-03-04 17:48:22 -05:00
<link rel="import" href="../../../bower_components/iron-test-helpers/iron-test-helpers.html">
<link rel="import" href="gr-diff-comment-thread.html">
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
<test-fixture id="basic">
<template>
<gr-diff-comment-thread></gr-diff-comment-thread>
</template>
</test-fixture>
Implement comment display/draft authoring Some additional cleanup of event names and fixing of the bubbles property not being placed in the right place. TODO in a follow-up change: + Comments are not considered in context, yet. So if there is a comment made in a span of common lines that are hidden, it will be there underneath the context control but wont show the code. Feature: Issue 3649 Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768
2015-12-20 19:13:45 -05:00
<test-fixture id="withComment">
<template>
<gr-diff-comment-thread></gr-diff-comment-thread>
</template>
</test-fixture>
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
<script>
suite('gr-diff-comment-thread tests', function() {
var element;
setup(function() {
Add comments/drafts to gr-new-diff Change-Id: I8110b521ab83a31be5db7e3d65268186485db04d
2016-03-20 14:14:20 -04:00
stub('gr-rest-api-interface', {
getLoggedIn: function() { return Promise.resolve(false); },
});
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
element = fixture('basic');
});
test('comments are sorted correctly', function() {
var comments = [
{
id: 'jacks_reply',
message: 'i like you, too',
in_reply_to: 'sallys_confession',
updated: '2015-12-25 15:00:20.396000000',
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
}, {
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
id: 'sallys_confession',
message: 'i like you, jack',
updated: '2015-12-24 15:00:20.396000000',
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
}, {
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
id: 'sally_to_dr_finklestein',
message: 'i’m running away',
updated: '2015-10-31 09:00:20.396000000',
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
}, {
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
id: 'sallys_defiance',
in_reply_to: 'sally_to_dr_finklestein',
message: 'i will poison you so i can get away',
updated: '2015-10-31 15:00:20.396000000',
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
}, {
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
id: 'dr_finklesteins_response',
in_reply_to: 'sally_to_dr_finklestein',
message: 'no i will pull a thread and your arm will fall off',
updated: '2015-10-31 11:00:20.396000000'
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
}, {
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
id: 'sallys_mission',
message: 'i have to find santa',
updated: '2015-12-24 21:00:20.396000000'
}
];
var results = element._sortedComments(comments);
assert.deepEqual(results, [
{
id: 'sally_to_dr_finklestein',
message: 'i’m running away',
updated: '2015-10-31 09:00:20.396000000',
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
}, {
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
id: 'dr_finklesteins_response',
in_reply_to: 'sally_to_dr_finklestein',
message: 'no i will pull a thread and your arm will fall off',
updated: '2015-10-31 11:00:20.396000000'
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
}, {
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
id: 'sallys_defiance',
in_reply_to: 'sally_to_dr_finklestein',
message: 'i will poison you so i can get away',
updated: '2015-10-31 15:00:20.396000000',
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
}, {
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
id: 'sallys_confession',
message: 'i like you, jack',
updated: '2015-12-24 15:00:20.396000000',
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
}, {
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
id: 'jacks_reply',
message: 'i like you, too',
in_reply_to: 'sallys_confession',
updated: '2015-12-25 15:00:20.396000000',
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
}, {
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
id: 'sallys_mission',
message: 'i have to find santa',
updated: '2015-12-24 21:00:20.396000000'
}
]);
});
Implement comment display/draft authoring Some additional cleanup of event names and fixing of the bubbles property not being placed in the right place. TODO in a follow-up change: + Comments are not considered in context, yet. So if there is a comment made in a span of common lines that are hidden, it will be there underneath the context control but wont show the code. Feature: Issue 3649 Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768
2015-12-20 19:13:45 -05:00
});
suite('comment action tests', function() {
var element;
setup(function() {
Add comments/drafts to gr-new-diff Change-Id: I8110b521ab83a31be5db7e3d65268186485db04d
2016-03-20 14:14:20 -04:00
stub('gr-rest-api-interface', {
getLoggedIn: function() { return Promise.resolve(false); },
Fix issues detected by 'JSHint' and 'JSCS' Change-Id: Ic1437333fcf82473ac57f8bdea25ee8188ddbfee
2016-07-13 21:06:03 +02:00
saveDiffDraft: function() {
return Promise.resolve({
ok: true,
text: function() { return Promise.resolve(')]}\'\n' +
JSON.stringify({
id: '7afa4931_de3d65bd',
path: '/path/to/file.txt',
line: 5,
in_reply_to: 'baf0414d_60047215',
updated: '2015-12-21 02:01:10.850000000',
message: 'Done'
}));
},
});
},
gr-request/gr-ajax cleanup (gr-diff-comment) Bug: Issue 3988 Change-Id: I0c100a0b77a256c1eb34f94e8fff0515add5dea1
2016-05-03 15:14:57 -04:00
deleteDiffDraft: function() { return Promise.resolve({ok: true}); },
Add comments/drafts to gr-new-diff Change-Id: I8110b521ab83a31be5db7e3d65268186485db04d
2016-03-20 14:14:20 -04:00
});
Implement comment display/draft authoring Some additional cleanup of event names and fixing of the bubbles property not being placed in the right place. TODO in a follow-up change: + Comments are not considered in context, yet. So if there is a comment made in a span of common lines that are hidden, it will be there underneath the context control but wont show the code. Feature: Issue 3649 Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768
2015-12-20 19:13:45 -05:00
element = fixture('withComment');
element.comments = [{
author: {
name: 'Mr. Peanutbutter',
email: 'tenn1sballchaser@aol.com',
},
id: 'baf0414d_60047215',
line: 5,
message: 'is this a crossover episode!?',
updated: '2015-12-08 19:48:33.843000000',
}];
flushAsynchronousOperations();
});
test('reply', function(done) {
var commentEl = element.$$('gr-diff-comment');
assert.ok(commentEl);
commentEl.addEventListener('reply', function() {
Fix issue where Reply/Done were not having any effect + This was an issue with not using proper array observation technique [1]. [1]: https://www.polymer-project.org/1.0/docs/devguide/properties.html#array-observation Change-Id: I79ef82636d16b3afb3bec42beeb04a8c4e5ab21f
2016-01-07 13:11:04 -05:00
var drafts = element._orderedComments.filter(function(c) {
Implement comment display/draft authoring Some additional cleanup of event names and fixing of the bubbles property not being placed in the right place. TODO in a follow-up change: + Comments are not considered in context, yet. So if there is a comment made in a span of common lines that are hidden, it will be there underneath the context control but wont show the code. Feature: Issue 3649 Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768
2015-12-20 19:13:45 -05:00
return c.__draft == true;
});
assert.equal(drafts.length, 1);
assert.notOk(drafts[0].message, 'message should be empty');
assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
done();
});
commentEl.fire('reply', {comment: commentEl.comment}, {bubbles: false});
});
Implement 'Quote' button on diff comments Also + Cleans up a TODO for a bug that isn’t existent anymore. + Doesn’t show cancel button unless editing a draft that has already been saved once. Bug: Issue 3783 Change-Id: I102d598f64e4f37eca41ff428b574e8230e298cf
2016-01-28 18:07:26 -05:00
test('quote reply', function(done) {
var commentEl = element.$$('gr-diff-comment');
assert.ok(commentEl);
commentEl.addEventListener('reply', function() {
var drafts = element._orderedComments.filter(function(c) {
return c.__draft == true;
});
assert.equal(drafts.length, 1);
Remove one space from indentation in comment quote In GWTUI, quoted comments are prepended with ' > ' on each line. This was causing strange formatting issues due to strings being trimmed on the backend (see issue for more details), and also didn't really make sense (who prefers 3 space tabs over 2 or 4?). This change removes the leading space and denotes quote levels with '> '. Bug: Issue 4811 Change-Id: Iee1a85b5b2f1a4ab46a35110be65a6b4f156eb6a
2016-11-10 10:10:14 -08:00
assert.equal(drafts[0].message, '> is this a crossover episode!?\n\n');
Implement 'Quote' button on diff comments Also + Cleans up a TODO for a bug that isn’t existent anymore. + Doesn’t show cancel button unless editing a draft that has already been saved once. Bug: Issue 3783 Change-Id: I102d598f64e4f37eca41ff428b574e8230e298cf
2016-01-28 18:07:26 -05:00
assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
done();
});
commentEl.fire('reply', {comment: commentEl.comment, quote: true},
{bubbles: false});
});
Add an 'Ack' button next to the 'Done' button Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=622838 Change-Id: Ie7db71615e2c657bbf24847cd8e6e2fc7606f5a9
2016-11-29 16:46:12 -08:00
test('ack', function(done) {
element.changeNum = '42';
element.patchNum = '1';
var commentEl = element.$$('gr-diff-comment');
assert.ok(commentEl);
commentEl.addEventListener('ack', function() {
var drafts = element._orderedComments.filter(function(c) {
return c.__draft == true;
});
assert.equal(drafts.length, 1);
assert.equal(drafts[0].message, 'Ack');
assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
done();
});
commentEl.fire('ack', {comment: commentEl.comment}, {bubbles: false});
});
Implement comment display/draft authoring Some additional cleanup of event names and fixing of the bubbles property not being placed in the right place. TODO in a follow-up change: + Comments are not considered in context, yet. So if there is a comment made in a span of common lines that are hidden, it will be there underneath the context control but wont show the code. Feature: Issue 3649 Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768
2015-12-20 19:13:45 -05:00
test('done', function(done) {
element.changeNum = '42';
element.patchNum = '1';
var commentEl = element.$$('gr-diff-comment');
assert.ok(commentEl);
commentEl.addEventListener('done', function() {
Fix issue where Reply/Done were not having any effect + This was an issue with not using proper array observation technique [1]. [1]: https://www.polymer-project.org/1.0/docs/devguide/properties.html#array-observation Change-Id: I79ef82636d16b3afb3bec42beeb04a8c4e5ab21f
2016-01-07 13:11:04 -05:00
var drafts = element._orderedComments.filter(function(c) {
Implement comment display/draft authoring Some additional cleanup of event names and fixing of the bubbles property not being placed in the right place. TODO in a follow-up change: + Comments are not considered in context, yet. So if there is a comment made in a span of common lines that are hidden, it will be there underneath the context control but wont show the code. Feature: Issue 3649 Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768
2015-12-20 19:13:45 -05:00
return c.__draft == true;
});
assert.equal(drafts.length, 1);
assert.equal(drafts[0].message, 'Done');
assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
done();
});
commentEl.fire('done', {comment: commentEl.comment}, {bubbles: false});
});
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
Implement comment display/draft authoring Some additional cleanup of event names and fixing of the bubbles property not being placed in the right place. TODO in a follow-up change: + Comments are not considered in context, yet. So if there is a comment made in a span of common lines that are hidden, it will be there underneath the context control but wont show the code. Feature: Issue 3649 Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768
2015-12-20 19:13:45 -05:00
test('discard', function(done) {
element.changeNum = '42';
element.patchNum = '1';
Fix issue where Reply/Done were not having any effect + This was an issue with not using proper array observation technique [1]. [1]: https://www.polymer-project.org/1.0/docs/devguide/properties.html#array-observation Change-Id: I79ef82636d16b3afb3bec42beeb04a8c4e5ab21f
2016-01-07 13:11:04 -05:00
element.push('comments', element._newReply(
Implement comment display/draft authoring Some additional cleanup of event names and fixing of the bubbles property not being placed in the right place. TODO in a follow-up change: + Comments are not considered in context, yet. So if there is a comment made in a span of common lines that are hidden, it will be there underneath the context control but wont show the code. Feature: Issue 3649 Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768
2015-12-20 19:13:45 -05:00
element.comments[0].id,
element.comments[0].line,
element.comments[0].path,
'it’s pronouced jiff, not giff'));
flushAsynchronousOperations();
var draftEl =
Polymer.dom(element.root).querySelectorAll('gr-diff-comment')[1];
assert.ok(draftEl);
Properly remove discarded comments from model in gr-new-diff Change-Id: Icb5d3ba1edd2cd3a75aa6568a152bacc5e0babda
2016-03-25 11:29:36 -04:00
draftEl.addEventListener('comment-discard', function() {
Implement comment display/draft authoring Some additional cleanup of event names and fixing of the bubbles property not being placed in the right place. TODO in a follow-up change: + Comments are not considered in context, yet. So if there is a comment made in a span of common lines that are hidden, it will be there underneath the context control but wont show the code. Feature: Issue 3649 Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768
2015-12-20 19:13:45 -05:00
var drafts = element.comments.filter(function(c) {
return c.__draft == true;
});
assert.equal(drafts.length, 0);
done();
});
Properly remove discarded comments from model in gr-new-diff Change-Id: Icb5d3ba1edd2cd3a75aa6568a152bacc5e0babda
2016-03-25 11:29:36 -04:00
draftEl.fire('comment-discard', null, {bubbles: false});
Implement comment display/draft authoring Some additional cleanup of event names and fixing of the bubbles property not being placed in the right place. TODO in a follow-up change: + Comments are not considered in context, yet. So if there is a comment made in a span of common lines that are hidden, it will be there underneath the context control but wont show the code. Feature: Issue 3649 Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768
2015-12-20 19:13:45 -05:00
});
Update comment thread model on comment update Update comments collection in gr-diff-comment-thread when its child comment changes. Child comment is expected to send comment-update event. Change-Id: I8116820679b29b7511719f95ae73b48e2345102c
2016-06-14 16:57:23 -07:00
test('comment-update', function() {
var commentEl = element.$$('gr-diff-comment');
var updatedComment = {
id: element.comments[0].id,
foo: 'bar',
};
commentEl.fire('comment-update', {comment: updatedComment});
assert.strictEqual(element.comments[0], updatedComment);
});
Add orphan comments as top-level comments Add comments that are replies to ones missing from comment thread as top-level comments to the thread instead of discarding. Change-Id: Ib93fa1c74f1ca004ee2361e017dc1210c42ec399
2016-06-15 16:05:14 -07:00
test('orphan replies', function() {
var comments = [
{
id: 'jacks_reply',
message: 'i like you, too',
in_reply_to: 'sallys_confession',
updated: '2015-12-25 15:00:20.396000000',
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
}, {
Add orphan comments as top-level comments Add comments that are replies to ones missing from comment thread as top-level comments to the thread instead of discarding. Change-Id: Ib93fa1c74f1ca004ee2361e017dc1210c42ec399
2016-06-15 16:05:14 -07:00
id: 'sallys_confession',
in_reply_to: 'nonexistent_comment',
message: 'i like you, jack',
updated: '2015-12-24 15:00:20.396000000',
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
}, {
Add orphan comments as top-level comments Add comments that are replies to ones missing from comment thread as top-level comments to the thread instead of discarding. Change-Id: Ib93fa1c74f1ca004ee2361e017dc1210c42ec399
2016-06-15 16:05:14 -07:00
id: 'sally_to_dr_finklestein',
in_reply_to: 'nonexistent_comment',
message: 'i’m running away',
updated: '2015-10-31 09:00:20.396000000',
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
}, {
Add orphan comments as top-level comments Add comments that are replies to ones missing from comment thread as top-level comments to the thread instead of discarding. Change-Id: Ib93fa1c74f1ca004ee2361e017dc1210c42ec399
2016-06-15 16:05:14 -07:00
id: 'sallys_defiance',
message: 'i will poison you so i can get away',
updated: '2015-10-31 15:00:20.396000000',
}];
element.comments = comments;
assert.equal(4, element._orderedComments.length);
});
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
test('keyboard shortcuts', function() {
var comments = [
{
id: 'jacks_reply',
message: 'i like you, too',
in_reply_to: 'sallys_confession',
updated: '2015-12-25 15:00:20.396000000',
}, {
id: 'sallys_confession',
in_reply_to: 'nonexistent_comment',
message: 'i like you, jack',
updated: '2015-12-24 15:00:20.396000000',
}, {
id: 'sally_to_dr_finklestein',
in_reply_to: 'nonexistent_comment',
message: 'i’m running away',
updated: '2015-10-31 09:00:20.396000000',
}, {
id: 'sallys_defiance',
message: 'i will poison you so i can get away',
updated: '2015-10-31 15:00:20.396000000',
}];
element.comments = comments;
var expandCollapseStub = sinon.stub(element, '_expandCollapseComments');
Cleanup: use iron-a11y-keys-behavior for keyboard shortcuts + This does not cover on-keydown handlers within elements. A follow-up change will account for those. + Keyboard shortcuts are disabled within gr-overlay, input, and textarea elements. + Added tests for new behavior (plus some missing ones covering broken behavior). + Removed blur hacks used on elements to placate the kb shortcuts due to restrictions that have been removed. Bug: Issue 4198 Change-Id: Ide8009a3bfc340a35a8ec8b9189a85b49c8a95aa
2016-11-15 17:01:15 -08:00
MockInteractions.pressAndReleaseKeyOn(element, 69, null, 'e');
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
assert.isTrue(expandCollapseStub.lastCall.calledWith(false));
Cleanup: use iron-a11y-keys-behavior for keyboard shortcuts + This does not cover on-keydown handlers within elements. A follow-up change will account for those. + Keyboard shortcuts are disabled within gr-overlay, input, and textarea elements. + Added tests for new behavior (plus some missing ones covering broken behavior). + Removed blur hacks used on elements to placate the kb shortcuts due to restrictions that have been removed. Bug: Issue 4198 Change-Id: Ide8009a3bfc340a35a8ec8b9189a85b49c8a95aa
2016-11-15 17:01:15 -08:00
MockInteractions.pressAndReleaseKeyOn(element, 69, 'shift', 'e');
Keyboard shortcuts to expand and collapse all comments This change adds keyboard shortcuts to the "gr-diff-comment-thread" expand all comments when 'e' is pressed and collapse all comments when 'shift + e' is pressed. Note that the keyboard event is detected on the thread instead of the comment to minimize the number of events getting triggered. Feature: Issue 4738 Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835
2016-10-10 17:31:56 -07:00
assert.isTrue(expandCollapseStub.lastCall.calledWith(true));
expandCollapseStub.restore();
});
[PolyGerrit] Render (read-only) comments and column width ruler. Also some small additional changes as well: + Correct some :host selectors that were causing issues when Shadow DOM was used instead of Shady DOM. + Two of the same revisions should not be shown in side-by-side view. When two are specified via the url as /N..N/ redirect to /N/. + Added header to the diff view to give context and allow the user to go back to the top-level change. Feature: Issue 3676 Feature: Issue 3648 Feature: Issue 3649 Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b
2015-11-18 16:31:18 -05:00
});
</script>
Copy Permalink