Merge "Allow to get all external IDs by account and email"

gerrit-server/src/main/java/com/google/gerrit/server/account/externalids/DisabledExternalIdCache.java

@@ -89,8 +89,18 @@ public class DisabledExternalIdCache implements ExternalIdCache {
     throw new UnsupportedOperationException();
   }
 
+  @Override
+  public ImmutableSetMultimap<Account.Id, ExternalId> allByAccount() throws IOException {
+    throw new UnsupportedOperationException();
+  }
+
   @Override
   public ImmutableSetMultimap<String, ExternalId> byEmails(String... emails) throws IOException {
     throw new UnsupportedOperationException();
   }
+
+  @Override
+  public ImmutableSetMultimap<String, ExternalId> allByEmail() throws IOException {
+    throw new UnsupportedOperationException();
+  }
 }

gerrit-server/src/main/java/com/google/gerrit/server/account/externalids/ExternalIdCache.java

@@ -82,8 +82,12 @@ interface ExternalIdCache {
 
   Set<ExternalId> byAccount(Account.Id accountId) throws IOException;
 
+  ImmutableSetMultimap<Account.Id, ExternalId> allByAccount() throws IOException;
+
   ImmutableSetMultimap<String, ExternalId> byEmails(String... emails) throws IOException;
 
+  ImmutableSetMultimap<String, ExternalId> allByEmail() throws IOException;
+
   default ImmutableSet<ExternalId> byEmail(String email) throws IOException {
     return byEmails(email).get(email);
   }

gerrit-server/src/main/java/com/google/gerrit/server/account/externalids/ExternalIdCacheImpl.java

@@ -218,24 +218,34 @@ class ExternalIdCacheImpl implements ExternalIdCache {
 
   @Override
   public Set<ExternalId> byAccount(Account.Id accountId) throws IOException {
-    try {
-      return extIdsByAccount.get(externalIdReader.readRevision()).byAccount().get(accountId);
-    } catch (ExecutionException e) {
-      throw new IOException("Cannot list external ids by account", e);
-    }
+    return get().byAccount().get(accountId);
+  }
+
+  @Override
+  public ImmutableSetMultimap<Account.Id, ExternalId> allByAccount() throws IOException {
+    return get().byAccount();
   }
 
   @Override
   public ImmutableSetMultimap<String, ExternalId> byEmails(String... emails) throws IOException {
+    AllExternalIds allExternalIds = get();
+    ImmutableSetMultimap.Builder<String, ExternalId> byEmails = ImmutableSetMultimap.builder();
+    for (String email : emails) {
+      byEmails.putAll(email, allExternalIds.byEmail().get(email));
+    }
+    return byEmails.build();
+  }
+
+  @Override
+  public ImmutableSetMultimap<String, ExternalId> allByEmail() throws IOException {
+    return get().byEmail();
+  }
+
+  private AllExternalIds get() throws IOException {
     try {
-      AllExternalIds allExternalIds = extIdsByAccount.get(externalIdReader.readRevision());
-      ImmutableSetMultimap.Builder<String, ExternalId> byEmails = ImmutableSetMultimap.builder();
-      for (String email : emails) {
-        byEmails.putAll(email, allExternalIds.byEmail().get(email));
-      }
-      return byEmails.build();
+      return extIdsByAccount.get(externalIdReader.readRevision());
     } catch (ExecutionException e) {
-      throw new IOException("Cannot list external ids by email", e);
+      throw new IOException("Cannot load external ids", e);
     }
   }
 

gerrit-server/src/main/java/com/google/gerrit/server/account/externalids/ExternalIds.java

@@ -75,6 +75,11 @@ public class ExternalIds {
     return byAccount(accountId).stream().filter(e -> e.key().isScheme(scheme)).collect(toSet());
   }
 
+  /** Returns all external IDs by account. */
+  public ImmutableSetMultimap<Account.Id, ExternalId> allByAccount() throws IOException {
+    return externalIdCache.allByAccount();
+  }
+
   /**
    * Returns the external ID with the given email.
    *
@@ -109,4 +114,9 @@ public class ExternalIds {
   public ImmutableSetMultimap<String, ExternalId> byEmails(String... emails) throws IOException {
     return externalIdCache.byEmails(emails);
   }
+
+  /** Returns all external IDs by email. */
+  public ImmutableSetMultimap<String, ExternalId> allByEmail() throws IOException {
+    return externalIdCache.allByEmail();
+  }
 }