opendev/gerrit
Code Issues Proposed changes

ES6ify /gr-change-star/*

Browse Source 
Bug: Issue 6179
Change-Id: Ieea375e9d9e7ccd8fdfa4545f540da1e5fc1ddbd
This commit is contained in:
Kasper Nilsson
2017-05-15 16:12:27 -07:00
parent 8b99460e3e
commit 01d2d4f9fc
2 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
polygerrit-ui/app/elements/shared/gr-change-star/gr-change-star.js
View File

@@ -26,16 +26,16 @@
_xhrPromise: Object, // Used for testing. _xhrPromise: Object, // Used for testing.
}, },
_computeStarClass: function(starred) { _computeStarClass(starred) {
var classes = ['starButton']; const classes = ['starButton'];
if (starred) { if (starred) {
classes.push('starButton-active'); classes.push('starButton-active');
} }
return classes.join(' '); return classes.join(' ');
}, },
toggleStar: function() { toggleStar() {
var newVal = !this.change.starred; const newVal = !this.change.starred;
this.set('change.starred', newVal); this.set('change.starred', newVal);
this._xhrPromise = this.$.restAPI.saveChangeStarred(this.change._number, this._xhrPromise = this.$.restAPI.saveChangeStarred(this.change._number,
newVal); newVal);

18
polygerrit-ui/app/elements/shared/gr-change-star/gr-change-star_test.html
View File

@@ -33,12 +33,12 @@ limitations under the License.
</test-fixture> </test-fixture>
<script> <script>
suite('gr-change-star tests', function() { suite('gr-change-star tests', () => {
var element; let element;
setup(function() { setup(() => {
stub('gr-rest-api-interface', { stub('gr-rest-api-interface', {
saveChangeStarred: function() { return Promise.resolve({ok: true}); }, saveChangeStarred() { return Promise.resolve({ok: true}); },
}); });
element = fixture('basic'); element = fixture('basic');
element.change = { element.change = {
@@ -47,7 +47,7 @@ limitations under the License.
}; };
}); });
test('star visibility states', function() { test('star visibility states', () => {
element.set('change.starred', true); element.set('change.starred', true);
assert.isTrue(element.$$('button').classList.contains('starButton')); assert.isTrue(element.$$('button').classList.contains('starButton'));
assert.isTrue( assert.isTrue(
@@ -59,21 +59,21 @@ limitations under the License.
element.$$('button').classList.contains('starButton-active')); element.$$('button').classList.contains('starButton-active'));
}); });
test('starring', function(done) { test('starring', done => {
element.set('change.starred', false); element.set('change.starred', false);
MockInteractions.tap(element.$$('button')); MockInteractions.tap(element.$$('button'));
element._xhrPromise.then(function(req) { element._xhrPromise.then(req => {
assert.equal(element.change.starred, true); assert.equal(element.change.starred, true);
done(); done();
}); });
}); });
test('unstarring', function(done) { test('unstarring', done => {
element.set('change.starred', true); element.set('change.starred', true);
MockInteractions.tap(element.$$('button')); MockInteractions.tap(element.$$('button'));
element._xhrPromise.then(function(req) { element._xhrPromise.then(req => {
assert.equal(element.change.starred, false); assert.equal(element.change.starred, false);
done(); done();
}); });