diff --git a/gerrit-lucene/src/main/java/com/google/gerrit/lucene/LuceneChangeIndex.java b/gerrit-lucene/src/main/java/com/google/gerrit/lucene/LuceneChangeIndex.java index 77b364c4b1..c137d1ed0d 100644 --- a/gerrit-lucene/src/main/java/com/google/gerrit/lucene/LuceneChangeIndex.java +++ b/gerrit-lucene/src/main/java/com/google/gerrit/lucene/LuceneChangeIndex.java @@ -377,7 +377,7 @@ public class LuceneChangeIndex implements ChangeIndex { close(); throw new OrmRuntimeException(e); } catch (ExecutionException e) { - Throwables.propagateIfPossible(e.getCause()); + Throwables.throwIfUnchecked(e.getCause()); throw new OrmRuntimeException(e.getCause()); } } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountLoader.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountLoader.java index f84d399ced..89e941949e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountLoader.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountLoader.java @@ -94,7 +94,7 @@ public class AccountLoader { directory.fillAccountInfo( Iterables.concat(created.values(), provided), options); } catch (DirectoryException e) { - Throwables.propagateIfPossible(e.getCause(), OrmException.class); + Throwables.throwIfInstanceOf(e.getCause(), OrmException.class); throw new OrmException(e); } } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/GetDetail.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/GetDetail.java index 81c860e754..e47ceb3fc6 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/GetDetail.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/GetDetail.java @@ -47,7 +47,7 @@ public class GetDetail implements RestReadView { directory.fillAccountInfo(Collections.singleton(info), EnumSet.allOf(FillOptions.class)); } catch (DirectoryException e) { - Throwables.propagateIfPossible(e.getCause(), OrmException.class); + Throwables.throwIfInstanceOf(e.getCause(), OrmException.class); throw new OrmException(e); } return info; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java b/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java index 35678115db..354dc62017 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java @@ -154,8 +154,8 @@ import javax.security.auth.login.LoginException; } }); } catch (PrivilegedActionException e) { - Throwables.propagateIfPossible(e.getException(), NamingException.class); - Throwables.propagateIfPossible(e.getException(), RuntimeException.class); + Throwables.throwIfInstanceOf(e.getException(), NamingException.class); + Throwables.throwIfInstanceOf(e.getException(), RuntimeException.class); LdapRealm.log.warn("Internal error", e.getException()); return null; } finally { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java index a6c2edfb27..ab92a97219 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java @@ -267,7 +267,7 @@ public class ChangeJson { } catch (PatchListNotAvailableException | GpgException | OrmException | IOException | RuntimeException e) { if (!has(CHECK)) { - Throwables.propagateIfPossible(e, OrmException.class); + Throwables.throwIfInstanceOf(e, OrmException.class); throw new OrmException(e); } return checkOnly(cd); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/BatchUpdate.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/BatchUpdate.java index 090d99da82..eb01de342e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/BatchUpdate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/BatchUpdate.java @@ -464,7 +464,7 @@ public class BatchUpdate implements AutoCloseable { throw new ResourceNotFoundException(e.getMessage(), e); } catch (Exception e) { - Throwables.propagateIfPossible(e); + Throwables.throwIfUnchecked(e); throw new UpdateException(e); } } @@ -669,7 +669,7 @@ public class BatchUpdate implements AutoCloseable { logDebug("No objects to flush"); } } catch (Exception e) { - Throwables.propagateIfPossible(e, RestApiException.class); + Throwables.throwIfInstanceOf(e, RestApiException.class); throw new UpdateException(e); } } @@ -744,8 +744,8 @@ public class BatchUpdate implements AutoCloseable { maybeLogSlowUpdate(startNanos, "NoteDb"); } } catch (ExecutionException | InterruptedException e) { - Throwables.propagateIfInstanceOf(e.getCause(), UpdateException.class); - Throwables.propagateIfInstanceOf(e.getCause(), RestApiException.class); + Throwables.throwIfInstanceOf(e.getCause(), UpdateException.class); + Throwables.throwIfInstanceOf(e.getCause(), RestApiException.class); throw new UpdateException(e); } catch (OrmException | IOException e) { throw new UpdateException(e); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/RepoSequence.java b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/RepoSequence.java index 071e12cfef..c47fd4f17e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/RepoSequence.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/RepoSequence.java @@ -197,7 +197,7 @@ public class RepoSequence { limit = counter + count; acquireCount++; } catch (ExecutionException | RetryException e) { - Throwables.propagateIfInstanceOf(e.getCause(), OrmException.class); + Throwables.throwIfInstanceOf(e.getCause(), OrmException.class); throw new OrmException(e); } catch (IOException e) { throw new OrmException(e); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineLoader.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineLoader.java index dd15cfc6f7..ae37c018c7 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineLoader.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineLoader.java @@ -93,7 +93,7 @@ class IntraLineLoader implements Callable { } catch (ExecutionException e) { // If there was an error computing the result, carry it // up to the caller so the cache knows this key is invalid. - Throwables.propagateIfInstanceOf(e.getCause(), Exception.class); + Throwables.throwIfInstanceOf(e.getCause(), Exception.class); throw new Exception(e.getMessage(), e.getCause()); } } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListLoader.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListLoader.java index faeaaf22d1..1156b91f05 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListLoader.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListLoader.java @@ -260,7 +260,7 @@ public class PatchListLoader implements Callable { } catch (ExecutionException e) { // If there was an error computing the result, carry it // up to the caller so the cache knows this key is invalid. - Throwables.propagateIfInstanceOf(e.getCause(), IOException.class); + Throwables.throwIfInstanceOf(e.getCause(), IOException.class); throw new IOException(e.getMessage(), e.getCause()); } } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectCacheImpl.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectCacheImpl.java index d27d4f97c2..2097ebd3b0 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectCacheImpl.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectCacheImpl.java @@ -148,7 +148,7 @@ public class ProjectCacheImpl implements ProjectCache { } catch (ExecutionException e) { if (!(e.getCause() instanceof RepositoryNotFoundException)) { log.warn(String.format("Cannot read project %s", projectName.get()), e); - Throwables.propagateIfInstanceOf(e.getCause(), IOException.class); + Throwables.throwIfInstanceOf(e.getCause(), IOException.class); throw new IOException(e); } return null; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/RefPattern.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/RefPattern.java index ed50a54b29..8c850fb572 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/RefPattern.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/RefPattern.java @@ -49,7 +49,7 @@ public class RefPattern { try { return exampleCache.get(refPattern); } catch (ExecutionException e) { - Throwables.propagateIfPossible(e.getCause()); + Throwables.throwIfUnchecked(e.getCause()); throw new RuntimeException(e); } } else if (refPattern.endsWith("/*")) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/AndSource.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/AndSource.java index 168be5d784..c2b8b03f61 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/AndSource.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/AndSource.java @@ -84,7 +84,7 @@ public class AndSource extends AndPredicate try { return readImpl(); } catch (OrmRuntimeException err) { - Throwables.propagateIfInstanceOf(err.getCause(), OrmException.class); + Throwables.throwIfInstanceOf(err.getCause(), OrmException.class); throw new OrmException(err); } } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/QueryProcessor.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/QueryProcessor.java index d08f05ce66..70bdffbcb9 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/QueryProcessor.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/QueryProcessor.java @@ -140,7 +140,7 @@ public abstract class QueryProcessor { } catch (OrmRuntimeException e) { throw new OrmException(e.getMessage(), e); } catch (OrmException e) { - Throwables.propagateIfInstanceOf(e.getCause(), QueryParseException.class); + Throwables.throwIfInstanceOf(e.getCause(), QueryParseException.class); throw e; } } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/util/RequestScopePropagator.java b/gerrit-server/src/main/java/com/google/gerrit/server/util/RequestScopePropagator.java index 382485ee84..bdbb93867b 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/util/RequestScopePropagator.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/util/RequestScopePropagator.java @@ -129,7 +129,7 @@ public abstract class RequestScopePropagator { try { wrapped.call(); } catch (Exception e) { - Throwables.propagateIfPossible(e); + Throwables.throwIfUnchecked(e); throw new RuntimeException(e); // Not possible. } } diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/AliasCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/AliasCommand.java index fde3a668d6..4ddca0c84c 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/AliasCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/AliasCommand.java @@ -97,7 +97,7 @@ public class AliasCommand extends BaseCommand { try { cmd.destroy(); } catch (Exception e) { - Throwables.propagateIfPossible(e); + Throwables.throwIfUnchecked(e); throw new RuntimeException(e); } } diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DispatchCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DispatchCommand.java index f2911dca0a..f3243c6dc1 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DispatchCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DispatchCommand.java @@ -136,7 +136,7 @@ final class DispatchCommand extends BaseCommand { try { cmd.destroy(); } catch (Exception e) { - Throwables.propagateIfPossible(e); + Throwables.throwIfUnchecked(e); throw new RuntimeException(e); } } diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SuExec.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SuExec.java index 24bd8c29f5..c88a02cbe7 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SuExec.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SuExec.java @@ -153,7 +153,7 @@ public final class SuExec extends BaseCommand { try { cmd.destroy(); } catch (Exception e) { - Throwables.propagateIfPossible(e); + Throwables.throwIfUnchecked(e); throw new RuntimeException(e); } } diff --git a/lib/BUCK b/lib/BUCK index 2d931c250e..2496df7bf5 100644 --- a/lib/BUCK +++ b/lib/BUCK @@ -66,9 +66,10 @@ maven_jar( maven_jar( name = 'guava', - id = 'com.google.guava:guava:19.0', - sha1 = '6ce200f6b23222af3d8abb6b6459e6c44f4bb0e9', + id = 'com.google.guava:guava:20.0:20160818.201422-323', + sha1 = '13af7470db1026c57aedd0144018e06fe79bba33', license = 'Apache2.0', + repository = MAVEN_SNAPSHOT, ) maven_jar( diff --git a/plugins/replication b/plugins/replication index c5123d6a56..9a83958465 160000 --- a/plugins/replication +++ b/plugins/replication @@ -1 +1 @@ -Subproject commit c5123d6a5604cc740d6f42485235c0d3ec141c4e +Subproject commit 9a8395846516d65158b1b2bb59deb9aa6537e820