opendev/gerrit
Code Issues Proposed changes

Rename CreateProject to PerformCreateProject

Browse Source 
As a preparatory step for "Add REST API for 'create project' on WebUI"
where there is a new CreateProject which implements RestModifyView.

Change-Id: I047cd7c9d2c8d0b779d1aa65d89600a6d4abbbaa
This commit is contained in:
Bruce Zu
2013-02-20 13:01:47 +08:00
committed by Edwin Kempin
parent a38e2383ff
commit 01eac64ee1
4 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/CreateProjectHandler.java
View File

@@ -18,7 +18,7 @@ import com.google.gerrit.common.errors.ProjectCreationFailedException;
import com.google.gerrit.httpd.rpc.Handler;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.reviewdb.client.Project.SubmitType;
import com.google.gerrit.server.project.CreateProject;
import com.google.gerrit.server.project.PerformCreateProject;
import com.google.gerrit.server.project.CreateProjectArgs;
import com.google.gerrit.server.project.NoSuchProjectException;
import com.google.gerrit.server.project.ProjectControl;
@@ -37,7 +37,7 @@ public class CreateProjectHandler extends Handler<VoidResult> {
@Assisted("permissionsOnly") boolean permissionsOnly);
}
private final CreateProject.Factory createProjectFactory;
private final PerformCreateProject.Factory createProjectFactory;
private final ProjectControl.Factory projectControlFactory;
private final String projectName;
private final String parentName;
@@ -45,7 +45,7 @@ public class CreateProjectHandler extends Handler<VoidResult> {
private final boolean permissionsOnly;
@Inject
public CreateProjectHandler(final CreateProject.Factory createProjectFactory,
public CreateProjectHandler(final PerformCreateProject.Factory createProjectFactory,
final ProjectControl.Factory projectControlFactory,
@Assisted("projectName") final String projectName,
@Assisted("parentName") final String parentName,
@@ -78,7 +78,7 @@ public class CreateProjectHandler extends Handler<VoidResult> {
args.createEmptyCommit = emptyCommit;
args.permissionsOnly = permissionsOnly;
final CreateProject createProject = createProjectFactory.create(args);
final PerformCreateProject createProject = createProjectFactory.create(args);
createProject.createProject();
return VoidResult.INSTANCE;
}

4
gerrit-server/src/main/java/com/google/gerrit/server/config/GerritRequestModule.java
View File

@@ -27,7 +27,7 @@ import com.google.gerrit.server.git.MetaDataUpdate;
import com.google.gerrit.server.git.SubmoduleOp;
import com.google.gerrit.server.patch.RemoveReviewer;
import com.google.gerrit.server.project.ChangeControl;
import com.google.gerrit.server.project.CreateProject;
import com.google.gerrit.server.project.PerformCreateProject;
import com.google.gerrit.server.project.PerRequestProjectControlCache;
import com.google.gerrit.server.project.ProjectControl;
import com.google.gerrit.server.project.SuggestParentCandidates;
@@ -56,7 +56,7 @@ public class GerritRequestModule extends FactoryModule {
factory(DeleteDraftPatchSet.Factory.class);
factory(PublishDraft.Factory.class);
factory(RemoveReviewer.Factory.class);
factory(CreateProject.Factory.class);
factory(PerformCreateProject.Factory.class);
factory(SuggestParentCandidates.Factory.class);
factory(BanCommit.Factory.class);
}

8
gerrit-server/src/main/java/com/google/gerrit/server/project/CreateProject.java → gerrit-server/src/main/java/com/google/gerrit/server/project/PerformCreateProject.java
View File

@@ -59,12 +59,12 @@ import java.util.Set;
/** Common class that holds the code to create projects */
public class CreateProject {
public class PerformCreateProject {
private static final Logger log = LoggerFactory
.getLogger(CreateProject.class);
.getLogger(PerformCreateProject.class);
public interface Factory {
CreateProject create(CreateProjectArgs createProjectArgs);
PerformCreateProject create(CreateProjectArgs createProjectArgs);
}
private final Set<AccountGroup.UUID> projectOwnerGroups;
@@ -79,7 +79,7 @@ public class CreateProject {
private MetaDataUpdate.User metaDataUpdateFactory;
@Inject
CreateProject(@ProjectOwnerGroups Set<AccountGroup.UUID> pOwnerGroups,
PerformCreateProject(@ProjectOwnerGroups Set<AccountGroup.UUID> pOwnerGroups,
IdentifiedUser identifiedUser, GitRepositoryManager gitRepoManager,
GitReferenceUpdated referenceUpdated,
DynamicSet<NewProjectCreatedListener> createdListener,

7
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateProjectCommand.java
View File

@@ -21,7 +21,7 @@ import com.google.gerrit.reviewdb.client.AccountGroup;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.reviewdb.client.Project.InheritableBoolean;
import com.google.gerrit.reviewdb.client.Project.SubmitType;
import com.google.gerrit.server.project.CreateProject;
import com.google.gerrit.server.project.PerformCreateProject;
import com.google.gerrit.server.project.CreateProjectArgs;
import com.google.gerrit.server.project.ProjectControl;
import com.google.gerrit.server.project.SuggestParentCandidates;
@@ -118,7 +118,7 @@ final class CreateProjectCommand extends SshCommand {
}
@Inject
private CreateProject.Factory CreateProjectFactory;
private PerformCreateProject.Factory factory;
@Inject
private SuggestParentCandidates.Factory suggestParentCandidatesFactory;
@@ -144,8 +144,7 @@ final class CreateProjectCommand extends SshCommand {
args.branch = branch;
args.createEmptyCommit = createEmptyCommit;
final CreateProject createProject =
CreateProjectFactory.create(args);
final PerformCreateProject createProject = factory.create(args);
createProject.createProject();
} else {
List<Project.NameKey> parentCandidates =