opendev/gerrit
Code Issues Proposed changes

Normalize HTML email font sizes

Browse Source 
Adjust the font-size monospace text in HTML emails to be more consistent
across email clients (gMail, Inbox, Mail.app, mobile). Also make the
font-size in the change footer smaller.

Change-Id: I020a4fed4aaf8920e98f439df8d7bb39003fee48
This commit is contained in:
Wyatt Allen
2016-10-17 17:05:24 -07:00
parent 2223cb7c52
commit 02279866b9
11 changed files with 18 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/resources/com/google/gerrit/server/mail/AbandonedHtml.soy
View File

@@ -39,6 +39,6 @@
<hr/> <hr/>
{if $coverLetter} {if $coverLetter}
<pre>{$coverLetter}</pre> <pre style="font-size:12px">{$coverLetter}</pre>
{/if} {/if}
{/template} {/template}

1
gerrit-server/src/main/resources/com/google/gerrit/server/mail/ChangeFooterHtml.soy
View File

@@ -28,6 +28,7 @@
{template .ChangeFooterHtml autoescape="strict" kind="html"} {template .ChangeFooterHtml autoescape="strict" kind="html"}
{let $footerStyle kind="css"} {let $footerStyle kind="css"}
color: #555; color: #555;
font-size: 10px;
margin: 10px 0 0 0; margin: 10px 0 0 0;
{/let} {/let}

1
gerrit-server/src/main/resources/com/google/gerrit/server/mail/CommentFooterHtml.soy
View File

@@ -22,6 +22,7 @@
{template .CommentFooterHtml autoescape="strict" kind="html"} {template .CommentFooterHtml autoescape="strict" kind="html"}
{let $footerStyle kind="css"} {let $footerStyle kind="css"}
color: #555; color: #555;
font-size: 10px;
margin: 0; margin: 0;
{/let} {/let}

6
gerrit-server/src/main/resources/com/google/gerrit/server/mail/CommentHtml.soy
View File

@@ -58,7 +58,7 @@
<hr/> <hr/>
{if $coverLetter} {if $coverLetter}
<pre>{$coverLetter}</pre> <pre style="font-size:12px">{$coverLetter}</pre>
{/if} {/if}
<ul style="{$ulStyle}"> <ul style="{$ulStyle}">
@@ -86,14 +86,14 @@
Patch Set #{$group.patchSetId}, Line {$comment.startLine}:{sp} Patch Set #{$group.patchSetId}, Line {$comment.startLine}:{sp}
{/if} {/if}
{if length($comment.lines) == 1} {if length($comment.lines) == 1}
<code>{$comment.lines[0]}</code> <code style="font-size:12px">{$comment.lines[0]}</code>
{/if} {/if}
</p> </p>
{if length($comment.lines) > 1} {if length($comment.lines) > 1}
<p> <p>
<blockquote style="{$blockquoteStyle}"> <blockquote style="{$blockquoteStyle}">
<pre> <pre style="font-size:12px">
{foreach $line in $comment.lines} {foreach $line in $comment.lines}
{$line}{\n} {$line}{\n}
{/foreach} {/foreach}

2
gerrit-server/src/main/resources/com/google/gerrit/server/mail/DeleteReviewerHtml.soy
View File

@@ -44,6 +44,6 @@
<hr/> <hr/>
{if $coverLetter} {if $coverLetter}
<pre>{$coverLetter}</pre> <pre style="font-size:12px">{$coverLetter}</pre>
{/if} {/if}
{/template} {/template}

2
gerrit-server/src/main/resources/com/google/gerrit/server/mail/DeleteVoteHtml.soy
View File

@@ -39,6 +39,6 @@
<hr/> <hr/>
{if $coverLetter} {if $coverLetter}
<pre>{$coverLetter}</pre> <pre style="font-size:12px">{$coverLetter}</pre>
{/if} {/if}
{/template} {/template}

6
gerrit-server/src/main/resources/com/google/gerrit/server/mail/MergedHtml.soy
View File

@@ -37,16 +37,16 @@
</p> </p>
<hr/> <hr/>
<pre> <pre style="font-size:12px">
{$email.changeDetail} {$email.changeDetail}
</pre> </pre>
<pre> <pre style="font-size:12px">
{$email.approvals} {$email.approvals}
</pre> </pre>
{if $email.includeDiff} {if $email.includeDiff}
<pre> <pre style="font-size:12px">
{$email.unifiedDiff} {$email.unifiedDiff}
</pre> </pre>
{/if} {/if}

6
gerrit-server/src/main/resources/com/google/gerrit/server/mail/NewChangeHtml.soy
View File

@@ -59,19 +59,19 @@
</p> </p>
<hr/> <hr/>
<pre> <pre style="font-size:12px">
{$email.changeDetail} {$email.changeDetail}
</pre> </pre>
{if $email.sshHost} {if $email.sshHost}
<pre> <pre style="font-size:12px">
git pull ssh:{print '//'}{$email.sshHost}/{$projectName} git pull ssh:{print '//'}{$email.sshHost}/{$projectName}
{sp}{$patchSet.refName} {sp}{$patchSet.refName}
</pre> </pre>
{/if} {/if}
{if $email.includeDiff} {if $email.includeDiff}
<pre> <pre style="font-size:12px">
{$email.unifiedDiff} {$email.unifiedDiff}
</pre> </pre>
{/if} {/if}

4
gerrit-server/src/main/resources/com/google/gerrit/server/mail/ReplacePatchSetHtml.soy
View File

@@ -59,12 +59,12 @@
</p> </p>
<hr/> <hr/>
<pre> <pre style="font-size:12px">
{$email.changeDetail} {$email.changeDetail}
</pre> </pre>
{if $email.sshHost} {if $email.sshHost}
<pre> <pre style="font-size:12px">
git pull ssh:{print '//'}{$email.sshHost}/{$projectName}{sp} git pull ssh:{print '//'}{$email.sshHost}/{$projectName}{sp}
{$patchSet.refName} {$patchSet.refName}
</pre> </pre>

2
gerrit-server/src/main/resources/com/google/gerrit/server/mail/RestoredHtml.soy
View File

@@ -39,6 +39,6 @@
<hr/> <hr/>
{if $coverLetter} {if $coverLetter}
<pre>{$coverLetter}</pre> <pre style="font-size:12px">{$coverLetter}</pre>
{/if} {/if}
{/template} {/template}

2
gerrit-server/src/main/resources/com/google/gerrit/server/mail/RevertedHtml.soy
View File

@@ -39,6 +39,6 @@
<hr/> <hr/>
{if $coverLetter} {if $coverLetter}
<pre>{$coverLetter}</pre> <pre style="font-size:12px">{$coverLetter}</pre>
{/if} {/if}
{/template} {/template}