opendev/gerrit
Code Issues Proposed changes

Fix polygerrit_plugin rule to include deps

Browse Source 
This allows plugins to depend on bower_component libraries (deps of
polygerrit_plugin and polygerrit_bundle are always bower components,
see also the 'zips' variable in _bundle_impl).

This prepares a fix in the image-diff plugin, which had to use an asset
to pull in the resemblejs library, which made it more complicated and
more difficult to import into google3.

Change-Id: Idb562f44f5781b6e588a156a44cd39f853afaec6
This commit is contained in:
brohlfs 2019-03-19 12:37:37 +01:00
parent 1656bd9838
commit 027551fb11
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/bzl/js.bzl
View File

@ -425,7 +425,7 @@ def bundle_assets(*args, **kwargs):
"""Combine html, js, css files and optionally split into js and html bundles."""
_bundle_rule(pkg = native.package_name(), *args, **kwargs)
def polygerrit_plugin(name, app, srcs = [], assets = None, plugin_name = None, **kwargs):
def polygerrit_plugin(name, app, srcs = [], deps = [], assets = None, plugin_name = None, **kwargs):
"""Bundles plugin dependencies for deployment.
This rule bundles all Polymer elements and JS dependencies into .html and .js files.
@ -450,6 +450,7 @@ def polygerrit_plugin(name, app, srcs = [], assets = None, plugin_name = None, *
name = name + "_combined",
app = app,
srcs = srcs,
deps = deps,
pkg = native.package_name(),
**kwargs
)