opendev/gerrit
Code Issues Proposed changes

Do not show overflow-y in gr-editable-content

Browse Source 
Because of the way iron-autogrow-textarea works, There will never be
a need to have a vertical scroll bar, as the text area expands
accordingly.

In cases where a horizontal scrollbar appeared (due to long lines of
text), the height of the textarea shrank just enough for a vertical
scrollbar to be added as well. There also appeared to be some browser
quirks in which the scroll bars jumped around when they shouldn't.
In order to prevent this from happening, hide overflow-y.

Additionally, add box-sizing: border-box to all iron-autogrow-textarea
instances, so that scrollbars appear correctly in shadow dom.

Bug: Issue 6500
Change-Id: I28f3b47d656a246decd693f637040748ec4fd3a0
This commit is contained in:
Becky Siegel
2017-07-24 10:27:27 -07:00
parent 8e2036ee1a
commit 03690330ff
6 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
polygerrit-ui/app/styles/gr-form-styles.html
View File

@@ -97,6 +97,7 @@ limitations under the License.
--iron-autogrow-textarea: {
border: 1px solid #d1d2d3;
border-radius: 2px;
box-sizing: border-box;
font-size: 1em;
padding: .25em .15em 0 .15em;
}