opendev/gerrit
Code Issues Proposed changes

Remove ChangeData factory method used only by old index schemas

Browse Source 
Change-Id: I6d004dd0a5ae23d654d073cc7e876e00ebb031c0
This commit is contained in:
Dave Borowitz
2017-08-09 09:11:32 -04:00
parent 1b15877db6
commit 03b46de12a
3 changed files with 6 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
gerrit-lucene/src/main/java/com/google/gerrit/lucene/LuceneChangeIndex.java
View File

@@ -429,14 +429,9 @@ public class LuceneChangeIndex implements ChangeIndex {
} else {
IndexableField f = Iterables.getFirst(doc.get(idFieldName), null);
Change.Id id = new Change.Id(f.numericValue().intValue());
IndexableField project = Iterables.getFirst(doc.get(PROJECT.getName()), null);
if (project == null) {
// Old schema without project field: we can safely assume NoteDb is
// disabled.
cd = changeDataFactory.createOnlyWhenNoteDbDisabled(db.get(), id);
} else {
cd = changeDataFactory.create(db.get(), new Project.NameKey(project.stringValue()), id);
}
// IndexUtils#changeFields ensures either CHANGE or PROJECT is always present.
IndexableField project = doc.get(PROJECT.getName()).iterator().next();
cd = changeDataFactory.create(db.get(), new Project.NameKey(project.stringValue()), id);
}
if (fields.contains(PATCH_SET_FIELD)) {