From 03eb9d06e51db8dba63f094da82061f3a3df5109 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Thu, 27 Jul 2017 15:08:24 +0100 Subject: [PATCH] Plugins#ListRequest: Remove parameter from all() method The default value of all is false. Change the method so that calling it sets it to true, so instead of: api.list().all(true).get() the call is: api.list().all().get() Change-Id: I8ea0a81c5ef3f7074566ef916b3a843277749e7f --- .../com/google/gerrit/acceptance/api/plugin/PluginIT.java | 3 ++- .../com/google/gerrit/extensions/api/plugins/Plugins.java | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/plugin/PluginIT.java b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/plugin/PluginIT.java index cfc6318a4c..3b3f6749c5 100644 --- a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/plugin/PluginIT.java +++ b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/plugin/PluginIT.java @@ -23,7 +23,8 @@ import org.junit.Test; @NoHttpd public class PluginIT extends AbstractDaemonTest { @Test - public void noPlugins() throws Exception { + public void list() throws Exception { assertThat(gApi.plugins().list().get()).isEmpty(); + assertThat(gApi.plugins().list().all().get()).isEmpty(); } } diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/plugins/Plugins.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/plugins/Plugins.java index 808a8252cd..ff2ad3476d 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/plugins/Plugins.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/plugins/Plugins.java @@ -40,8 +40,8 @@ public interface Plugins { public abstract SortedMap getAsMap() throws RestApiException; - public ListRequest all(boolean all) { - this.all = all; + public ListRequest all() { + this.all = true; return this; }