opendev/gerrit
Code Issues Proposed changes

Use per-project label types in Prolog submit rules

Browse Source 
Change-Id: I89fcb0b94a4f1af61d4cff7dccb18cc3dac821cd
This commit is contained in:
Dave Borowitz
2013-02-15 17:34:31 -08:00
parent 443a3a1c8f
commit 03fbaf8655
7 changed files with 118 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
gerrit-server/src/main/prolog/gerrit_common.pl
View File

@@ -214,21 +214,21 @@ locate_submit_type(RuleName) :-
:- public default_submit/1.
%%
default_submit(P) :-
get_legacy_approval_types(ApprovalTypes),
default_submit(ApprovalTypes, P).
get_legacy_label_types(LabelTypes),
default_submit(LabelTypes, P).
% Apply the old "all approval categories must be satisfied"
% loop by scanning over all of the approval types to build
% up the submit record.
% loop by scanning over all of the label types to build up the
% submit record.
%
default_submit(ApprovalTypes, P) :-
default_submit(ApprovalTypes, [], Tmp),
default_submit(LabelTypes, P) :-
default_submit(LabelTypes, [], Tmp),
reverse(Tmp, Ls),
P =.. [ submit | Ls].
default_submit([], Out, Out).
default_submit([Type | Types], Tmp, Out) :-
approval_type(Label, Id, Fun, Min, Max) = Type,
label_type(Label, Id, Fun, Min, Max) = Type,
legacy_submit_rule(Fun, Label, Id, Min, Max, Status),
R = label(Label, Status),
default_submit(Types, [R | Tmp], Out).