opendev/gerrit
Code Issues Proposed changes

Revert Add "voting disabled" text to reply dialogue for closed CLs

Browse Source 
This reverts commit 56aeaeac8f. Previously,
the backend did not support voting on merged changes which is why the
text was added to the reply dialog. Now that the backend does support 
voting on merged changes, the text is no longer needed.

Bug: Issue 4892
Change-Id: Idc55a8b58f26bb7225bb12ac96f55ed016053bef
This commit is contained in:
Becky Siegel
2016-11-15 15:00:29 -08:00
parent 214726d5ce
commit 0411b3e485
3 changed files with 0 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.html
View File

@@ -209,12 +209,6 @@ limitations under the License.
</iron-autogrow-textarea> </iron-autogrow-textarea>
</section> </section>
<section class="labelsContainer"> <section class="labelsContainer">
<template is="dom-if" if="[[_isClosed(change)]]" id="labelDisabled">
<div class="labelDisabledMessage">
Setting labels are disabled for this change because it has been
closed.
</div>
</template>
<template is="dom-repeat" <template is="dom-repeat"
items="[[_labels]]" as="label"> items="[[_labels]]" as="label">
<div class="labelContainer"> <div class="labelContainer">

6
polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js
View File

@@ -23,8 +23,6 @@
REVIEWERS: 'reviewers', REVIEWERS: 'reviewers',
}; };
var CLOSED_CHANGE_STATUSES = ['ABANDONED', 'MERGED'];
Polymer({ Polymer({
is: 'gr-reply-dialog', is: 'gr-reply-dialog',
@@ -277,10 +275,6 @@
}.bind(this)); }.bind(this));
}, },
_isClosed: function(change) {
return CLOSED_CHANGE_STATUSES.indexOf(change.status) !== -1;
},
_computeHideDraftList: function(drafts) { _computeHideDraftList: function(drafts) {
return Object.keys(drafts || {}).length == 0; return Object.keys(drafts || {}).length == 0;
}, },

12
polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog_test.html
View File

@@ -259,18 +259,6 @@ limitations under the License.
}).then(done); }).then(done);
}); });
test('message disabled dialogue appears for closed change', function() {
element.change = {status: 'ABANDONED'};
flushAsynchronousOperations();
assert.isOk(element.$$('.labelDisabledMessage'));
});
test('message disabled dialogue does not appear for open change',
function() {
element.change = {status: 'NEW'};
assert.isNotOk(element.$$('.labelDisabledMessage'));
});
test('_getStorageLocation', function() { test('_getStorageLocation', function() {
var actual = element._getStorageLocation(); var actual = element._getStorageLocation();
assert.equal(actual.changeNum, changeNum); assert.equal(actual.changeNum, changeNum);