opendev/gerrit
Code Issues Proposed changes

Simplify client code that reads the user preferences

Browse Source 
Use

  Gerrit.getUserPeferences()

instead of

  Gerrit.getUserAccount().getGeneralPreferences()

The first one returns the client side representation of the user
settings (AccountPreferencesInfo) while the second one returns the
entity class for persisting the user preferences in the database
(AccountGeneralPreferences).

Gerrit.getUserPreferences() never returns null. If the user is not
signed in the default preferences are returned. Hence we no longer
need to check with Gerrit.isSignedIn() whether the user is signed in
whenever we access the user preferences.

Change-Id: I6420c221f66299485d0cd913a55563b0cd2a9b11
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2015-07-23 10:46:03 +02:00
parent 6a56672b72
commit 042c394f80
13 changed files with 45 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AccountPreferencesInfo.java
View File

@@ -59,7 +59,11 @@ public class AccountPreferencesInfo extends JavaScriptObject {
}
public final short changesPerPage() {
return get("changes_per_page", AccountGeneralPreferences.DEFAULT_PAGESIZE);
short changesPerPage =
get("changes_per_page", AccountGeneralPreferences.DEFAULT_PAGESIZE);
return 0 < changesPerPage
? changesPerPage
: AccountGeneralPreferences.DEFAULT_PAGESIZE;
}
private final native short get(String n, int d)
/*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/;